-
Notifications
You must be signed in to change notification settings - Fork 1.5k
Retrieve facts from Amazon Certificate Manager. #2718
Conversation
Thanks @linuxdynasty for this new module. When this module receives 'shipit' comments from two community members and any 'needs_revision' comments have been resolved, we will mark for inclusion. [This message brought to you by your friendly Ansibull-bot.] |
122559e
to
0cca941
Compare
Examples below. - acm_certificate_facts: domain_name: *.foobar.com register: acm_cert - acm_certificate_facts: arn: "arn:aws:acm:us-west-2:123456789:certificate/25b4ad8a-1e24-4001-bcd0-e82fb3554cd7" (http://docs.aws.amazon.com/general/latest/gr/aws-arns-and-namespaces.html) register: acm_cert - acm_certificate_facts: register: acm_certs
0cca941
to
0d11cc5
Compare
results = LIST_CERTIFICATES | ||
except Exception as e: | ||
success = False | ||
err_msg = str(e) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd prefer if you also surface the traceback here. Just pass traceback.format_exc(e)
as the named param exception
to fail_json
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like to keep all of exiting of code within the main function. This makes it cleaner when writing unit tests for modules. At least in my opinion.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can keep exiting code out of this part of the code, just surface the traceback to the main()
caller so it can fail with the TB.
author: "Allen Sanabria (@linuxdynasty)" | ||
requirements: [boto3, botocore] | ||
options: | ||
name: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
name
is mentioned here, but examples and the rest of the code call it domain_name
.
This repository has been locked. All new issues and pull requests should be filed in https://github.com/ansible/ansible Please read through the repomerge page in the dev guide. The guide contains links to tools which automatically move your issue or pull request to the ansible/ansible repo. |
@linuxdynasty are you still interested in maintaining this? Can you please create a new PR in the right repository? If you're not interested, do you mind if I fork your code and do it myself? |
This repository has been locked. All new issues and pull requests should be filed in https://github.com/ansible/ansible Please read through the repomerge page in the dev guide. The guide contains links to tools which automatically move your issue or pull request to the ansible/ansible repo. |
ISSUE TYPE
COMPONENT NAME
acm_certificate_facts
ANSIBLE VERSION
SUMMARY
acm_certificate_facts will retrieve facts about a domain in Amazon Certificate Manager. This module depends on Pull Request 17039 in the Main Ansible Repository AWSRetry Decorator
This change is