-
Notifications
You must be signed in to change notification settings - Fork 1.5k
Updated ec2_vpc_nat_gateway to use AWSRetry decorator #2721
Updated ec2_vpc_nat_gateway to use AWSRetry decorator #2721
Conversation
fc2b03e
to
1eaebee
Compare
Thanks again to @linuxdynasty. This module is going into community review. We notice that you are one of the maintainers (@linuxdynasty) of this module, so when you think it's ready, please comment "shipit" and we will consider it for merging. [This message brought to you by your friendly Ansibull-bot.] |
1eaebee
to
de8af54
Compare
hi @linuxdynasty, since you're doing PR I want to file a suggestion for this module. In |
@linuxdynasty are you intentionally deleting all those tests? |
@ryansb I did delete the api integration tests from the PR. |
de8af54
to
cd4516e
Compare
@akurniawan, This is AWS rate limiting the number of api requests that come in. Which this PR gets around by applying the AWSRetry decorator. To answer your question, when provisioning to AWS and you are creating x amount of resources, it is possible that you will receive that Rate Limiting error in the AWS console. |
shipit |
Thanks @linuxdynasty. Since you are one of the maintainers (@linuxdynasty) of this module and you commented with "shipit", we are marking this PR for inclusion. [This message brought to you by your friendly Ansibull-bot.] |
Thanks @linuxdynasty for this PR. Unfortunately, it is not mergeable in its current state due to merge conflicts. Please rebase your PR. When you are done, please comment with text 'ready_for_review' and we will put this PR back into review. For help on how to do this cleanly please see http://docs.ansible.com/ansible/community.html#contributing-code-features-or-bugfixes [This message brought to you by your friendly Ansibull-bot.] |
@linuxdynasty A friendly reminder: this pull request has been marked as needing your action. If you still believe that this PR applies, and you intend to address the issues with this PR, just let us know in the PR itself and we will keep it open pending your changes. When you do address the issues, please respond with ready_for_review in your comment, so that we can notify the maintainer. [This message brought to you by your friendly Ansibull-bot.] |
@linuxdynasty looks good to me, but the test changes need to be made to the |
This repository has been locked. All new issues and pull requests should be filed in https://github.com/ansible/ansible Please read through the repomerge page in the dev guide. The guide contains links to tools which automatically move your issue or pull request to the ansible/ansible repo. |
1 similar comment
This repository has been locked. All new issues and pull requests should be filed in https://github.com/ansible/ansible Please read through the repomerge page in the dev guide. The guide contains links to tools which automatically move your issue or pull request to the ansible/ansible repo. |
ISSUE TYPE
COMPONENT NAME
ec2_vpc_nat_gateway
ANSIBLE VERSION
SUMMARY
Updated ec2_vpc_nat_gateway to use the AWSRetry.backoff decorator. Also added fix, to make sure all output is returned in lower case. This module depends on the Pull Request AWSRetry.
This change is