add module to gather facts from Webfaction #710

Open
wants to merge 2 commits into
from

Projects

None yet

5 participants

@bachp
bachp commented Jul 12, 2015

This module allows gather facts about:

  • applications
  • websites
  • databases
  • domains
@gregdek
Contributor
gregdek commented Jul 13, 2015

Thanks for submitting this new module.

To help facilitate reviews, we’ve broadened the number of people who can approve modules for inclusion into the Extras repository. The list of official reviewers can be found here:

https://github.com/ansible/ansible-modules-extras/blob/devel/REVIEWERS.md

Our new policy is that if a new module is reviewed and approved by at least two official module reviewers, and receives no -1 votes, the module will be approved for inclusion. We will be asking the community of reviewers to take a look at these modules on a regular basis.

To ensure that your module has the best chance of being approved, please double-check that you adhere to the Ansible module guidelines: http://docs.ansible.com/developing_modules.html#module-checklist

@resmo resmo commented on an outdated diff Jul 19, 2015
cloud/webfaction/webfaction_facts.py
+ webfaction_facts:
+ login_name={{webfaction_user}}
+ login_password={{webfaction_passwd}}
+ machine={{webfaction_machine}}
+'''
+
+import xmlrpclib
+
+webfaction = xmlrpclib.ServerProxy('https://api.webfaction.com/')
+
+def main():
+
+ module = AnsibleModule(
+ argument_spec = dict(
+ login_name = dict(required=True),
+ login_password = dict(required=True),
@resmo
resmo Jul 19, 2015 Contributor

prevent password being logged by adding no_log=True i.e. login_password = dict(required=True, no_log=True),

@resmo resmo commented on the diff Jul 19, 2015
cloud/webfaction/webfaction_facts.py
+options:
+
+ login_name:
+ description:
+ - The webfaction account to use
+ required: true
+
+ login_password:
+ description:
+ - The webfaction password to use
+ required: true
+
+ machine:
+ description:
+ - The machine name to use (optional for accounts with only one machine)
+ required: false
@resmo
resmo Jul 19, 2015 Contributor

add a default if required: false e.g. default: null or default: none in this case

@bachp
bachp commented Jul 22, 2015

@resmo I updated the pull request based on your feedback.

@bachp
bachp commented Aug 19, 2015

I have this version no in use to deploy to one of our production server without issues.

@gregdek
Contributor
gregdek commented Sep 25, 2015

Adding new process. We will be evaluating all new module PRs according to this process, effective immediately.

Thanks for submitting this new module to Ansible Extras! This module is now in community review, a process that is open to all Ansible users. In order for this module to be approved, it must gain the following votes:

“works_for_me”: If you have tested the module thoroughly, including testing of all of the module’s options, and if the module works for you, please add “works_for_me” in the comments.

“passes_guidelines”: If you have gone through the module guidelines and the module meets all of the requirements, please add “passes_guidelines” in the comments. Guidelines are available here: http://docs.ansible.com/developing_modules.html#module-checklist

“needs_revision”: If the module fails to work for you, or if it doesn’t meet guidelines, please add “needs_revision” in the comments with details about what needs to be fixed.

When a module has both “works_for_me” and “passes_guidelines” tags, we will promote the module for inclusion in Ansible Extras. At this point, you will be expected to maintain the module by fixing bugs and evaluating pull requests in a timely manner.

Thanks again for submitting your Ansible module!

@gregdek
Contributor
gregdek commented Mar 29, 2016

Thanks @bachp for this PR. This PR requires revisions, either because it fails to build or by reviewer request. Please make the suggested revisions. When you are done, please comment with text 'ready_for_review' and we will put this PR back into review.

[This message brought to you by your friendly Ansibull-bot.]

@gregdek
Contributor
gregdek commented Apr 14, 2016

@bachp A friendly reminder: this pull request has been marked as needing your action. If you still believe that this PR applies, and you intend to address the issues with this PR, just let us know in the PR itself and we will keep it open pending your changes. When you do address the issues, please respond with ready_for_review in your comment, so that we can notify the maintainer.

[This message brought to you by your friendly Ansibull-bot.]

@gregdek
Contributor
gregdek commented Apr 29, 2016

@bachp Another friendly reminder: this pull request has been marked as needing your action. If you still believe that this PR applies, and you intend to address the issues with this PR, just let us know in the PR itself and we will keep it open. If you have addressed the issues and believe it's ready for review, please comment with the text "ready_for_review". If we don't hear from you within another 14 days, we will close this pull request.

[This message brought to you by your friendly Ansibull-bot.]

bachp added some commits May 1, 2016
@bachp bachp add module to gather facts from Webfaction
This module allows gather facts about:
- applications
- websites
- databases
- domains
2c1cbad
@bachp bachp add return documentation and update to 2.2 67516ed
@bachp
bachp commented May 1, 2016

ready_for_review

@gregdek
Contributor
gregdek commented May 1, 2016

Thanks @bachp. To the current maintainers, @quentinsf please review according to guidelines (http://docs.ansible.com/ansible/developing_modules.html#module-checklist) and comment with text 'shipit', 'needs_revision' or 'close_me' as appropriate.

[This message brought to you by your friendly Ansibull-bot.]

@gregdek gregdek removed the pending_action label Aug 15, 2016
@ansibot
ansibot commented Dec 7, 2016

This repository has been locked. All new issues and pull requests should be filed in https://github.com/ansible/ansible

Please read through the repomerge page in the dev guide. The guide contains links to tools which automatically move your issue or pull request to the ansible/ansible repo.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment