This module manages ZFS's administrative privileges.
Adding new process. We will be evaluating all new module PRs according to this process, effective immediately.
Thanks for submitting this new module to Ansible Extras! This module is now in community review, a process that is open to all Ansible users. In order for this module to be approved, it must gain the following votes:
“works_for_me”: If you have tested the module thoroughly, including testing of all of the module’s options, and if the module works for you, please add “works_for_me” in the comments.
“passes_guidelines”: If you have gone through the module guidelines and the module meets all of the requirements, please add “passes_guidelines” in the comments. Guidelines are available here: http://docs.ansible.com/developing_modules.html#module-checklist
“needs_revision”: If the module fails to work for you, or if it doesn’t meet guidelines, please add “needs_revision” in the comments with details about what needs to be fixed.
When a module has both “works_for_me” and “passes_guidelines” tags, we will promote the module for inclusion in Ansible Extras. At this point, you will be expected to maintain the module by fixing bugs and evaluating pull requests in a timely manner.
Thanks again for submitting your Ansible module!
Thanks @natefoo for this PR. This PR requires revisions, either because it fails to build or by reviewer request. Please make the suggested revisions. When you are done, please comment with text 'ready_for_review' and we will put this PR back into review.
[This message brought to you by your friendly Ansibull-bot.]
@gregdek It doesn't look like Travis was actually testing my branch, since the failing file (clustering/znode.py) didn't even exist in my branch (since it was created well after this PR). That said, I rebased to trigger a new build and it succeeded (after fixing for the requirements added with the module validation script).
My RETURN doc string is empty, I hope that's appropriate, since this module does not return any actual data (just status, msg, stdout, result).
@natefoo A friendly reminder: this pull request has been marked as needing your action. If you still believe that this PR applies, and you intend to address the issues with this PR, just let us know in the PR itself and we will keep it open pending your changes. When you do address the issues, please respond with ready_for_review in your comment, so that we can notify the maintainer.
Whoops, missed the instructions...
Thanks @natefoo for this new module. When this module receives 'shipit' comments from two community members and any 'needs_revision' comments have been resolved, we will mark for inclusion.
Create a module for managing ZFS admin privileges
Actually support check mode in zfs_permissions
Fix Python 2.4 invalid syntax
Update added_version to 2.1
Remove superflous sys.exit() and add an empty RETURN doc (empty because
the module does not return anything other than status-related stuff)
Update version_added since zfs_permissions was not accepted in 2.1.
I rebased and updated version_added.
This repository has been locked. All new issues and pull requests should be filed in https://github.com/ansible/ansible
Please read through the repomerge page in the dev guide. The guide contains links to tools which automatically move your issue or pull request to the ansible/ansible repo.