add fleet_unit module which manges CoreOS systemd services via Fleet #929

Closed
wants to merge 2 commits into
from

Projects

None yet

6 participants

@coderfi
coderfi commented Sep 7, 2015

This PR obsoletes #91
Also see related PR: #928

@robynbergeron
Contributor

Hi @coderfi --

Thanks for submitting this new module to Ansible Extras! This module is now in community review, a process that is open to all Ansible users. In order for this module to be approved, it must gain the following votes:

“works_for_me”: If you have tested the module thoroughly, including testing of all of the module’s options, and if the module works for you, please add “works_for_me” in the comments.

“passes_guidelines”: If you have gone through the module guidelines and the module meets all of the requirements, please add “passes_guidelines” in the comments. Guidelines are available here: http://docs.ansible.com/developing_modules.html#module-checklist

“needs_revision”: If the module fails to work for you, or if it doesn’t meet guidelines, please add “needs_revision” in the comments with details about what needs to be fixed.

When a module has both “works_for_me” and “passes_guidelines” tags, we will promote the module for inclusion in Ansible Extras. At this point, you will be expected to maintain the module by fixing bugs and evaluating pull requests in a timely manner.

Thanks again for submitting your Ansible module!

@robynbergeron
Contributor

@jeanmertz @jalev @ahjohannessen @veverjak @johnraz @moperacz -- Some of you had feedback for this in the original PR, #91 -- please note that with the new and improved extras PR review process (detailed in the previous comment), your help in reviewing this can help get it in more quickly :)

Also -- hey, @brianredbeard or @kelseyhightower -- do you guys know anyone who might be a good candidate for reviewing this? :) If so, can you nudge them this way? Thanks! :)

@gregdek gregdek removed the core_review label Oct 5, 2015
@gregdek
Contributor
gregdek commented Mar 24, 2016

Thanks @coderfi for this PR. This PR requires revisions, either because it fails to build or by reviewer request. Please make the suggested revisions. When you are done, please comment with text 'ready_for_review' and we will put this PR back into review.

@coderfi
coderfi commented Mar 24, 2016

Will do. I'll try to get back to this as soon as I can.

@gregdek
Contributor
gregdek commented Apr 9, 2016

@coderfi A friendly reminder: this pull request has been marked as needing your action. If you still believe that this PR applies, and you intend to address the issues with this PR, just let us know in the PR itself and we will keep it open pending your changes. When you do address the issues, please respond with ready_for_review in your comment, so that we can notify the maintainer.

[This message brought to you by your friendly Ansibull-bot.]

@coderfi
coderfi commented Apr 9, 2016

Hmm the build seems to be failing due to something outside of the code I touched.

Compiling ./clustering/znode.py ...
  File "./clustering/znode.py", line 123
    command_type = 'op' if 'op' in module.params and module.params['op'] is not None else 'state'

The 'clustering' directory doesn't even exist in the ansible-modules-extras repo.

My branch is thousands of commits behind the upstream. Maybe syncing it up will fix this build failure?

@sivel
Member
sivel commented Apr 9, 2016

Yes, you should rebase against the current state of devel.

@gregdek
Contributor
gregdek commented Apr 24, 2016

@coderfi Another friendly reminder: this pull request has been marked as needing your action. If you still believe that this PR applies, and you intend to address the issues with this PR, just let us know in the PR itself and we will keep it open. If you have addressed the issues and believe it's ready for review, please comment with the text "ready_for_review". If we don't hear from you within another 14 days, we will close this pull request.

[This message brought to you by your friendly Ansibull-bot.]

@coderfi
coderfi commented Apr 24, 2016

Aww man, this rebase is tedious, there's like 4 months of conflicts I need to resolve. I'm probably doing something wrong since all I did was add my one file.
Researching my options and will try to resolve this today.

@coderfi
coderfi commented Apr 24, 2016

Doesn't seem to be anything 'easy' I could do since it's been months since I forked the repo. Any rebase I try is met with numerous conflicts.
Unless some GIT Ninja can recommend otherwise, I'll just fork the latest devel and submit a new pull request on that.

@gregdek
Contributor
gregdek commented May 10, 2016

@coderfi A friendly reminder: this pull request has been marked as needing your action. If you still believe that this PR applies, and you intend to address the issues with this PR, just let us know in the PR itself and we will keep it open pending your changes. When you do address the issues, please respond with ready_for_review in your comment, so that we can notify the maintainer.

[This message brought to you by your friendly Ansibull-bot.]

@gregdek
Contributor
gregdek commented May 25, 2016

@coderfi Another friendly reminder: this pull request has been marked as needing your action. If you still believe that this PR applies, and you intend to address the issues with this PR, just let us know in the PR itself and we will keep it open. If you have addressed the issues and believe it's ready for review, please comment with the text "ready_for_review". If we don't hear from you within another 14 days, we will close this pull request.

[This message brought to you by your friendly Ansibull-bot.]

@coderfi coderfi closed this May 30, 2016
@coderfi coderfi deleted the coderfi:fleet_unit branch May 30, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment