Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[containerization] Ensure volume mounts are unique directories with trailing slash #728

Merged
merged 2 commits into from
Jun 17, 2021

Conversation

cidrblock
Copy link
Contributor

@cidrblock cidrblock commented Jun 14, 2021

Fixes #727
Fixes ansible/ansible-navigator#471

  • Clear up logic, ensure src and dest are always directories with a trailing slash
  • Ensure abs, expand user and vars for each
  • Remove unused func for trailing slash adding as it is within the only func using it
  • Add sufficient unit test to cover all scenarios
  • 1 var rename for consistency with src
  • Fix safe path mount to cover with and without trailing slash
  • change log file to unique to avoid suspected race condition

.gitignore Outdated Show resolved Hide resolved
test/unit/config/test__base.py Outdated Show resolved Hide resolved
@cidrblock cidrblock force-pushed the dupe_volume_mount branch 3 times, most recently from 1b7efd4 to 4380e11 Compare June 15, 2021 20:16
@cidrblock
Copy link
Contributor Author

recheck

@cidrblock cidrblock changed the title [containerization] Ensure volume mounts are directories with trailing slash [containerization] Ensure volume mounts are unique directories with trailing slash Jun 15, 2021
@cidrblock cidrblock force-pushed the dupe_volume_mount branch 5 times, most recently from 93e34de to 02f0514 Compare June 16, 2021 13:11
@cidrblock cidrblock changed the title [containerization] Ensure volume mounts are unique directories with trailing slash [dnm] Ensure volume mounts are unique directories with trailing slash Jun 16, 2021
@cidrblock cidrblock changed the title [dnm] Ensure volume mounts are unique directories with trailing slash [containerization] Ensure volume mounts are unique directories with trailing slash Jun 16, 2021
@cidrblock
Copy link
Contributor Author

recheck

@cidrblock cidrblock requested a review from matburt June 16, 2021 14:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants