From 2ca57191689a12c3b28fa7b94bae72d1c97851f9 Mon Sep 17 00:00:00 2001 From: Barry Peddycord III Date: Sat, 25 Feb 2017 03:01:04 -0500 Subject: [PATCH] Deprecating old cumulus modules (#21726) * deprecating old nclu modules * adding deprecated cl_ moduels to changelog * renaming deprecated modules --- CHANGELOG.md | 7 +++++++ .../modules/network/cumulus/{cl_bond.py => _cl_bond.py} | 3 ++- .../network/cumulus/{cl_bridge.py => _cl_bridge.py} | 3 ++- .../cumulus/{cl_img_install.py => _cl_img_install.py} | 3 ++- .../network/cumulus/{cl_interface.py => _cl_interface.py} | 3 ++- .../{cl_interface_policy.py => _cl_interface_policy.py} | 3 ++- .../network/cumulus/{cl_license.py => _cl_license.py} | 3 ++- .../modules/network/cumulus/{cl_ports.py => _cl_ports.py} | 3 ++- 8 files changed, 21 insertions(+), 7 deletions(-) rename lib/ansible/modules/network/cumulus/{cl_bond.py => _cl_bond.py} (99%) rename lib/ansible/modules/network/cumulus/{cl_bridge.py => _cl_bridge.py} (99%) rename lib/ansible/modules/network/cumulus/{cl_img_install.py => _cl_img_install.py} (98%) rename lib/ansible/modules/network/cumulus/{cl_interface.py => _cl_interface.py} (99%) rename lib/ansible/modules/network/cumulus/{cl_interface_policy.py => _cl_interface_policy.py} (98%) rename lib/ansible/modules/network/cumulus/{cl_license.py => _cl_license.py} (98%) rename lib/ansible/modules/network/cumulus/{cl_ports.py => _cl_ports.py} (98%) diff --git a/CHANGELOG.md b/CHANGELOG.md index c234b48b93bcb7..710d525472df3f 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -43,6 +43,13 @@ Ansible Changes By Release options will be merged with no way to go back to the old behaviour. * Modules * ec2_vpc will be deprecated in 2.3 and removed in 2.5 + * cl_bond will be deprecated in 2.3 and removed in 2.5 + * cl_bridge will be deprecated in 2.3 and removed in 2.5 + * cl_img_install will be deprecated in 2.3 and removed in 2.5 + * cl_interface will be deprecated in 2.3 and removed in 2.5 + * cl_interface_policy will be deprecated in 2.3 and removed in 2.5 + * cl_license will be deprecated in 2.3 and removed in 2.5 + * cl_ports will be deprecated in 2.3 and removed in 2.5 ###Modules Notes: - oVirt/RHV diff --git a/lib/ansible/modules/network/cumulus/cl_bond.py b/lib/ansible/modules/network/cumulus/_cl_bond.py similarity index 99% rename from lib/ansible/modules/network/cumulus/cl_bond.py rename to lib/ansible/modules/network/cumulus/_cl_bond.py index a27be0eabf9d2f..63150600b00dfe 100644 --- a/lib/ansible/modules/network/cumulus/cl_bond.py +++ b/lib/ansible/modules/network/cumulus/_cl_bond.py @@ -15,7 +15,7 @@ # You should have received a copy of the GNU General Public License # along with Ansible. If not, see . -ANSIBLE_METADATA = {'status': ['preview'], +ANSIBLE_METADATA = {'status': ['deprecated'], 'supported_by': 'community', 'version': '1.0'} @@ -25,6 +25,7 @@ version_added: "2.1" author: "Cumulus Networks (@CumulusNetworks)" short_description: Configures a bond port on Cumulus Linux +deprecated: Deprecated in 2.3. Use M(nclu) instead. description: - Configures a bond interface on Cumulus Linux To configure a bridge port use the cl_bridge module. To configure any other type of interface use the diff --git a/lib/ansible/modules/network/cumulus/cl_bridge.py b/lib/ansible/modules/network/cumulus/_cl_bridge.py similarity index 99% rename from lib/ansible/modules/network/cumulus/cl_bridge.py rename to lib/ansible/modules/network/cumulus/_cl_bridge.py index 0b635fb10f5451..a5d03bb5e50bed 100644 --- a/lib/ansible/modules/network/cumulus/cl_bridge.py +++ b/lib/ansible/modules/network/cumulus/_cl_bridge.py @@ -15,7 +15,7 @@ # You should have received a copy of the GNU General Public License # along with Ansible. If not, see . -ANSIBLE_METADATA = {'status': ['preview'], +ANSIBLE_METADATA = {'status': ['deprecated'], 'supported_by': 'community', 'version': '1.0'} @@ -25,6 +25,7 @@ version_added: "2.1" author: "Cumulus Networks (@CumulusNetworks)" short_description: Configures a bridge port on Cumulus Linux +deprecated: Deprecated in 2.3. Use M(nclu) instead. description: - Configures a bridge interface on Cumulus Linux To configure a bond port use the cl_bond module. To configure any other type of interface use the diff --git a/lib/ansible/modules/network/cumulus/cl_img_install.py b/lib/ansible/modules/network/cumulus/_cl_img_install.py similarity index 98% rename from lib/ansible/modules/network/cumulus/cl_img_install.py rename to lib/ansible/modules/network/cumulus/_cl_img_install.py index 6daaaa248cc2af..5374d8e00cf056 100644 --- a/lib/ansible/modules/network/cumulus/cl_img_install.py +++ b/lib/ansible/modules/network/cumulus/_cl_img_install.py @@ -15,7 +15,7 @@ # You should have received a copy of the GNU General Public License # along with Ansible. If not, see . -ANSIBLE_METADATA = {'status': ['preview'], +ANSIBLE_METADATA = {'status': ['deprecated'], 'supported_by': 'community', 'version': '1.0'} @@ -25,6 +25,7 @@ version_added: "2.1" author: "Cumulus Networks (@CumulusLinux)" short_description: Install a different Cumulus Linux version. +deprecated: Deprecated in 2.3. The image slot system no longer exists in Cumulus Linux. description: - install a different version of Cumulus Linux in the inactive slot. For more details go the Image Management User Guide at diff --git a/lib/ansible/modules/network/cumulus/cl_interface.py b/lib/ansible/modules/network/cumulus/_cl_interface.py similarity index 99% rename from lib/ansible/modules/network/cumulus/cl_interface.py rename to lib/ansible/modules/network/cumulus/_cl_interface.py index fcacd9bbeef63c..3223900ce68ffb 100644 --- a/lib/ansible/modules/network/cumulus/cl_interface.py +++ b/lib/ansible/modules/network/cumulus/_cl_interface.py @@ -15,7 +15,7 @@ # You should have received a copy of the GNU General Public License # along with Ansible. If not, see . -ANSIBLE_METADATA = {'status': ['preview'], +ANSIBLE_METADATA = {'status': ['deprecated'], 'supported_by': 'community', 'version': '1.0'} @@ -26,6 +26,7 @@ author: "Cumulus Networks (@CumulusNetworks)" short_description: Configures a front panel port, loopback or management port on Cumulus Linux. +deprecated: Deprecated in 2.3. Use M(nclu) instead. description: - Configures a front panel, sub-interface, SVI, management or loopback port on a Cumulus Linux switch. For bridge ports use the cl_bridge module. For diff --git a/lib/ansible/modules/network/cumulus/cl_interface_policy.py b/lib/ansible/modules/network/cumulus/_cl_interface_policy.py similarity index 98% rename from lib/ansible/modules/network/cumulus/cl_interface_policy.py rename to lib/ansible/modules/network/cumulus/_cl_interface_policy.py index 2c4211e4436a6e..e8bc3dfd33189d 100644 --- a/lib/ansible/modules/network/cumulus/cl_interface_policy.py +++ b/lib/ansible/modules/network/cumulus/_cl_interface_policy.py @@ -15,7 +15,7 @@ # You should have received a copy of the GNU General Public License # along with Ansible. If not, see . -ANSIBLE_METADATA = {'status': ['preview'], +ANSIBLE_METADATA = {'status': ['deprecated'], 'supported_by': 'community', 'version': '1.0'} @@ -25,6 +25,7 @@ version_added: "2.1" author: "Cumulus Networks (@CumulusNetworks)" short_description: Configure interface enforcement policy on Cumulus Linux +deprecated: Deprecated in 2.3. Use M(nclu) instead. description: - This module affects the configuration files located in the interfaces folder defined by ifupdown2. Interfaces port and port ranges listed in the diff --git a/lib/ansible/modules/network/cumulus/cl_license.py b/lib/ansible/modules/network/cumulus/_cl_license.py similarity index 98% rename from lib/ansible/modules/network/cumulus/cl_license.py rename to lib/ansible/modules/network/cumulus/_cl_license.py index fbad6a156219f2..d440ebb4edaeee 100644 --- a/lib/ansible/modules/network/cumulus/cl_license.py +++ b/lib/ansible/modules/network/cumulus/_cl_license.py @@ -15,7 +15,7 @@ # You should have received a copy of the GNU General Public License # along with Ansible. If not, see . -ANSIBLE_METADATA = {'status': ['preview'], +ANSIBLE_METADATA = {'status': ['deprecated'], 'supported_by': 'community', 'version': '1.0'} @@ -25,6 +25,7 @@ version_added: "2.1" author: "Cumulus Networks (@CumulusNetworks)" short_description: Install Cumulus Linux license +deprecated: Deprecated in 2.3. description: - Installs a Cumulus Linux license. The module reports no change of status when a license is installed. diff --git a/lib/ansible/modules/network/cumulus/cl_ports.py b/lib/ansible/modules/network/cumulus/_cl_ports.py similarity index 98% rename from lib/ansible/modules/network/cumulus/cl_ports.py rename to lib/ansible/modules/network/cumulus/_cl_ports.py index 3bcbcc13e52331..c865408d2d9186 100644 --- a/lib/ansible/modules/network/cumulus/cl_ports.py +++ b/lib/ansible/modules/network/cumulus/_cl_ports.py @@ -15,7 +15,7 @@ # You should have received a copy of the GNU General Public License # along with Ansible. If not, see . -ANSIBLE_METADATA = {'status': ['preview'], +ANSIBLE_METADATA = {'status': ['deprecated'], 'supported_by': 'community', 'version': '1.0'} @@ -25,6 +25,7 @@ version_added: "2.1" author: "Cumulus Networks (@CumulusNetworks)" short_description: Configure Cumulus Switch port attributes (ports.conf) +deprecated: Deprecated in 2.3. Use M(nclu) instead. description: - Set the initial port attribute defined in the Cumulus Linux ports.conf, file. This module does not do any error checking at the moment. Be careful