Skip to content

Commit

Permalink
acme_certificate: make compatible to Buypass' ACME v2 testing endpoint (
Browse files Browse the repository at this point in the history
#60727)

* Don't unnecessarily use location from header.

* Add changelog.

(cherry picked from commit 7f4f250)
  • Loading branch information
felixfontein authored and abadger committed Sep 4, 2019
1 parent 9218856 commit ccd0b5b
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
@@ -0,0 +1,2 @@
bugfixes:
- "acme_certificate - improve compatibility when finalizing ACME v2 orders. Fixes problem with Buypass' ACME v2 testing endpoint."
4 changes: 1 addition & 3 deletions lib/ansible/modules/crypto/acme/acme_certificate.py
Expand Up @@ -637,12 +637,10 @@ def _finalize_cert(self):
if info['status'] not in [200]:
raise ModuleFailException("Error new cert: CODE: {0} RESULT: {1}".format(info['status'], result))

order = info['location']

status = result['status']
while status not in ['valid', 'invalid']:
time.sleep(2)
result, dummy = self.account.get_request(order)
result, dummy = self.account.get_request(self.order_uri)
status = result['status']

if status != 'valid':
Expand Down

0 comments on commit ccd0b5b

Please sign in to comment.