ansible subversion module silently fails on network problems

[ansibot]

From @Petrox on 2016-04-11T20:00:01Z

ISSUE TYPE

• Bug Report

COMPONENT NAME

subversion

ANSIBLE VERSION

ansible 2.0.1.0
  config file = /etc/ansible/ansible.cfg
  configured module search path = Default w/o overrides

CONFIGURATION

nothing special

OS / ENVIRONMENT

ubuntu 14.04.4 trusty fully upgraded

SUMMARY

sometimes - because of network errors - subversion can't finish the checkout, but this should raise an error, ansible though moves on believing evertyhing is okay

I could also say, that if I do an "svn update" after a successful ansible checkout zero changes should happen (if the server side did not change of course).

STEPS TO REPRODUCE

create or find a large svn repo
checkout with subversion module
stop your network interface while downloading

EXPECTED RESULTS

ansible should exit with an error

ACTUAL RESULTS

ansible moves on like if checkout was a success

Copied from original issue: ansible/ansible-modules-core#3405

[ansibot]

From @ansibot on 2016-04-11T20:00:01Z

@dsummersl ping, this issue is waiting for your response.
click here for bot help

[s-hertel]

This seems like a problem with svn hanging/not handling errors properly. The subversion module checks the return code after checking out the repo, so the module should fail if svn is accurately reporting failures.

[Petrox]

Thank you for your quick response. My process is still hanging since 2016. Should I press ctrl-c now? Suggestion: A timeout and retry feature might help avoid situations when the operating system and the source code repository reaches end-of-life before ansible finishes the playbook.

…

On Fri, Jun 4, 2021, 17:28 Sloane Hertel ***@***.***> wrote: This seems like a problem with svn hanging/not handling errors properly. The subversion module checks the return code after checking out the repo, so the module should fail if svn is accurately reporting failures. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#29824 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAXFKXPJURIMFXMGSTO7R4DTRDWJ7ANCNFSM4D2P4EIQ> .

[bcoca]

2.11 has a timeout keyword for the task, no matter what the action is.

Suibversion itself does have a built int timeout now (defaults to 1h iirc).