New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

azure_rm_networkinterface should have support to enable accelerated networking for network interface. #41218

Closed
tsukashusan opened this Issue Jun 6, 2018 · 6 comments

Comments

Projects
None yet
4 participants
@tsukashusan

tsukashusan commented Jun 6, 2018

SUMMARY

Current module does not have support for following features while a NetworkInterface gets created.

NetworkInterface
Accelerated networking flag to enable/disable SR-IOV based networking.

New APIs supporting these features are available in Azure Python SDK.
(e.g. https://docs.microsoft.com/ja-jp/python/api/azure.mgmt.network.v2018_02_01.models.networkinterface?view=azure-python)

NetworkInterface(*, id: str = None, location: str = None, tags=None, virtual_machine=None, network_security_group=None, ip_configurations=None, dns_settings=None, mac_address: str = None, primary: bool = None, enable_accelerated_networking: bool = None, enable_ip_forwarding: bool = None, resource_guid: str = None, provisioning_state: str = None, etag: str = None, **kwargs) -> None

There is already a similar issue.
#34032

ISSUE TYPE
  • Feature Idea
COMPONENT NAME

azure_rm_networkinterface

ANSIBLE VERSION
$ ansible --version
ansible 2.5.4
  config file = None
  configured module search path = ['/home/ubuntu/.ansible/plugins/modules', '/usr/share/ansible/plugins/modules']
  ansible python module location = /usr/local/lib/python3.6/dist-packages/ansible
  executable location = /usr/local/bin/ansible
  python version = 3.6.5 (default, Apr  1 2018, 05:46:30) [GCC 7.3.0]
OS / ENVIRONMENT

Red Hat Enterprise Linux Server release 7.5 (Maipo)

STEPS TO REPRODUCE
- name: Create a network interface with private IP address only (no Public IP)
  azure_rm_networkinterface:
    name: nic001
    resource_group: Testing
    virtual_network_name: vnet001
    subnet_name: subnet001
    enable_accelerated_networking: True
@ansibot

This comment has been minimized.

Contributor

ansibot commented Jun 6, 2018

Files identified in the description:

If these files are inaccurate, please update the component name section of the description or use the !component bot command.

click here for bot help

@ansibot

This comment has been minimized.

@yuwzho

This comment has been minimized.

Contributor

yuwzho commented Jun 7, 2018

+label easyfix

add an easyfix label to attract contributor who is interested in this field. Add a new field need to do the following things:

  • Update document at the beginning of the module python file. Including a version_added: 2.7 line
  • Add this to spec in init()
  • Handle new created case in exec_module()
  • Handle update case in exec_module()
  • Add test to test create with check_mode/action/idempotent

@ansibot ansibot added easyfix and removed needs_triage labels Jun 7, 2018

@zwindler

This comment has been minimized.

Contributor

zwindler commented Jun 14, 2018

Hi,

I see there is the easyfix tag & I'm interested by this feature. I'd like to try to do it, if that's OK

@yuwzho

This comment has been minimized.

Contributor

yuwzho commented Jun 15, 2018

@zwindler Welcome your contribution! If you have any problem, please pin me or @zikalino 😄

@zwindler

This comment has been minimized.

Contributor

zwindler commented Jun 29, 2018

@yuwzho @zikalino

I've got a first version working. Let me know if there are some modifications needed (code or tests).

alikins added a commit that referenced this issue Aug 8, 2018

Merge branch 'devel' into mazer_role_loader
* devel: (50 commits)
  Add new module for Redfish APIs (#41656)
  VMware Module - vmware_guest_move (#42149)
  Lenovo port to persistence 1 (#43194)
  VMware: new module: vmware_guest_boot_manager (#40609)
  fixes #42042 (#42939)
  VMware: new module: vmware_category_facts (#39894)
  VMware: Dynamic Inventory plugin (#37456)
  Validate and reject if csr_path is not supplied when provider is not assertonly (#41385)
  VMware: new module : vmware_guest_custom_attributes (#38114)
  VMware: new module: vmware_guest_attribute_defs (#38144)
  VMware: Fix mark as virtual machine method (#40521)
  Ironware: Deprecate provider, support network_cli (#43285)
  feat: Add a enable_accelerated_networking flag in module + tests; fixes #41218  (#42109)
  fixing aiuth source (#42923)
  VMware: handle special characters in datacenter name (#42922)
  VMware: update examples in vmware_vm_shell (#42410)
  VMWare: refactor vmware_vm_shell module (#39957)
  VMware: additional VSAN facts about Hostsystem (#40456)
  nxos cliconf plugin refactor (#43203)
  Correcting conditionals looping (#43331)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment