Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

azure_rm_managed_disk should support caching options #51387

Closed
nomadcz opened this issue Jan 28, 2019 · 14 comments

Comments

Projects
None yet
7 participants
@nomadcz
Copy link

commented Jan 28, 2019

SUMMARY

azure_rm_managed_disk should support caching options

ISSUE TYPE

As azure_rm_managed_disk allows creating/attaching/detaching managed disks to VM it should support caching options similar to "az vm disk attach --vm-name [--caching {None, ReadOnly, ReadWrite}] ..."

COMPONENT NAME

azure_rm_managed_disk

ADDITIONAL INFORMATION

While azure_rm_virtualmachine allows specify caching option for data disk we usullay create just VM (OS only) and add data disks later so it would be helpfull if azure_rm_managed_disk supported caching option as well.

@ansibot

This comment has been minimized.

Copy link
Contributor

commented Jan 28, 2019

Files identified in the description:

If these files are inaccurate, please update the component name section of the description or use the !component bot command.

click here for bot help

@ansibot

This comment has been minimized.

Copy link
Contributor

commented Jan 28, 2019

@nomadcz: Greetings! Thanks for taking the time to open this issue. In order for the community to handle your issue effectively, we need a bit more information.

Here are the items we could not find in your description:

  • ansible version

Please set the description of this issue with this template:
https://raw.githubusercontent.com/ansible/ansible/devel/.github/ISSUE_TEMPLATE.md

click here for bot help

@ansibot

This comment has been minimized.

@ansibot

This comment has been minimized.

Copy link
Contributor

commented Jan 28, 2019

@nomadcz, just so you are aware we have a dedicated Working Group for azure.
You can find other people interested in this in #ansible-azure on Freenode IRC
For more information about communities, meetings and agendas see https://github.com/ansible/community

click here for bot help

@Fred-sun

This comment has been minimized.

Copy link
Contributor

commented Jan 29, 2019

@nomadcz Thanks for your reporting this issue! It's new feature for azure_rm_managed_disk module. Thanks!

@Fred-sun

This comment has been minimized.

Copy link
Contributor

commented Jan 29, 2019

@zikalino Could you help take a look this issue when you're available? azure_rm_managed_disk missing caching feature when created VM attach disk. Thanks!

@ansibot

This comment has been minimized.

Copy link
Contributor

commented Feb 14, 2019

Files identified in the description:

If these files are inaccurate, please update the component name section of the description or use the !component bot command.

click here for bot help

@ansibot ansibot removed the support:core label Feb 14, 2019

@Fred-sun

This comment has been minimized.

Copy link
Contributor

commented Feb 19, 2019

@yungezz yungezz added the feature label Feb 27, 2019

@Fred-sun

This comment has been minimized.

Copy link
Contributor

commented Mar 5, 2019

@yuwzho

This comment has been minimized.

Copy link
Contributor

commented Mar 6, 2019

+label easyfix

@ansibot ansibot added the easyfix label Mar 6, 2019

@Fred-sun

This comment has been minimized.

Copy link
Contributor

commented Mar 22, 2019

@yuwzho Could you help give a fixes when you're available? Thanks!

@Fred-sun

This comment has been minimized.

Copy link
Contributor

commented Apr 3, 2019

@MyronFanQiu Could you can give a PR to add the caching options? Thanks!

@MyronFanQiu

This comment has been minimized.

Copy link
Contributor

commented Apr 3, 2019

@MyronFanQiu Could you can give a PR to add the caching options? Thanks!

@Fred-sun No problem. I'm working on it now. @zikalino and @yuwzho are helping me to review the code.

@Fred-sun

This comment has been minimized.

Copy link
Contributor

commented Apr 3, 2019

Thanks for your contribution!

MyronFanQiu added a commit to VSChina/ansible that referenced this issue Apr 4, 2019

support caching options (ansible#51387)
* add related information into the documentation and examples

* add variables and options in the init

* add caching params when creating DataDisk

zikalino added a commit that referenced this issue Apr 8, 2019

bobdoah added a commit to bobdoah/ansible that referenced this issue May 28, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.