Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle specified license_model parameter for (at least) Postgresql #53407

Open
jonassteinberg1 opened this Issue Mar 6, 2019 · 3 comments

Comments

Projects
None yet
4 participants
@jonassteinberg1
Copy link

jonassteinberg1 commented Mar 6, 2019

SUMMARY

When license_model: postgresql-license param is specified for engine: postgres, which, at least via the aws console build process is the only allowable value, stderr throws:

"msg": "value of license_model must be one of: license-included, bring-your-own-license, general-public-license, got: postgresql-license"

However, when 'general-public-license' license is then used, stderr throws:

"msg": "Unable to create DB instance: An error occurred (InvalidParameterCombination) when calling the CreateDBInstance operation: Invalid license model 'general-public-license' for engine 'postgres'. Valid license models are: postgresql-license"
ISSUE TYPE
  • Bug Report
COMPONENT NAME

modules --> cloud --> amazon --> rds_instance

ANSIBLE VERSION
ansible 2.7.6
  config file = /Users/######/development/personal/git/ansible/ansible.cfg
  configured module search path = ['/Users/######/.ansible/plugins/modules', '/usr/share/ansible/plugins/modules']
  ansible python module location = /usr/local/Cellar/ansible/2.7.6/libexec/lib/python3.7/site-packages/ansible
  executable location = /usr/local/bin/ansible
  python version = 3.7.2 (default, Jan 13 2019, 12:50:15) [Clang 10.0.0 (clang-1000.11.45.5)]
CONFIGURATION
DEFAULT_HOST_LIST(/Users/############/development/personal/git/ansible/ansible.cfg) = ['/Users/#######/development/personal/git/ansible/hosts']
DEFAULT_LOG_PATH(/Users/#############/development/personal/git/ansible/ansible.cfg) = /var/log/ansible.log
DEFAULT_PRIVATE_KEY_FILE(/Users/##########/development/personal/git/ansible/ansible.cfg) = /Users/################/.ssh/#############
DEFAULT_REMOTE_USER(/Users/#######/development/personal/git/ansible/ansible.cfg) = #####
DEFAULT_ROLES_PATH(/Users/#######/development/personal/git/ansible/ansible.cfg) = ['/Users/##########/development/personal/git/ansible/roles']
OS / ENVIRONMENT

Darwin ######-Mac1 17.7.0 Darwin Kernel Version 17.7.0: Thu Dec 20 21:47:19 PST 2018; root:xnu-4570.71.22~1/RELEASE_X86_64 x86_64

STEPS TO REPRODUCE

toggle license values between postgresql-license and general-public-license

fatal: [localhost]: FAILED! => {
    "changed": false,
    "invocation": {
        "module_args": {
            "allocated_storage": 20,
            "allow_major_version_upgrade": false,
            "apply_immediately": false,
            "auto_minor_version_upgrade": false,
            "aws_access_key": "#########",
            "aws_secret_key": "VALUE_SPECIFIED_IN_NO_LOG_PARAMETER",
            "backup_retention_period": 0,
            "db_instance_class": "db.t2.small",
            "db_instance_identifier": "ansible-rds-postgres-10-6-non-HA-encrypted-test-instance-1",
            "db_name": "ansible_rds_postgres_10_6_non_HA_encrypted_test_instance_1",
            "db_subnet_group_name": "#########################",
            "enable_performance_insights": false,
            "engine": "postgres",
            "engine_version": "10.6",
            "force_update_password": false,
            "license_model": "postgresql-license",
            "master_user_password": "VALUE_SPECIFIED_IN_NO_LOG_PARAMETER",
            "master_username": "################",
            "new_db_instance_identifier": null,
            "port": 5432,
            "preferred_backup_window": "00:00-00:30",
            "preferred_maintenance_window": "sun:00:30-sun:01:00",
            "publicly_accessible": true,
            "purge_cloudwatch_logs_exports": true,
            "purge_tags": true,
            "skip_final_snapshot": false,
            "state": "present",
            "storage_encrypted": true,
            "storage_type": "gp2",
            "tags": {
                "db_name": "ansible_rds_postgres_10_6_non_HA_encrypted_test_instance_1"
            },
            "validate_certs": true,
            "vpc_security_group_ids": [
                "################"
            ],
            "wait": true
        }
    },
    "msg": "value of license_model must be one of: license-included, bring-your-own-license, general-public-license, got: postgresql-license"
}
EXPECTED RESULTS

Instance built

ACTUAL RESULTS
"msg": "value of license_model must be one of: license-included, bring-your-own-license, general-public-license, got: postgresql-license"

or if you then switch to license_model: general-public-license:

"msg": "Unable to create DB instance: An error occurred (InvalidParameterCombination) when calling the CreateDBInstance operation: Invalid license model 'general-public-license' for engine 'postgres'. Valid license models are: postgresql-license"

@jonassteinberg1 jonassteinberg1 added the bug label Mar 6, 2019

@s-hertel s-hertel referenced a pull request that will close this issue Mar 6, 2019

Open

[rds_instance] don't hardcode license_model choices #53409

@ansibot

This comment has been minimized.

Copy link
Contributor

ansibot commented Mar 6, 2019

Files identified in the description:

If these files are inaccurate, please update the component name section of the description or use the !component bot command.

click here for bot help

@ansibot

This comment has been minimized.

Copy link
Contributor

ansibot commented Mar 6, 2019

@ansibot

This comment has been minimized.

Copy link
Contributor

ansibot commented Mar 6, 2019

@jonassteinberg1, just so you are aware we have a dedicated Working Group for aws.
You can find other people interested in this in #ansible-aws on Freenode IRC
For more information about communities, meetings and agendas see https://github.com/ansible/community

click here for bot help

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.