please add ipa 'domain resolution order' option to the ipa_config module

[RobVerduijn]

SUMMARY

please add the option to set the ipa 'domain resolution order' to ipa_config

ISSUE TYPE

• Feature Idea
  The current ipa_config module does not have an option to set the domain resolution order in the ipa global config.

Please add this option to the ipa_config module

COMPONENT NAME

ipa_config

ADDITIONAL INFORMATION

This patch should do the trick

--- a/lib/ansible/modules/identity/ipa/ipa_config.py
+++ b/lib/ansible/modules/identity/ipa/ipa_config.py
@@ -25,6 +25,8 @@ options:
   ipadefaultemaildomain:
     description: Default e-mail domain for new users.
     aliases: ["emaildomain"]
+  ipadomainresolutionorder:
+    description: colon-separated list of domains used for short name qualification
 extends_documentation_fragment: ipa.documentation
 version_added: "2.7"
 '''
@@ -70,12 +72,15 @@ class ConfigIPAClient(IPAClient):
         return self._post_json(method='config_mod', name=name, item=item)
 
 
-def get_config_dict(ipadefaultloginshell=None, ipadefaultemaildomain=None):
+def get_config_dict(ipadefaultloginshell=None, ipadefaultemaildomain=None, ipadomainresolutionorder=None):
     config = {}
     if ipadefaultloginshell is not None:
         config['ipadefaultloginshell'] = ipadefaultloginshell
     if ipadefaultemaildomain is not None:
         config['ipadefaultemaildomain'] = ipadefaultemaildomain
+    if ipadomainresolutionorder is not None:
+        config['ipadomainresolutionorder'] = ipadomainresolutionorder
+
 
     return config
 
@@ -88,6 +93,7 @@ def ensure(module, client):
     module_config = get_config_dict(
         ipadefaultloginshell=module.params.get('ipadefaultloginshell'),
         ipadefaultemaildomain=module.params.get('ipadefaultemaildomain'),
+        ipadomainresolutionorder=module.params.get('ipadomainresolutionorder'),
     )
     ipa_config = client.config_show()
     diff = get_config_diff(client, ipa_config, module_config)
@@ -110,6 +116,7 @@ def main():
     argument_spec.update(
         ipadefaultloginshell=dict(type='str', aliases=['loginshell']),
         ipadefaultemaildomain=dict(type='str', aliases=['emaildomain']),
+        ipadomainresolutionorder=dict(type='str'),
     )
 
     module = AnsibleModule(

[ansibot]

Files identified in the description:

• lib/ansible/modules/identity/ipa/ipa_config.py

If these files are inaccurate, please update the component name section of the description or use the !component bot command.

click here for bot help

[ansibot]

cc @Akasurde @Nosmoht @fxfitz
click here for bot help

[Akasurde]

@RobVerduijn Thanks for reporting this feature. Would you be interested in raising a PR with your findings ? Thanks.

[RobVerduijn]

Hi,
Sure no problem, but I don't know where to start.

this page is not helping:
https://docs.ansible.com/ansible/latest/community/development_process.html

It asumes you got the privilege to commit to ansible branches.
I don't have that.

Is there a page where they describe how to do this if you are not a recognised ansible developer ?

Rob

[Akasurde]

@RobVerduijn You don't need privileges to commit to Ansible branch. First fork Ansible project in your account and then create a feature branch and the commit to that branch. After your changes are tested, you can create pull request with this feature.

Let me know if you need any help for this.

Thanks.

[RobVerduijn]

Hi,
I forked the project and branched it.
https://github.com/RobVerduijn/ansible/tree/add_ipadomainresolutionorder
The commit containing the patch:
0ebf77f

How do I get it tested ?
Is there a bot somewhere that I need to trigger ?

Creating a pull request is not a problem, I guess against the devel branch.
Rob

[jctanner]

@RobVerduijn please create the pr from your new branch by following https://help.github.com/en/articles/creating-a-pull-request

Once the pr is created, the automated tests will run against it and report the results.

[RobVerduijn]

The pr has been created quite some time ago, did I forget something or is over 7 weeks a normal time for a response ?

Rob

[ansibot]

Thank you very much for your interest in Ansible. Ansible has migrated much of the content into separate repositories to allow for more rapid, independent development. We are closing this issue/PR because this content has been moved to one or more collection repositories.

• lib/ansible/modules/identity/ipa/ipa_config.py -> https://galaxy.ansible.com/community/general

For further information, please see:
https://github.com/ansible/ansibullbot/blob/master/docs/collection_migration.md