Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AWS dropping support for v1 URIs #56124

Closed
jillr opened this issue May 6, 2019 · 12 comments · Fixed by #73883
Closed

AWS dropping support for v1 URIs #56124

jillr opened this issue May 6, 2019 · 12 comments · Fixed by #73883
Labels
affects_2.9 This issue/PR affects Ansible v2.9 bug This issue/PR relates to a bug. collection:ansible.windows collection Related to Ansible Collections work has_pr This issue has an associated PR. module This issue/PR relates to a module. packaging Packaging category support:community This issue/PR relates to code supported by the Ansible community. support:core This issue/PR relates to code supported by the Ansible Engineering Team. system System category windows Windows community

Comments

@jillr
Copy link
Contributor

jillr commented May 6, 2019

SUMMARY

https://forums.aws.amazon.com/ann.jspa?annID=6776

AWS will be dropping support for s3.amazonaws.com/<bucketname>/key style URIs on September 30th, 2020. All S3 references will need to be changed to <bucketname>.s3.amazonaws.com/key.

ISSUE TYPE
  • Bug Report
COMPONENT NAME

!component =test/integration/targets/dnf/tasks/dnf.yml
!component =test/integration/targets/dnf/tasks/dnf.yml
!component =test/integration/targets/dnf/tasks/dnf.yml
!component =test/integration/targets/win_module_utils/tasks/main.yml
!component =test/integration/targets/win_psexec/tasks/main.yml
!component =test/integration/targets/win_get_url/tasks/main.yml
!component =test/integration/targets/win_get_url/tasks/tests_url.yml
!component =test/integration/targets/win_get_url/tasks/tests_url.yml
!component =test/integration/targets/win_get_url/tasks/tests_url.yml
!component =test/integration/targets/win_package/defaults/main.yml
!component =test/integration/targets/win_package/defaults/main.yml
!component =test/integration/targets/win_package/defaults/main.yml
!component =test/integration/targets/win_package/defaults/main.yml
!component =test/integration/targets/setup_win_psget/tasks/main.yml
!component =test/integration/targets/setup_win_psget/tasks/main.yml
!component =test/integration/targets/setup_win_psget/tasks/main.yml
!component =test/integration/targets/setup_win_psget/tasks/main.yml
!component =test/integration/targets/setup_rabbitmq/tasks/ubuntu.yml
!component =test/integration/targets/setup_rabbitmq/tasks/ubuntu.yml
!component =test/integration/targets/win_command/tasks/main.yml
!component =test/integration/targets/win_psmodule/tasks/setup.yml
!component =test/integration/targets/setup_epel/tasks/main.yml
!component =test/integration/targets/dpkg_selections/tasks/dpkg_selections.yaml
!component =test/integration/targets/win_service/defaults/main.yml
!component =test/integration/targets/win_hotfix/defaults/main.yml
!component =test/integration/targets/win_hotfix/defaults/main.yml
!component =test/integration/targets/win_hotfix/defaults/main.yml
!component =test/integration/targets/yum/tasks/yum.yml
!component =test/integration/targets/yum/tasks/yum.yml
!component =test/integration/targets/yum/tasks/yum.yml
!component =test/integration/targets/yum/tasks/yum.yml
!component =test/integration/targets/yum/tasks/proxy.yml
!component =test/integration/targets/yum/tasks/proxy.yml
!component =test/integration/targets/yum/tasks/proxy.yml
!component =test/integration/targets/yum/tasks/proxy.yml
!component =test/integration/targets/win_pester/tasks/main.yml
!component =test/runner/lib/core_ci.py
!component =test/runner/setup/windows-httptester.ps1

ANSIBLE VERSION

$ ansible --version
ansible 2.9.0.dev0 config file = /etc/ansible/ansible.cfg configured module
search path = [u'/home/jill/.ansible/plugins/modules',
u'/usr/share/ansible/plugins/modules'] ansible python module location =
/home/jill/src/ansible/lib/ansible executable location =
/home/jill/src/ansible/bin/ansible python version = 2.7.15rc1 (default, Nov 12
2018, 14:31:15) [GCC 7.3.0]

CONFIGURATION

OS / ENVIRONMENT
STEPS TO REPRODUCE
EXPECTED RESULTS
ACTUAL RESULTS

@ansibot
Copy link
Contributor

ansibot commented May 6, 2019

@ansibot
Copy link
Contributor

ansibot commented May 6, 2019

@jillr: Greetings! Thanks for taking the time to open this issue. In order for the community to handle your issue effectively, we need a bit more information.

Here are the items we could not find in your description:

  • ansible version

Please set the description of this issue with this template:
https://raw.githubusercontent.com/ansible/ansible/devel/.github/ISSUE_TEMPLATE.md

click here for bot help

@ansibot ansibot added affects_2.9 This issue/PR affects Ansible v2.9 bug This issue/PR relates to a bug. module This issue/PR relates to a module. needs_info This issue requires further information. Please answer any outstanding questions. needs_template This issue/PR has an incomplete description. Please fill in the proposed template correctly. needs_triage Needs a first human triage before being processed. packaging Packaging category support:community This issue/PR relates to code supported by the Ansible community. support:core This issue/PR relates to code supported by the Ansible Engineering Team. system System category windows Windows community labels May 6, 2019
@samdoran samdoran removed the needs_triage Needs a first human triage before being processed. label May 14, 2019
@ansibot ansibot removed needs_info This issue requires further information. Please answer any outstanding questions. needs_template This issue/PR has an incomplete description. Please fill in the proposed template correctly. labels May 14, 2019
@mattclay
Copy link
Member

@jillr It looks like this is only an issue for new buckets, not existing ones.

S3 buckets created after September 30, 2020 will support only virtual-hosted style requests. Path-style requests will continue to be supported for buckets created on or before this date.

So while this is something that would be good to change, it's not urgent.

@jillr
Copy link
Contributor Author

jillr commented May 14, 2019

Yeah the after-the-fact clarification was very helpful. https://aws.amazon.com/blogs/aws/amazon-s3-path-deprecation-plan-the-rest-of-the-story/

@ansibot
Copy link
Contributor

ansibot commented May 30, 2019

ndclt pushed a commit to ndclt/ansible that referenced this issue Jun 13, 2019
* Change S3 bucket urls to new method as per ansible#56124

* duplicate / and dded changelog fragment

* Revert "duplicate / and dded changelog fragment"

This reverts commit b89d5cb.

* duplicate /
@ansibot ansibot added the has_pr This issue has an associated PR. label Jul 25, 2019
@ansibot
Copy link
Contributor

ansibot commented Nov 12, 2019

cc @prasoonkarunan
click here for bot help

bcoca pushed a commit to bcoca/ansible that referenced this issue Feb 21, 2020
* Change S3 bucket urls to new method as per ansible#56124

* duplicate / and dded changelog fragment

* Revert "duplicate / and dded changelog fragment"

This reverts commit b89d5cb.

* duplicate /
@jborean93
Copy link
Contributor

@jillr is this still an issue?

@jillr
Copy link
Contributor Author

jillr commented Mar 19, 2020

@jborean93 it's a nice to have rather than a need to have for existing buckets. I would recommend we do the work, but it's not a priority.

@ansibot
Copy link
Contributor

ansibot commented Mar 19, 2020

@ansibot ansibot added collection Related to Ansible Collections work collection:ansible.windows labels Apr 29, 2020
@ansible ansible locked and limited conversation to collaborators Apr 9, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
affects_2.9 This issue/PR affects Ansible v2.9 bug This issue/PR relates to a bug. collection:ansible.windows collection Related to Ansible Collections work has_pr This issue has an associated PR. module This issue/PR relates to a module. packaging Packaging category support:community This issue/PR relates to code supported by the Ansible community. support:core This issue/PR relates to code supported by the Ansible Engineering Team. system System category windows Windows community
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants