Some action plugins remove FQCN

[mkrizek]

SUMMARY

Some action plugins use hardcoded module names which results in removing FQCN. Need to audit action plugins and take task.action into account?

Example:

ansible/lib/ansible/plugins/action/yum.py

Line 69 in 49e1692

module = "dnf"

ISSUE TYPE

• Bug Report

COMPONENT NAME

action plugins

ANSIBLE VERSION

2.8
2.9

CONFIGURATION

N/A

OS / ENVIRONMENT

N/A

STEPS TO REPRODUCE

Following the example from the summary above: have a collection with action/yum.py and modules/yum.py (copied over from lib/ansible/plugins/action/yum.py and lib/ansible/modules/packaging/os/yum.py). Run a task using FQCN: my_namespace.my_collection.yum.

Do not have the collection specified in collections: which workarounds the issue.

EXPECTED RESULTS

my_namespace.my_collection.yum is executed.

ACTUAL RESULTS

Whatever the action plugin puts into module_name that is passed into execute_module is executed.

[ansibot]

Files identified in the description:

• lib/ansible/plugins/action/__init__.py

If these files are inaccurate, please update the component name section of the description or use the !component bot command.

click here for bot help

[webknjaz]

Should we patch ActionBase._execute_module() to inspect the current collection context?

[sivel]

Is this still a problem? I believe we've updated them all to utilize ansible.legacy now. In the yum action we now do module = 'ansible.legacy.' + module

[bcoca]

fixed by #71824