Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filtering by tag for Dynamic Inventory Ansible with "azure_rm plugin" #62574

Closed
gavinfish opened this issue Sep 19, 2019 · 7 comments
Closed
Labels
affects_2.10 This issue/PR affects Ansible v2.10 bot_closed feature This issue/PR relates to a feature request. has_pr This issue has an associated PR. support:community This issue/PR relates to code supported by the Ansible community.

Comments

@gavinfish
Copy link

SUMMARY

In the legacy Azure inventory script, it supports selecting hosts with specific tag key with environment variables like below.

Select hosts for specific tag key by assigning a comma separated list of tag keys to:
AZURE_TAGS=key1,key2,key3

But in the new Azure inventory plugin, it no longer supports any more. And this may make users confused when they try to migrate from the script to plugin.

ISSUE TYPE
  • Feature Idea
COMPONENT NAME

azure inventory plugin

ADDITIONAL INFORMATION

Enable selecting hosts with tags set in environment variables.

@ansibot
Copy link
Contributor

ansibot commented Sep 19, 2019

Files identified in the description:

If these files are inaccurate, please update the component name section of the description or use the !component bot command.

click here for bot help

@ansibot ansibot added affects_2.10 This issue/PR affects Ansible v2.10 feature This issue/PR relates to a feature request. needs_triage Needs a first human triage before being processed. support:community This issue/PR relates to code supported by the Ansible community. labels Sep 19, 2019
@rpurcelldesj
Copy link

rpurcelldesj commented Nov 19, 2019

I'm currently facing this issue, I was using a variable in our pipeline to target specific vm using tags and was exporting the tags to AZURE_TAGS env var in the ansible host, but the new azure_rm inventory module provided in ansible 2.8 seems to ignore the old AZURE_TAGS variable.

Do you plan to port the modification into the stable-2.8 branch ? I see you are a new contributor, I'm not that experienced, but let me know if you need help. I've been thru the PR process once in the past! Thanks for your contribution!!

@ansibot ansibot added the has_pr This issue has an associated PR. label Nov 19, 2019
@gavinfish
Copy link
Author

@rpurcelldesj I need someone review the PR and help me merge it into the right place.

@rpurcelldesj
Copy link

Ok, I've looked at the commit history and I tried to tag one of the "original" contributor to the new code, let's try that and we'll see where we go from there!

@sivel
Copy link
Member

sivel commented Aug 17, 2020

!component =contrib/inventory/azure_rm.py

@ansibot
Copy link
Contributor

ansibot commented Aug 17, 2020

Files identified in the description:

If these files are incorrect, please update the component name section of the description or use the !component bot command.

click here for bot help

@ansibot
Copy link
Contributor

ansibot commented Aug 17, 2020

Thank you very much for your interest in Ansible. Ansible has migrated much of the content into separate repositories to allow for more rapid, independent development. We are closing this issue/PR because this content has been moved to one or more collection repositories.

For further information, please see:
https://github.com/ansible/ansibullbot/blob/master/docs/collection_migration.md

@ansibot ansibot closed this as completed Aug 17, 2020
@sivel sivel removed the needs_triage Needs a first human triage before being processed. label Aug 17, 2020
@ansible ansible locked and limited conversation to collaborators Sep 14, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
affects_2.10 This issue/PR affects Ansible v2.10 bot_closed feature This issue/PR relates to a feature request. has_pr This issue has an associated PR. support:community This issue/PR relates to code supported by the Ansible community.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants