Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable-2.9] Fix ansible-test PYTHONPATH handling. #62881

Merged
merged 1 commit into from Sep 30, 2019

Conversation

mattclay
Copy link
Member

SUMMARY

Running from an installed version of ansible-test now results in tests using a dedicated directory for PYTHONPATH instead of using the site-packages directory where ansible is installed.

This provides consistency with tests running from source, which already used a dedicated directory.

Resolves #62716

Backport of #62876

(cherry picked from commit 831e1bf)

ISSUE TYPE

Bugfix Pull Request

COMPONENT NAME

ansible-test

Running from an installed version of ansible-test now results in tests using a dedicated directory for PYTHONPATH instead of using the site-packages directory where ansible is installed.

This provides consistency with tests running from source, which already used a dedicated directory.

Resolves ansible#62716
(cherry picked from commit 831e1bf)

Co-authored-by: Matt Clay <matt@mystile.com>
@ansibot ansibot added affects_2.9 This issue/PR affects Ansible v2.9 backport This PR does not target the devel branch. bug This issue/PR relates to a bug. core_review In order to be merged, this PR must follow the core review workflow. needs_triage Needs a first human triage before being processed. support:community This issue/PR relates to code supported by the Ansible community. support:core This issue/PR relates to code supported by the Ansible Engineering Team. test This PR relates to tests. labels Sep 26, 2019
@mattclay mattclay removed the needs_triage Needs a first human triage before being processed. label Sep 26, 2019
@ansibot ansibot added needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. and removed core_review In order to be merged, this PR must follow the core review workflow. labels Sep 26, 2019
@abadger abadger added this to In progress in 2.9 post beta firedrills Sep 30, 2019
@abadger abadger removed this from In progress in 2.9 post beta firedrills Sep 30, 2019
@abadger abadger added the P2 Priority 2 - Issue Blocks Release label Sep 30, 2019
@abadger abadger merged commit 988d369 into ansible:stable-2.9 Sep 30, 2019
@abadger
Copy link
Contributor

abadger commented Sep 30, 2019

Merged as a release blocker for 2.9.0rc2.

@mattclay mattclay deleted the backport-831e1bf-stable-2.9 branch October 1, 2019 19:17
@ansible ansible locked and limited conversation to collaborators Oct 28, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
affects_2.9 This issue/PR affects Ansible v2.9 backport This PR does not target the devel branch. bug This issue/PR relates to a bug. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. P2 Priority 2 - Issue Blocks Release support:community This issue/PR relates to code supported by the Ansible community. support:core This issue/PR relates to code supported by the Ansible Engineering Team. test This PR relates to tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants