validate-modules: fix version_added validation for top-level, fix error codes #70869
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ansibot
added
affects_2.11
bug
|
ready_for_review |
samdoran
removed
the
needs_triage
|
@sivel thanks for reviewing and merging! |
felixfontein
added a commit
to felixfontein/ansible
that referenced
this pull request
Jul 28, 2020
…or codes (ansible#70869) * Also validate top-level version_added. * Fix error code. * Produce same version_added validation error in schema than in code (and stop returning it twice). * Return correct error codes for invalid version_added for options and return values. * Add changelog. * Fix forgotten closing braket. * Accept 'historical' for some top-level version_added. (cherry picked from commit 7e2cc7d)
This was referenced Jul 28, 2020
nitzmahone
pushed a commit
that referenced
this pull request
Jul 29, 2020
…or codes (#70869) (#70947) * Also validate top-level version_added. * Fix error code. * Produce same version_added validation error in schema than in code (and stop returning it twice). * Return correct error codes for invalid version_added for options and return values. * Add changelog. * Fix forgotten closing braket. * Accept 'historical' for some top-level version_added. (cherry picked from commit 7e2cc7d)
zoredache
pushed a commit
to zoredache/ansible
that referenced
this pull request
Aug 10, 2020
…or codes (ansible#70869) * Also validate top-level version_added. * Fix error code. * Produce same version_added validation error in schema than in code (and stop returning it twice). * Return correct error codes for invalid version_added for options and return values. * Add changelog. * Fix forgotten closing braket. * Accept 'historical' for some top-level version_added.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Right now,
ansible-test sanity --test validate-modulesonly validates the top-levelversion_addedfor modules in ansible-base, and not in collections. Also, if an invalid value forversion_addedis used for a (sub-)option or (sub-)return value,deprecation-either-date-or-versionis returned instead ofoption-invalid-version-addedorreturn-invalid-version-added.ISSUE TYPE
COMPONENT NAME
ansible-test validate-modules