async_status does not fail when it over async timout #74184
Assignees
Labels
affects_2.9
This issue/PR affects Ansible v2.9
bug
This issue/PR relates to a bug.
easyfix
This issue is considered easy to fix by aspiring contributors.
has_pr
This issue has an associated PR.
module
This issue/PR relates to a module.
needs_info
This issue requires further information. Please answer any outstanding questions.
P3
Priority 3 - Approved, No Time Limitation
python3
support:core
This issue/PR relates to code supported by the Ansible Engineering Team.
verified
This issue has been verified/reproduced by maintainer
Comments
|
Files identified in the description: If these files are incorrect, please update the |
ansibot
added
affects_2.9
samdoran
added
needs_verified
|
Looks like the result file write on timeout got lost at some point in |
sivel
added
verified
|
I've verified this. When we kill the child process, we don't write a result out, so the file only contains the last result of the child. I just made a bunch of other changes here, but anyone can feel to pick this up and get it finished: Click to expand diff...
diff --git a/lib/ansible/modules/async_wrapper.py b/lib/ansible/modules/async_wrapper.py
index 7ba8271ef6..6694cdf3b5 100644
--- a/lib/ansible/modules/async_wrapper.py
+++ b/lib/ansible/modules/async_wrapper.py
@@ -129,11 +129,9 @@ def _make_temp_dir(path):
def _run_module(wrapped_cmd, jid, job_path):
tmp_job_path = job_path + ".tmp"
- jobfile = open(tmp_job_path, "w")
- jobfile.write(json.dumps({"started": 1, "finished": 0, "ansible_job_id": jid}))
- jobfile.close()
+ with open(tmp_job_path, "w") as jobfile:
+ json.dump({"started": 1, "finished": 0, "ansible_job_id": jid}, jobfile)
os.rename(tmp_job_path, job_path)
- jobfile = open(tmp_job_path, "w")
result = {}
# signal grandchild process started and isolated from being terminated
@@ -173,7 +171,8 @@ def _run_module(wrapped_cmd, jid, job_path):
if stderr:
result['stderr'] = stderr
- jobfile.write(json.dumps(result))
+ with open(tmp_job_path, "w") as jobfile:
+ json.dump(result, jobfile)
except (OSError, IOError):
e = sys.exc_info()[1]
@@ -182,10 +181,11 @@ def _run_module(wrapped_cmd, jid, job_path):
"cmd": wrapped_cmd,
"msg": to_text(e),
"outdata": outdata, # temporary notice only
- "stderr": stderr
+ "stderr": stderr,
+ "ansible_job_id": jid,
}
- result['ansible_job_id'] = jid
- jobfile.write(json.dumps(result))
+ with open(tmp_job_path, "w") as jobfile:
+ json.dump(result, jobfile)
except (ValueError, Exception):
result = {
@@ -193,12 +193,12 @@ def _run_module(wrapped_cmd, jid, job_path):
"cmd": wrapped_cmd,
"data": outdata, # temporary notice only
"stderr": stderr,
- "msg": traceback.format_exc()
+ "msg": traceback.format_exc(),
+ "ansible_job_id": jid,
}
- result['ansible_job_id'] = jid
- jobfile.write(json.dumps(result))
+ with open(tmp_job_path, "w") as jobfile:
+ json.dump(result, jobfile)
- jobfile.close()
os.rename(tmp_job_path, job_path)
@@ -307,6 +307,17 @@ def main():
time.sleep(step)
remaining = remaining - step
if remaining <= 0:
+ with open(job_path + ".tmp", "w") as jobfile:
+ json.dump(
+ {
+ "failed": 1,
+ "cmd": cmd,
+ "msg": "Killed async task, timed out.",
+ "timeout": True,
+ },
+ jobfile
+ )
+ os.rename(job_path + ".tmp", job_path)
notice("Now killing %s" % (sub_pid))
os.killpg(sub_pid, signal.SIGKILL)
notice("Sent kill to group %s " % sub_pid) |
sivel
added
the
easyfix
|
@schem-codes Could you please check if PR #74199 resolves your issue and let us know? Thanks. needs_info |
ansibot
added
the
needs_info
|
@schem-codes This issue is waiting for your response. Please respond or the issue will be closed. |
|
@schem-codes You have not responded to information requests in this issue so we will assume it no longer affects you. If you are still interested in this, please create a new issue with the requested information. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
and others
Summary
I'm testing what happens when the task finishes after the async setting. When using poll > 0 then the async works as it should and exits. However, using poll = 0 together with the async_status it does not error out like when using poll > 0 but continues until the retries are done
Issue Type
Bug Report
Component Name
ansible.builtin.async_status
Ansible Version
Configuration
OS / Environment
Ubuntu 20.04
Steps to Reproduce
Expected Results
fatal: []: FAILED! => {"changed": false, "msg": "async task did not complete within the requested time - 20s"}
Actual Results
Code of Conduct
I agree to follow the Ansible Code of Conduct
The text was updated successfully, but these errors were encountered: