Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: Unit tests for validation methods #75061

Merged
merged 1 commit into from Jun 22, 2021
Merged

test: Unit tests for validation methods #75061

merged 1 commit into from Jun 22, 2021

Conversation

Akasurde
Copy link
Member

SUMMARY
  • check_required_one_of()
  • check_required_by()
  • check_required_if()
  • check_missing_parameters()

Fixes: #55994

Signed-off-by: Abhijeet Kasurde akasurde@redhat.com

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

changelogs/fragments/55994_testcases.yml
lib/ansible/module_utils/common/validation.py
test/units/module_utils/common/validation/test_check_missing_parameters.py
test/units/module_utils/common/validation/test_check_required_by.py
test/units/module_utils/common/validation/test_check_required_if.py
test/units/module_utils/common/validation/test_check_required_one_of.py

@Akasurde
test: Unit tests for validation methods
b855d57 
* check_required_one_of()
* check_required_by()
* check_required_if()
* check_missing_parameters()

Fixes: ansible#55994

Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
@ansibot ansibot added affects_2.12 bug This issue/PR relates to a bug. core_review In order to be merged, this PR must follow the core review workflow. needs_triage Needs a first human triage before being processed. support:core This issue/PR relates to code supported by the Ansible Engineering Team. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. and removed core_review In order to be merged, this PR must follow the core review workflow. labels Jun 20, 2021
@Akasurde
Copy link
Member Author

/rebuild_failed

@Akasurde Akasurde closed this Jun 21, 2021
@Akasurde Akasurde reopened this Jun 21, 2021
@ansibot ansibot added core_review In order to be merged, this PR must follow the core review workflow. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. and removed needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. core_review In order to be merged, this PR must follow the core review workflow. labels Jun 21, 2021
@ansibot ansibot added core_review In order to be merged, this PR must follow the core review workflow. and removed needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Jun 22, 2021
@mkrizek mkrizek removed the needs_triage Needs a first human triage before being processed. label Jun 22, 2021
@mkrizek mkrizek merged commit b0ae3f8 into ansible:devel Jun 22, 2021
@ansible ansible locked and limited conversation to collaborators Jul 20, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Shrews Shrews Shrews approved these changes

Assignees
No one assigned
Labels
affects_2.12 bug This issue/PR relates to a bug. core_review In order to be merged, this PR must follow the core review workflow. support:core This issue/PR relates to code supported by the Ansible Engineering Team.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Write unit tests for validation methods
4 participants
@Akasurde @Shrews @mkrizek @ansibot