Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix unsafe handling of variable PYTHON_BIN in hacking/env-setup #76767

Merged
merged 1 commit into from Jan 18, 2022
Merged

Fix unsafe handling of variable PYTHON_BIN in hacking/env-setup #76767

merged 1 commit into from Jan 18, 2022

Conversation

phoehnel
Copy link
Contributor

SUMMARY

The previous state of the script lead to errors, when executing the script after cloning the repo to a path with spaces in it.

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

Repo/Developer internal helper-script hacking/env-setup

ADDITIONAL INFORMATION

With out the change, the script gives the following errors when run in a path with spaces in it

bash: /mnt/my-path/a: No such file or directory
bash: /mnt/my-path/a: No such file or directory

@phoehnel
Fix unsafe handling of variable PYTHON_BIN
f263c36 
The previous state lead to errors, when cloning the repo to a path with spaces in it.
@ansibot ansibot added affects_2.13 bug This issue/PR relates to a bug. core_review In order to be merged, this PR must follow the core review workflow. needs_triage Needs a first human triage before being processed. new_contributor This PR is the first contribution by a new community member. small_patch support:core This issue/PR relates to code supported by the Ansible Engineering Team. labels Jan 15, 2022
@mkrizek mkrizek removed the needs_triage Needs a first human triage before being processed. label Jan 18, 2022
@mkrizek mkrizek merged commit 7cd94dd into ansible:devel Jan 18, 2022
@phoehnel phoehnel deleted the feature/fix-unsafe-vars-in-env-setup branch January 18, 2022 19:25
@ansible ansible locked and limited conversation to collaborators Feb 1, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mkrizek mkrizek mkrizek approved these changes

Assignees
No one assigned
Labels
affects_2.13 bug This issue/PR relates to a bug. core_review In order to be merged, this PR must follow the core review workflow. new_contributor This PR is the first contribution by a new community member. small_patch support:core This issue/PR relates to code supported by the Ansible Engineering Team.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@phoehnel @mkrizek @ansibot