Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Adding lookup plugin for postgresql database #11315
Maybe even more useful would be a more general plugin that uses SQLAlchemy to query the database. Then you could use it with any of the database engines supported by SQLAlchemy.
Instead of taking username, password, etc., it could take a SQLAlchemy database URL (which probably a lot of people would keep in variables and encrypt with vault).
A few quick thoughts: (a) this definitely needs documentation, (b) "connection failed or something's wrong" is a complete non-starter, this is something that may well not work right the first time, and that error would drive me nuts while debugging and not help at all.
@msabramo's suggestion to use SQLAlchemy is… well, it's probably the Right Thing To Do™, though I personally don't want to have to install and learn SQLAlchemy and don't need anything but Postgres support. Being able to encrypt and store database connection information is certainly nice, but it's also possible to encrypt and store the
Dec 13, 2016
@gshivani Greetings! Thanks for taking the time to open this pullrequest. In order for the community to handle your pullrequest effectively, we need a bit more information.
Here are the items we could not find in your description:
Please set the description of this pullrequest with this template:
I know this has been open a long time, but since previous comments were not addressed we have not returned to it. Now we are trying to close these old issues and if we don't get any response to this review either we'll end up just closing the PR.
It maybe worth you creating a new branch and copying across the new file into that branch