add option to ansible-vault to read new password from file for rekey #11767

Merged
merged 1 commit into from Aug 25, 2015

Conversation

Projects
None yet
5 participants
@amenonsen
Contributor

amenonsen commented Jul 28, 2015

The --new-vault-password-file option works the same as
--vault-password-file but applies only to rekeying (when
--vault-password-file sets the old password). Also update the manpage
to document these options more fully.

@amenonsen

This comment has been minimized.

Show comment
Hide comment
@amenonsen

amenonsen Jul 30, 2015

Contributor

Updated to resolve conflicts after #11336 was merged.

Contributor

amenonsen commented Jul 30, 2015

Updated to resolve conflicts after #11336 was merged.

@amenonsen

This comment has been minimized.

Show comment
Hide comment
@amenonsen

amenonsen Aug 22, 2015

Contributor

I've pushed a second commit that fixes a problem I discovered later: an overly-strict len(self.args) check was defeating the good intentions of all but the create subcommand to handle multiple file arguments. I've tested that the second commit does fix the problem, e.g. ansible-vault rekey a.yml b.yml c.yml just works.

Contributor

amenonsen commented Aug 22, 2015

I've pushed a second commit that fixes a problem I discovered later: an overly-strict len(self.args) check was defeating the good intentions of all but the create subcommand to handle multiple file arguments. I've tested that the second commit does fix the problem, e.g. ansible-vault rekey a.yml b.yml c.yml just works.

@amenonsen

This comment has been minimized.

Show comment
Hide comment
@amenonsen

amenonsen Aug 24, 2015

Contributor

I see @bcoca cherry-picked the bugfix, so I've rebased and dropped that commit from this PR.

Contributor

amenonsen commented Aug 24, 2015

I see @bcoca cherry-picked the bugfix, so I've rebased and dropped that commit from this PR.

add option to ansible-vault to read new password from file for rekey
The --new-vault-password-file option works the same as
--vault-password-file but applies only to rekeying (when
--vault-password-file sets the old password). Also update the manpage
to document these options more fully.

abadger added a commit that referenced this pull request Aug 25, 2015

Merge pull request #11767 from amenonsen/vault-new-password-file
add option to ansible-vault to read new password from file for rekey

@abadger abadger merged commit 16e8a7d into ansible:devel Aug 25, 2015

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@abadger

This comment has been minimized.

Show comment
Hide comment
@abadger

abadger Aug 25, 2015

Member

Thanks crab!

Merged

Hi!

This has been merged in, and will also be included in the next major release.

If you or anyone else has any further questions, please let us know by stopping by one of the two mailing lists, as appropriate:

Because this project is very active, we're unlikely to see comments made on closed tickets, but the mailing list is a great way to ask questions, or post if you don't think this particular
issue is resolved.

Thank you!

Member

abadger commented Aug 25, 2015

Thanks crab!

Merged

Hi!

This has been merged in, and will also be included in the next major release.

If you or anyone else has any further questions, please let us know by stopping by one of the two mailing lists, as appropriate:

Because this project is very active, we're unlikely to see comments made on closed tickets, but the mailing list is a great way to ask questions, or post if you don't think this particular
issue is resolved.

Thank you!

@amenonsen amenonsen deleted the amenonsen:vault-new-password-file branch Aug 31, 2015

@ansibot ansibot added feature and removed feature_pull_request labels Mar 4, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment