Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Implement cat-like filtering behaviour for encrypt/decrypt #12112
referenced this pull request
Aug 26, 2015
future cleanup note: VaultLib.cipher_name is not a good attribute. It's being used in two ways, I think:
I can't think of any way that self.cipher_name will break current code so we don't have to change it in this PR but it seems conceptually wrong and might be a source of bugs with future code changes.
Review and everything here looks good to me. At first I had some questions in the same area as @bcoca did but I think all of the ways of operating that I'd expect are covered. Just not quite the same way as cat:
There's other UNIX tools that operate this way (using explicit -o- to specify output to stdout) so it looks okay to me. @bcoca does that summary of the options alleviate your concern?
added a commit
this pull request
Aug 27, 2015
Nice work! I like the new behaviour a lot. thanks @amenonsen !
This has been merged in, and will also be included in the next major release.
If you or anyone else has any further questions, please let us know by stopping by one of the two mailing lists, as appropriate:
Because this project is very active, we're unlikely to see comments made on closed tickets, but the mailing list is a great way to ask questions, or post if you don't think this particular