update_json for module intermediate comms #13620
- new update_json method that sends 'intermediate messages' - new internal flag that can enable this facility from controller - method to run_command and log, log also requires debug to return data - 'live' keyword, enables 'live updates' from modules that support it - common method for connections to use fixes to module sending - spilt json filtering to return trailing data vs warnings - customized display - added 'live' toggles for adhoc/console TODO: - hook into callbacks instead of vvvvv - factor in async - only disable buffer if live - update stdin/stdout only if needed
When all the file descriptors are empty and closed we still have to enter the if block to remove them from rpipes which means we will have to call `select()` again on the next iteration and as a result wait for the timeout unnecessarily which leads to a 1 second slowdown for each command being run. (cherry picked from commit 8e5c985)
CI failure in unit tests:
CI failure (timeout) in integration tests:
This was referenced
Jun 26, 2019
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments.