New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update_json for module intermediate comms #13620

Open
wants to merge 4 commits into
base: devel
from

Conversation

@bcoca
Member

bcoca commented Dec 21, 2015

  • new 'live' keyword to indicate you want intermediate (live) updates from module execution
  • added 'live' intelligence to 'run_command' for those modules executing commands using it
  • displays when -vvvvv ... really should be using callback, but they need to be extended first

implements ansible/proposals#92

@bcoca bcoca added this to the next milestone Dec 21, 2015

@bcoca bcoca force-pushed the bcoca:update_json branch Jan 15, 2016

@bcoca bcoca force-pushed the bcoca:update_json branch 2 times, most recently Feb 15, 2016

@jimi-c jimi-c modified the milestones: 2.2.0, stable-2.1 Jun 21, 2016

@bcoca bcoca changed the title from draft update_json for module intermediate comms to [WIP] update_json for module intermediate comms Nov 29, 2016

@jimi-c jimi-c removed the module_util label Jan 5, 2017

@bcoca bcoca removed this from the 2.2.0 milestone Mar 15, 2017

@ansibot ansibot removed the stale_ci label Sep 10, 2018

@tsipinakis

This comment has been minimized.

tsipinakis commented Sep 11, 2018

Whoops, that's what I get for not testing python3, pushed a fixup.

Perhaps it'd be better for me to open a new PR for this?

@danieljaouen

This comment has been minimized.

Contributor

danieljaouen commented Oct 1, 2018

@tsipinakis What is the status of this pull request? Interested because this will fix #29403.

@tsipinakis

This comment has been minimized.

tsipinakis commented Oct 3, 2018

@danieljaouen Paused until I get some more time to see why the tests are (still) failing. If you want to take it over go right ahead.

@danieljaouen

This comment has been minimized.

Contributor

danieljaouen commented Oct 3, 2018

@tsipinakis Perhaps @bcoca could shed some light on why the tests are failing?

@thaumos thaumos added this to To Do - Backlog only. Anything Can be here. in Ansible 2.8 Oct 9, 2018

@acozine

This comment has been minimized.

Contributor

acozine commented Nov 16, 2018

@tsipinakis @danieljaouen this PR needs to be rebased - the branch is 987 commits behind the current devel branch (see https://github.com/bcoca/ansible/branches/all?page=2). The PR won't pass Ansible's test suite until the branch has been rebased.

bcoca and others added some commits Feb 9, 2018

Added ability to modules to emit 'update messsages'
  - new update_json method that sends 'intermediate messages'
  - new internal flag that can enable this facility from controller
  - method to run_command and log, log also requires debug to return data
  - 'live' keyword, enables 'live updates' from modules that support it
  - common method for connections to use fixes to module sending
  - spilt json filtering to return trailing data vs warnings
  - customized display
  - added 'live' toggles for adhoc/console

TODO:
  - hook into callbacks instead of vvvvv
  - factor in async
  - only disable buffer if live
  - update stdin/stdout only if needed
Fix performance degradation when running commands
When all the file descriptors are empty and closed we still have to
enter the if block to remove them from rpipes which means we will have
to call `select()` again on the next iteration and as a result wait for
the timeout unnecessarily which leads to a 1 second slowdown for each
command being run.

(cherry picked from commit 8e5c985)
fixup! Add live support to local connection
(cherry picked from commit 6c91526)

@bcoca bcoca force-pushed the bcoca:update_json branch from 8ddf291 to cd394cf Nov 27, 2018

@mattclay

This comment has been minimized.

Member

mattclay commented Nov 28, 2018

CI failure in unit tests and integration tests, as well as timeouts on many integration tests.

@gundalow

This comment has been minimized.

Contributor

gundalow commented Dec 6, 2018

!waffling stale_ci

@ansibot ansibot added docsite stale_ci and removed ci_verified labels Dec 6, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment