New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Groups naming convention in vagrant hosts provider #14235

Open
wants to merge 3 commits into
base: devel
from

Conversation

Projects
None yet
4 participants
@erikzaadi

erikzaadi commented Feb 1, 2016

Add Grouping by naming convention capabilities:

If the file vagrant.ini is present, and contains a regex:

[vagrant]
host_match_regex = '(.*?)(?:-[0-9]+)?$'

Then any vagrant machine with the following naming convention will be grouped:

Machine: <NAME>-X => Group: <NAME>

This is in addition to the previously used vagrant group.

If the vagrant.ini file doesn't exist (or the needed option) then the vagrant host provider will continue as before.

Any group caught in the regex will be used as a host group.

@bcoca

This comment has been minimized.

Member

bcoca commented Feb 1, 2016

this would break many an inventory that uses the - but does not follow this convention

@bcoca bcoca added the needs_revision label Feb 1, 2016

@erikzaadi

This comment has been minimized.

erikzaadi commented Feb 2, 2016

@bcoca Perhaps if the host pattern was in an additional config file?

@erikzaadi

This comment has been minimized.

erikzaadi commented Feb 7, 2016

@bcoca updated.

@ansibot

This comment has been minimized.

Contributor

ansibot commented Jan 5, 2017

@erikzaadi This PR was tested by travis-ci.org, which is no longer used. Please rebase your branch to trigger running of current tests.

click here for bot help

@ansibot

This comment has been minimized.

Contributor

ansibot commented Jan 6, 2017

@erikzaadi This PR was tested by travis-ci.org, which is no longer used. Please rebase your branch to trigger running of current tests.

click here for bot help

@ansibot ansibot added the needs_rebase label Jan 8, 2017

@ansibot

This comment has been minimized.

Contributor

ansibot commented Feb 7, 2017

@erikzaadi this PR contains the following merge comits:

Please rebase your branch to remove these commits.

click here for bot help

@ansibot ansibot added the merge_commit label Feb 7, 2017

@ansibot

This comment has been minimized.

Contributor

ansibot commented Apr 11, 2017

@erikzaadi Greetings! Thanks for taking the time to open this pullrequest. In order for the community to handle your pullrequest effectively, we need a bit more information.

Here are the items we could not find in your description:

  • issue type

Please set the description of this pullrequest with this template:
https://raw.githubusercontent.com/ansible/ansible/devel/.github/PULL_REQUEST_TEMPLATE.md

click here for bot help

@ansibot ansibot added the needs_info label Apr 11, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment