New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the template lookup match the template action #15081

Closed
wants to merge 1 commit into
base: devel
from

Conversation

3 participants
@insom
Copy link

insom commented Mar 21, 2016

Issue Type:
  • Feature Pull Request
Ansible Version:
ansible 2.1.0 (devel 723139900e) last updated 2016/03/21 22:28:33 (GMT +100)
  lib/ansible/modules/core: (detached HEAD d71b9bae89) last updated 2016/03/21 22:17:11 (GMT +100)
  lib/ansible/modules/extras: (detached HEAD d5030ae555) last updated 2016/03/21 22:17:16 (GMT +100)
  config file = 
  configured module search path = Default w/o overrides
Summary:

Fixes #15044. I've copied functionality from the template action into the template lookup so that the same pre-set Ansible variables are available in both.

The template action sets variables (such as ansible_managed) which are not set for the equivalent template lookup. This change remedies this and is covered by matching integration tests.

Make the template lookup match the template action
The `template` action sets variables (such as `ansible_managed`) which are not
set for the equivalent `template` lookup. This change remedies this and is
covered by matching integration tests.
@bcoca

This comment has been minimized.

Copy link
Member

bcoca commented Mar 22, 2016

I'm actually a proponent of removing ansible_managed so really not looking to extend it's use.

@ansibot

This comment has been minimized.

Copy link
Contributor

ansibot commented Jan 5, 2017

@insom This PR was tested by travis-ci.org, which is no longer used. Please rebase your branch to trigger running of current tests.

click here for bot help

@ansibot

This comment has been minimized.

Copy link
Contributor

ansibot commented Jan 6, 2017

@insom This PR was tested by travis-ci.org, which is no longer used. Please rebase your branch to trigger running of current tests.

click here for bot help

@insom insom closed this Jan 7, 2017

@insom insom deleted the insom:feature-lookup-parity branch Jan 7, 2017

@mattclay mattclay moved this from Tests In Progress to Done in Testing Feb 15, 2017

@ansibot ansibot added feature and removed feature_pull_request labels Mar 4, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment