Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set ansible_os_family correctly under KDE neon #18224

Merged
merged 1 commit into from Oct 27, 2016

Conversation

Projects
None yet
3 participants
@ribbons
Copy link
Contributor

commented Oct 27, 2016

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

module_utils

ANSIBLE VERSION
ansible 2.3.0 (devel 680cade77a) last updated 2016/10/27 11:30:21 (GMT +100)
  lib/ansible/modules/core: (detached HEAD c51ced56cc) last updated 2016/10/27 16:07:21 (GMT +100)
  lib/ansible/modules/extras: (detached HEAD 8ffe314ea5) last updated 2016/10/27 16:07:22 (GMT +100)
SUMMARY

As KDE neon is derived from Ubuntu, ansible_os_family should have the value Debian instead of Neon. This PR adds a test case for KDE neon and sets the os_family fact correctly for it.

Change in output from ansible hostname -m setup under KDE neon:

335c335
<         "ansible_os_family": "Neon", 

---
>         "ansible_os_family": "Debian", 
Set ansible_os_family correctly under KDE neon
As neon is derived from Ubuntu, ansible_os_family should have the value
"Debian" instead of "Neon".  Add a test case for KDE neon and set
os_family correctly for it.
@nitzmahone

This comment has been minimized.

Copy link
Member

commented Oct 27, 2016

Thanks! Merging to devel, adding to 2.2 branch for inclusion in 2.2.1.

@nitzmahone nitzmahone merged commit 36e178c into ansible:devel Oct 27, 2016

1 check passed

Shippable Run 4917 status is SUCCESS.
Details

@ribbons ribbons deleted the ribbons:kde-neon-os-family branch Oct 27, 2016

@ansibot ansibot added bug and removed bugfix_pull_request labels Mar 5, 2018

@ansible ansible locked and limited conversation to collaborators Apr 26, 2019

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
You can’t perform that action at this time.