Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set ansible_os_family correctly under KDE neon #18224

Merged
merged 1 commit into from Oct 27, 2016
Merged

Set ansible_os_family correctly under KDE neon #18224

merged 1 commit into from Oct 27, 2016

Conversation

ribbons
Copy link
Contributor

@ribbons ribbons commented Oct 27, 2016

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

module_utils

ANSIBLE VERSION
ansible 2.3.0 (devel 680cade77a) last updated 2016/10/27 11:30:21 (GMT +100)
  lib/ansible/modules/core: (detached HEAD c51ced56cc) last updated 2016/10/27 16:07:21 (GMT +100)
  lib/ansible/modules/extras: (detached HEAD 8ffe314ea5) last updated 2016/10/27 16:07:22 (GMT +100)
SUMMARY

As KDE neon is derived from Ubuntu, ansible_os_family should have the value Debian instead of Neon. This PR adds a test case for KDE neon and sets the os_family fact correctly for it.

Change in output from ansible hostname -m setup under KDE neon:

335c335
<         "ansible_os_family": "Neon", 

---
>         "ansible_os_family": "Debian",

@ribbons
Set ansible_os_family correctly under KDE neon
4ff8890 
As neon is derived from Ubuntu, ansible_os_family should have the value
"Debian" instead of "Neon".  Add a test case for KDE neon and set
os_family correctly for it.
@nitzmahone nitzmahone added bugfix_pull_request affects_2.2 This issue/PR affects Ansible v2.2 affects_2.3 This issue/PR affects Ansible v2.3 labels Oct 27, 2016
@nitzmahone
Copy link
Member

Thanks! Merging to devel, adding to 2.2 branch for inclusion in 2.2.1.

@nitzmahone nitzmahone merged commit 36e178c into ansible:devel Oct 27, 2016
@ribbons ribbons deleted the kde-neon-os-family branch October 27, 2016 20:23
@ansibot ansibot added bug This issue/PR relates to a bug. and removed bugfix_pull_request labels Mar 5, 2018
@ansible ansible locked and limited conversation to collaborators Apr 26, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
affects_2.2 This issue/PR affects Ansible v2.2 affects_2.3 This issue/PR affects Ansible v2.3 bug This issue/PR relates to a bug.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ribbons @nitzmahone @ansibot