New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecation version enforcement #18470

Open
wants to merge 3 commits into
base: devel
from

Conversation

@bcoca
Member

bcoca commented Nov 11, 2016

ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME

deprecations

ANSIBLE VERSION
2.3

fixes #18559

@bcoca bcoca added this to the 2.3.0 milestone Nov 11, 2016

@jimi-c jimi-c added the in progress label Nov 11, 2016

lib/ansible/playbook/become.py Outdated
@@ -77,7 +77,7 @@ def _preprocess_data_become(self, ds):
ds['become_user'] = ds['sudo_user']
del ds['sudo_user']
display.deprecated("Instead of sudo/sudo_user, use become/become_user and make sure become_method is 'sudo' (default)")
display.deprecated("Instead of sudo/sudo_user, use become/become_user and make sure become_method is 'sudo' (default)", version="2.4")

This comment has been minimized.

@mattclay

mattclay Nov 11, 2016

Member

Since removal of this was deferred from 2.2, my vote is for 2.3 instead of 2.4.

lib/ansible/playbook/become.py Outdated
@@ -89,7 +89,7 @@ def _preprocess_data_become(self, ds):
ds['become_user'] = ds['su_user']
del ds['su_user']
display.deprecated("Instead of su/su_user, use become/become_user and set become_method to 'su' (default is sudo)")
display.deprecated("Instead of su/su_user, use become/become_user and set become_method to 'su' (default is sudo)", version="2.4")

This comment has been minimized.

@mattclay

mattclay Nov 11, 2016

Member

Since removal of this was deferred from 2.2, my vote is for 2.3 instead of 2.4.

@bcoca bcoca force-pushed the bcoca:deprecation_version_enforcement branch to 338a711 Nov 14, 2016

@@ -690,7 +690,7 @@ def _get_connection(self, variables, templar):
if self._play_context.accelerate:
# accelerate is deprecated as of 2.1...
display.deprecated('Accelerated mode is deprecated. Consider using SSH with ControlPersist and pipelining enabled instead')
display.deprecated('Accelerated mode is deprecated. Consider using SSH with ControlPersist and pipelining enabled instead', version="2.3", removed=True)

This comment has been minimized.

@abadger

abadger Nov 28, 2016

Member

removed=True is present here but removed has been taken out of the deprecated function.

@abadger

This comment has been minimized.

Member

abadger commented Nov 28, 2016

Found one thing that needs fixing. Rest seems good.

I assume the removal of tests is because they're testing things that are deprecated (and thus raise deprecation errors when the tests run)? We might want to use that as a signa to remove the deprecated code as well, not just the tests.

@@ -75,7 +75,7 @@
- hosts: facthost5
tags: [ 'fact_comma_string' ]
connection: local
gather_subset: "virtual,network"
gather_subset: ["virtual","network"]

This comment has been minimized.

@abadger

abadger Nov 28, 2016

Member

shippable is failing due to this output from yamllint:

2016-11-14 18:21:46 ./test/integration/targets/gathering_facts/test_gathering_facts.yml
2016-11-14 18:21:46 78:29 error too few spaces after comma (commas)
2016-11-14 18:21:46 122:31 error too few spaces after comma (commas)

So just rewrite the two lines in this file as:

 gather_subset: ["virtual", "network"]
@mattclay

This comment has been minimized.

@bcoca

This comment has been minimized.

Member

bcoca commented Apr 10, 2018

@mattclay actually, working as expected, the 'warnings' become errors when they pass the version they were supposed to be removed in

@mattclay

This comment has been minimized.

Member

mattclay commented Apr 10, 2018

@bcoca Understood. I'm just documenting the source of failures when applying the ci_verified label.

@ansibot ansibot added the stale_ci label Apr 21, 2018

@bcoca bcoca force-pushed the bcoca:deprecation_version_enforcement branch Apr 23, 2018

@mattclay mattclay added the ci_verified label May 2, 2018

@ansibot ansibot added the stale_ci label May 2, 2018

@bcoca bcoca force-pushed the bcoca:deprecation_version_enforcement branch May 18, 2018

bcoca added some commits Apr 4, 2018

automatically 'remove' when deprecation cycle ends
now the code will remove features as promissed

@bcoca bcoca force-pushed the bcoca:deprecation_version_enforcement branch to 870226f May 23, 2018

@ansibot ansibot added the stale_ci label May 31, 2018

@bcoca bcoca removed this from the 2.4.0 milestone Aug 27, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment