New module: remove_host

[jpic]

ISSUE TYPE

• Feature Pull Request
• New Module Pull Request

COMPONENT NAME

remove_host

ANSIBLE VERSION

ansible 2.3.0 (remove_host f7f455dd84) last updated 2016/11/23 11:21:43 (GMT +200)
  lib/ansible/modules/core: (detached HEAD b598611afb) last updated 2016/11/23 11:23:32 (GMT +200)
  lib/ansible/modules/extras: (detached HEAD 25292b3ebd) last updated 2016/11/23 11:23:32 (GMT +200)
  config file = /home/jpic/.ansible.cfg
  configured module search path = ['/home/jpic/ansible/library', '/usr/share/ansible']

SUMMARY

Added remove_host module. This is for when a task actually destroys a host, then it can be removed from further plays.

[bcoca]

making note of needing docs (module stub) once this is merged

[jpic]

Thanks for accepting this, but the test should fail, looks like this commit misses something to have it executed, any clue please ?

[gundalow]

@jpic The tests need referencing from test/integration/non_destructive.yml (assuming they are non destructive.

[jpic]

Thank you @gundalow ! Tests are running, but it can't find remote_host. Probably because it's missing from modules/core ? ansible/ansible-modules-core#5726

2016-11-25 18:10:03 ERROR! no action detected in task. This often indicates a misspelled module name, or incorrect module path.

Locally it works great:

TASK [add_host] **************************************************************************************************************************************************
task path: /home/jpic/work/novapost/ansible-boot-lxc/test.yml:8
creating host via 'add_host': hostname=testboot.lxc
changed: [localhost] => {
    "add_host": {
        "groups": [
            "testboot"
        ], 
        "host_name": "testboot.lxc", 
        "host_vars": {
            "lxc_container_config": [
                "lxc.mount.entry=/home/jpic/work/novapost/ansible-boot-lxc srv none defaults,bind,create=dir,uid=0 0 0"
            ]
        }
    }, 
    "changed": true
}

TASK [debug] *****************************************************************************************************************************************************
task path: /home/jpic/work/novapost/ansible-boot-lxc/test.yml:13
ok: [localhost] => {
    "groups": {
        "all": [
            "testboot.lxc"
        ], 
        "testboot": [
            "testboot.lxc"
        ], 
        "ungrouped": [
            "localhost"
        ]
    }
}

TASK [remove_host] ***********************************************************************************************************************************************
task path: /home/jpic/work/novapost/ansible-boot-lxc/test.yml:14
changed: [localhost] => {
    "changed": true, 
    "remove_host": {
        "host_name": "testboot.lxc"
    }
}

TASK [debug] *****************************************************************************************************************************************************
task path: /home/jpic/work/novapost/ansible-boot-lxc/test.yml:16
ok: [localhost] => {
    "groups": {
        "all": [], 
        "testboot": [], 
        "ungrouped": [
            "localhost"
        ]
    }
}

Isn't the best thing to do now creating another branch with a submodule reference to my fork of core modules ?

[gundalow]

Changes to lib/ansible/modules/* must be in another PR, once merger we (Ansible Core Team) will update the submodules reference

Once the above is done this you can test this PR.

Please remove the change to lib/ansible/modules/core

The git submodule pain will be going away very shortly

[gundalow]

needs_revision

[mattclay]

@jpic One of the test failures is due to a yamllint test failure:

test/integration/targets/remove_host/tasks/main.yml
  36:25     error    syntax error: mapping values are not allowed here

[gundalow]

rebase needed

[jpic]

@gundalow is there any change request that is not implemented ?