Support for simpleinit-msb init system

[vaygr]

ISSUE TYPE

Feature Pull Request

COMPONENT NAME

lib/ansible/modules/system/service.py

ANSIBLE VERSION

2.2.0.0

SUMMARY

After package management it's the last of 2 main parts of any distro -- an init system.

This adds full support for simpleinit-msb used in Source Mage.

The init system is very simple and unique to Source Mage, based on the Linux Boot Scripts design pattern.

It uses telinit binary to manage init scripts in the system, move them between runlevels, enable/disable, and even install and remove them:

telinit run <script> [<args>]        run init <script> with arguments <args>
telinit switch <rlvl>                switch to runlevel <rlvl>
telinit enable [<script> ... ]       enable and start <script> if not enabled
telinit disable [<script> ... ]      stop and disable <script> if not disabled
telinit bootenable [<script> ... ]   enable <script> if not enabled
telinit bootdisable [<script> ... ]  disable <script> if not disabled
telinit delete [<script> ... ]       delete <script> if disabled
telinit enabled                      list enabled startup scripts
telinit disabled                     list disabled startup scripts
telinit list                         list startup scripts and their runlevels
telinit runlevels                    list all runlevels
telinit runlevel                     print the highest completed runlevel
telinit move <script> <rlvl>         move <script> to runlevel <rlvl>
telinit install <file> <rlvl>        install <file> into runlevel <rlvl>
telinit spellinstall <spell>         install <spell>'s init or xinetd scripts

I've also managed to add some protection for non-existing scripts inside Ansible code.

[bcoca]

so the service module is being broken up into component modules in hopes of deprecating it soon, so I am remiss on adding this to it.

I would resubmit as it's own module and also add the init system to fact detection to set the ansible_service_mgr variable.

[vaygr]

I see the point. I just thought it might be less work for initial support, since it's not really that complicated change and most of patterns and code are re-used within the service module. Also it'd be great to see it coming along with sorcery module in 2.3 release.

[mattclay]

CI failure due to PEP 8 issue:

2017-01-31 19:29:56 ERROR: PEP 8: lib/ansible/modules/system/service.py:442:161: E501 line too long (161 > 160 characters) (current)

[vaygr]

@mattclay thanks, corrected.

[ansibot]

The test ansible-test sanity --test pep8 failed with the following error:

contrib/inventory/lxd.py:26:29: E231 missing whitespace after ','

click here for bot help

[vaygr]

@bcoca @mattclay is there a chance to ship it with upcoming 2.3?

[gundalow]

CI was failing due to infrastructure issues bring up MacOS images (unrelated to this change) I've rescheduled the CI

[gundalow]

@vaygr Feature freeze for Ansible 2.3 was a number of weeks ago

[vaygr]

Oh, I'm too late to remind then. Hopefully it'll get its way into 2.4 with above mentioned refactoring or without, because init system support is quite important for full system support.

[vaygr]

Bumping for inclusion in 2.4!

[bcoca]

@vaygr my initial comment still stands, we are not adding functionality to the existing service module, so this should be submitted as a separate one.

[vaygr]

@bcoca oh, it wasn't clear in your first comment that it's a strict requirement now. I'll see what I can do.

[gundalow]

I'm guessing this should be closed and a new PR raised for the new format?

needs_info

[ansibot]

@vaygr This pullrequest is waiting for your response. Please respond or the pullrequest will be closed.

click here for bot help

[ansibot]

@vaygr You have not responded to information requests in this pullrequest so we will assume it no longer affects you. If you are still interested in this, please create a new pullrequest with the requested information.

click here for bot help