New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Recognise pkgin when installed in the global zone on SmartOS #19679

Merged
merged 1 commit into from Jan 2, 2017

Conversation

Projects
None yet
3 participants
@jasperla
Contributor

jasperla commented Dec 26, 2016

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

Facts (setup module)

ANSIBLE VERSION
ansible 2.3.0 (pkgin_gz 0b7e973dab) last updated 2016/12/25 13:43:29 (GMT +200)
  config file =
  configured module search path = Default w/o overrides
SUMMARY

Currently the pkg_mgr fact is not set for SmartOS global zones with pkgin installed. As documented upstream the prefix for the "SmartOS GZ" is /opt/tools. This PR teaches Ansible to look there too for the pkgin binary and set the fact accordingly.

Before:

calafate-gz | SUCCESS => {
    "ansible_facts": {
        "ansible_pkg_mgr": "unknown"
    },
    "changed": false
}

After:

calafate-gz | SUCCESS => {
    "ansible_facts": {
        "ansible_pkg_mgr": "pkgin"
    },
    "changed": false
}

@jasperla jasperla force-pushed the jasperla:pkgin_gz branch to 83f9da6 Dec 27, 2016

@jasperla

This comment has been minimized.

Contributor

jasperla commented Dec 27, 2016

Pushed again as Shippable failed previously with an unrelated ERROR: 504: Endpoint request timed out.

@ansibot ansibot removed the needs_revision label Dec 27, 2016

@bcoca bcoca removed the needs_triage label Jan 2, 2017

@bcoca bcoca merged commit 0c0defb into ansible:devel Jan 2, 2017

1 check passed

Shippable Run 8057 status is SUCCESS.
Details

@ansibot ansibot added bug and removed bugfix_pull_request labels Mar 5, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment