New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the editable condition into pip module (#19028) #19688

Merged
merged 2 commits into from Jul 14, 2017

Conversation

Projects
None yet
9 participants
@Lujeni
Contributor

Lujeni commented Dec 26, 2016

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

pip

ANSIBLE VERSION
ansible 2.2.0.0
SUMMARY

Related to #19028.

The pip editable flag should be added when when editable directive is set (not only compound condition with vcs)

@ansibot

This comment has been minimized.

Show comment
Hide comment
@ansibot
Contributor

ansibot commented Dec 26, 2016

@abadger

This comment has been minimized.

Show comment
Hide comment
@abadger

abadger Jan 5, 2017

Member

@pumazi @mattupstate Could you guys review to see if this looks right and fixes issue ##19028 ? Thanks!

Member

abadger commented Jan 5, 2017

@pumazi @mattupstate Could you guys review to see if this looks right and fixes issue ##19028 ? Thanks!

@pumazi

This comment has been minimized.

Show comment
Hide comment
@pumazi

pumazi Jan 15, 2017

I tried this on a rather simple use case. I can verify that the patch works. @Lujeni Thanks for the fix! 👍

pumazi commented Jan 15, 2017

I tried this on a rather simple use case. I can verify that the patch works. @Lujeni Thanks for the fix! 👍

@mattclay

This comment has been minimized.

Show comment
Hide comment
@mattclay

mattclay Feb 2, 2017

Member

CI failure due to:

2017-02-02 00:36:09 fatal: [testhost]: FAILED! => {
2017-02-02 00:36:09     "changed": false, 
2017-02-02 00:36:09     "cmd": "/usr/bin/pip2 uninstall -y -e isort", 
2017-02-02 00:36:09     "failed": true, 
2017-02-02 00:36:09     "invocation": {
2017-02-02 00:36:09         "module_args": {
2017-02-02 00:36:09             "chdir": null, 
2017-02-02 00:36:09             "editable": true, 
2017-02-02 00:36:09             "executable": null, 
2017-02-02 00:36:09             "extra_args": null, 
2017-02-02 00:36:09             "name": [
2017-02-02 00:36:09                 "isort"
2017-02-02 00:36:09             ], 
2017-02-02 00:36:09             "requirements": null, 
2017-02-02 00:36:09             "state": "absent", 
2017-02-02 00:36:09             "umask": null, 
2017-02-02 00:36:09             "use_mirrors": true, 
2017-02-02 00:36:09             "version": null, 
2017-02-02 00:36:09             "virtualenv": null, 
2017-02-02 00:36:09             "virtualenv_command": "virtualenv", 
2017-02-02 00:36:09             "virtualenv_python": null, 
2017-02-02 00:36:09             "virtualenv_site_packages": false
2017-02-02 00:36:09         }, 
2017-02-02 00:36:09         "module_name": "pip"
2017-02-02 00:36:09     }, 
2017-02-02 00:36:09     "msg": "\n:stderr: \nUsage:   \n  pip uninstall [options] <package> ...\n  pip uninstall [options] -r <requirements file> ...\n\nno such option: -e\n"
2017-02-02 00:36:09 }
Member

mattclay commented Feb 2, 2017

CI failure due to:

2017-02-02 00:36:09 fatal: [testhost]: FAILED! => {
2017-02-02 00:36:09     "changed": false, 
2017-02-02 00:36:09     "cmd": "/usr/bin/pip2 uninstall -y -e isort", 
2017-02-02 00:36:09     "failed": true, 
2017-02-02 00:36:09     "invocation": {
2017-02-02 00:36:09         "module_args": {
2017-02-02 00:36:09             "chdir": null, 
2017-02-02 00:36:09             "editable": true, 
2017-02-02 00:36:09             "executable": null, 
2017-02-02 00:36:09             "extra_args": null, 
2017-02-02 00:36:09             "name": [
2017-02-02 00:36:09                 "isort"
2017-02-02 00:36:09             ], 
2017-02-02 00:36:09             "requirements": null, 
2017-02-02 00:36:09             "state": "absent", 
2017-02-02 00:36:09             "umask": null, 
2017-02-02 00:36:09             "use_mirrors": true, 
2017-02-02 00:36:09             "version": null, 
2017-02-02 00:36:09             "virtualenv": null, 
2017-02-02 00:36:09             "virtualenv_command": "virtualenv", 
2017-02-02 00:36:09             "virtualenv_python": null, 
2017-02-02 00:36:09             "virtualenv_site_packages": false
2017-02-02 00:36:09         }, 
2017-02-02 00:36:09         "module_name": "pip"
2017-02-02 00:36:09     }, 
2017-02-02 00:36:09     "msg": "\n:stderr: \nUsage:   \n  pip uninstall [options] <package> ...\n  pip uninstall [options] -r <requirements file> ...\n\nno such option: -e\n"
2017-02-02 00:36:09 }

@mattclay mattclay added the ci_verified label Feb 2, 2017

@mattclay

This comment has been minimized.

Show comment
Hide comment
@mattclay

mattclay Feb 2, 2017

Member

The test that fails is this one:

2017-02-02 00:36:08 TASK [pip : ensure a package is not installed (precondition setup)] ************
Member

mattclay commented Feb 2, 2017

The test that fails is this one:

2017-02-02 00:36:08 TASK [pip : ensure a package is not installed (precondition setup)] ************

@ansibot ansibot removed the ci_verified label Feb 5, 2017

@Lujeni

This comment has been minimized.

Show comment
Hide comment
@Lujeni

Lujeni Feb 5, 2017

Contributor

Hello,

All seems good now for the CI. @mattclay

Contributor

Lujeni commented Feb 5, 2017

Hello,

All seems good now for the CI. @mattclay

@Lujeni

This comment has been minimized.

Show comment
Hide comment
@Lujeni

Lujeni Jun 23, 2017

Contributor

Friendly bump

Contributor

Lujeni commented Jun 23, 2017

Friendly bump

@mattclay

This comment has been minimized.

Show comment
Hide comment
@mattclay

mattclay Jul 14, 2017

Member

CI failure in integration tests test/integration/targets/pip/tasks/pip.yml:118: pip : check that a change didn't occurr:

{
    "assertion": "not url_installed.changed", 
    "changed": false, 
    "evaluated_to": false, 
    "failed": true
}
Member

mattclay commented Jul 14, 2017

CI failure in integration tests test/integration/targets/pip/tasks/pip.yml:118: pip : check that a change didn't occurr:

{
    "assertion": "not url_installed.changed", 
    "changed": false, 
    "evaluated_to": false, 
    "failed": true
}
Add editable to tests
Default changed to False, so now editable: True is needed explicitly in
tests
@gundalow

This comment has been minimized.

Show comment
Hide comment
@gundalow

gundalow Jul 14, 2017

Contributor

Merged into devel will be released in 2.4.0

Contributor

gundalow commented Jul 14, 2017

Merged into devel will be released in 2.4.0

@gundalow gundalow merged commit 661791d into ansible:devel Jul 14, 2017

1 check passed

Shippable Run 28674 status is SUCCESS.
Details

AlanCoding added a commit to AlanCoding/ansible that referenced this pull request Jul 18, 2017

Fix the editable condition into pip module (ansible#19028) (ansible#1…
…9688)

* Fix the editable condition into pip module (ansible#19028)

* Add editable to tests

Default changed to False, so now editable: True is needed explicitly in
tests

@ansibot ansibot added bug and removed bugfix_pull_request labels Mar 5, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment