New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check the command result status in easy_install plugin (#16519) #19705

Merged
merged 1 commit into from Jan 5, 2017

Conversation

Projects
None yet
5 participants
@Lujeni
Contributor

Lujeni commented Dec 28, 2016

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

easy_install

ANSIBLE VERSION
2.2.0.0
SUMMARY

Before install any packages, the plugin check if the package is already installed.
However, the result command was never tested (e.g. root permission).
Related to #16519

TEST
- name: test easy_install
  hosts: all
  tasks:
   - name: test
     easy_install:
       name: pip

   - name: install
     pip: name=requests
# with the fix
✘-2 ~/works/repos/perso/ansible/issue_16519 
00:55 $ ansible-playbook -i localhost, test.yaml -c local -v 
No config file found; using defaults

PLAY [test easy_install] *******************************************************

TASK [setup] *******************************************************************
ok: [localhost]

TASK [test] ********************************************************************
fatal: [localhost]: FAILED! => {"changed": false, "failed": true, "msg": "error: can't create or remove files in install directory\n\nThe following error occurred while trying to add or remove files in the\ninstallation directory:\n\n    [Errno 13] Permission denied: '/usr/lib64/python2.7/site-packages/test-easy-install-13288.write-test'\n\nThe installation directory you specified (via --install-dir, --prefix, or\nthe distutils default setting) was:\n\n    /usr/lib64/python2.7/site-packages/\n\nPerhaps your account does not have write access to this directory?  If the\ninstallation directory is a system-owned directory, you may need to sign in\nas the administrator or \"root\" account.  If you do not have administrative\naccess to this machine, you may wish to choose a different installation\ndirectory, preferably one that is listed in your PYTHONPATH environment\nvariable.\n\nFor information on other options, you may wish to consult the\ndocumentation at:\n\n  https://pythonhosted.org/setuptools/easy_install.html\n\nPlease make the appropriate changes for your system and try again.\n\n"}
	to retry, use: --limit @/home/julien/works/repos/perso/ansible/issue_16519/test.retry

PLAY RECAP *********************************************************************
localhost                  : ok=1    changed=0    unreachable=0    failed=1   
@ansibot

This comment has been minimized.

Show comment
Hide comment
@ansibot
Contributor

ansibot commented Dec 28, 2016

@jimi-c jimi-c removed the plugin label Jan 4, 2017

@abadger abadger merged commit ee1dee0 into ansible:devel Jan 5, 2017

1 check passed

Shippable Run 8089 status is SUCCESS.
Details
@abadger

This comment has been minimized.

Show comment
Hide comment
@abadger

abadger Jan 5, 2017

Member

Merged to devel and cherrypicked to the stable-2.2 branch. Thanks for the fix!

Member

abadger commented Jan 5, 2017

Merged to devel and cherrypicked to the stable-2.2 branch. Thanks for the fix!

@bcoca bcoca removed the needs_triage label Jan 18, 2017

@ansibot ansibot added bug and removed bugfix_pull_request labels Mar 5, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment