eos_config: extend sessions support validation #20104

Open
wants to merge 1 commit into
from

Projects

None yet

3 participants

@Zanthras
ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

eos

ANSIBLE VERSION
devel
SUMMARY

Fixes #19586

As there is no way of checking ahead of time if session support is complete, I extended the supports_sessions method to attempt all needed aspects of sessions and clean up after the test.

As it was cleaner I moved session generated into the method and made it return the session id for use.

before:
TASK [test EOS configs] ***************************************************
fatal: [switch1]: FAILED! => {"changed": false, "commands": ["configure session ansible_1484078362", "show session-config diffs", "end"], "failed": true, "msg": "matched error in response: show session-config diffs\r\n% Invalid input\r\nswitch2(config-s-ansibl)#"}

after:
TASK [test EOS configs] ***************************************************
changed: [switch1]
 [WARNING]: The current version of EOS on the remote device does not support configuration sessions.  The commit
argument will be ignored
@abadger abadger added networking and removed needs_triage labels Jan 11, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment