vmware_guest: Various fixes and changes (round 2) #20108

Merged
merged 1 commit into from Jan 16, 2017

Projects

None yet

7 participants

@dagwieers
Contributor
ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

vmware_guest

ANSIBLE VERSION

v2.3

SUMMARY

Changes missing from a poor merge probably, but also a few new things.

  • Reordered the examples from important (often used) to less important
    (fewer used)
  • Remove the new_name: option and replace it with the uuid/name
    combination for renaming + added example
  • Added an example using the VM uuid instead of the VM name
  • Also check whether the password is non-empty (rogue merge)
  • Wait for all tasks to finish (to be sure the new facts reflect the
    state)
  • Ensure that on failure we still set the change-bit
  • Removed a set of functions that are unused (related to transfering
    files to guest, or running commands).
@dagwieers dagwieers vmware_guest: Various fixes and changes
Changes missing from a poor merge probably, but also a few new things.
- Reordered the examples from important (often used) to less important
  (fewer used)
- Remove the new_name: option and replace it with the uuid/name
  combination for renaming + added example
- Added an example using the VM uuid instead of the VM name
- Also check whether the password is non-empty (rogue merge)
- Wait for all tasks to finish (to be sure the new facts reflect the
  state)
- Ensure that on failure we still set the change-bit
- Moved a set of functions that are unused (related to transfering
  files to guest, or running commands) to module_utils
6062340
@jctanner jctanner was assigned by ansibot Jan 11, 2017
@abadger abadger removed the needs_triage label Jan 11, 2017
@nerzhul

okay for me

@jctanner jctanner requested a review from bcoca Jan 11, 2017
@bcoca bcoca merged commit 20df62a into ansible:devel Jan 16, 2017

1 check passed

Shippable Run 9178 status is SUCCESS.
Details
@dav1x
Contributor
dav1x commented Jan 16, 2017

lgtm!

@dagwieers dagwieers deleted the dagwieers:vmware_guest-fixes2 branch Jan 16, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment