Don't use rsync-path in synchronize with docker #20118

Merged
merged 1 commit into from Jan 11, 2017

Projects

None yet

6 participants

@jamielennox
Contributor

When you become: with synchronize and docker it sets the rsync-path to
"sudo rsync" to launch rsync on the server as root. Unfortunately due to
docker exec doing stricter argument parsing than ssh this fails to
launch rsync on the server and the sync fails.

For docker though we don't need to launch rsync with sudo we can simply
docker exec -u and rsync as normal to get around the problem.

Closes #20117

@jamielennox jamielennox Don't use rsync-path in synchronize with docker
When you become: with synchronize and docker it sets the rsync-path to
"sudo rsync" to launch rsync on the server as root. Unfortunately due to
docker exec doing stricter argument parsing than ssh this fails to
launch rsync on the server and the sync fails.

For docker though we don't need to launch rsync with sudo we can simply
docker exec -u <user> and rsync as normal to get around the problem.

Closes #20117
9a52236
@j2sol
j2sol approved these changes Jan 11, 2017 View changes

This looks right to me.

@chouseknecht

Seems right.

@chouseknecht
Member

shipit

@abadger abadger merged commit 27d218f into ansible:devel Jan 11, 2017

1 check passed

Shippable Run 9197 status is SUCCESS.
Details
@abadger
Member
abadger commented Jan 11, 2017

@jamielennox thanks for the code, @j2sol and @chouseknecht thanks for reviewing! merged to devel.

@jamielennox jamielennox deleted the jamielennox:docker-synchronize-become branch Jan 11, 2017
@bcoca bcoca removed the needs_triage label Jan 18, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment