New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Auth0 modules #20276

Open
wants to merge 2 commits into
base: devel
from

Conversation

Projects
None yet
4 participants
@haad
Contributor

haad commented Jan 15, 2017

ISSUE TYPE

Feature Pull Request

SUMMARY

Add modules for managing auth0 domains/users.

@mattclay

This comment has been minimized.

Member

mattclay commented Jan 26, 2017

@haad CI failure due to:

2017-01-15 22:11:51 iteritems has been removed in python3.  Alternatives:
2017-01-15 22:11:51     for KEY, VALUE in DICT.items():
2017-01-15 22:11:51     from ansible.module_utils.six import iteritems ; for KEY, VALUE in iteritems(DICT):
2017-01-15 22:11:51     from ansible.compat.six import iteritems ; for KEY, VALUE in iteritems(DICT):
2017-01-15 22:11:51 ./lib/ansible/modules/remote_management/hpilo/hpilo_facts.py:        for cpu, details in memory_details_summary.iteritems():
@mattclay

This comment has been minimized.

Member

mattclay commented Jan 26, 2017

@haad I'm guessing those hpilo files were intended for a different PR (#20273).

@mattclay mattclay added the ci_verified label Feb 1, 2017

@haad haad force-pushed the haad:auth0-modules branch Feb 5, 2017

@ansibot ansibot removed the ci_verified label Feb 5, 2017

@mattclay

This comment has been minimized.

Member

mattclay commented Feb 6, 2017

CI failure due to PEP 8 indentation issues:

2017-02-05 13:03:17 ERROR: PEP 8: lib/ansible/modules/web_infrastructure/auth0_user.py:123:7: E111 indentation is not a multiple of four (current)
2017-02-05 13:03:17 ERROR: PEP 8: lib/ansible/modules/web_infrastructure/auth0_user.py:127:7: E111 indentation is not a multiple of four (current)
2017-02-05 13:03:17 ERROR: PEP 8: lib/ansible/modules/web_infrastructure/auth0_user.py:131:15: E126 continuation line over-indented for hanging indent (current)
2017-02-05 13:03:17 ERROR: PEP 8: lib/ansible/modules/web_infrastructure/auth0_user.py:138:7: E111 indentation is not a multiple of four (current)
2017-02-05 13:03:17 ERROR: PEP 8: lib/ansible/modules/web_infrastructure/auth0_user.py:141:7: E111 indentation is not a multiple of four (current)
2017-02-05 13:03:17 ERROR: PEP 8: lib/ansible/modules/web_infrastructure/auth0_user.py:145:7: E111 indentation is not a multiple of four (current)
2017-02-05 13:03:17 ERROR: PEP 8: lib/ansible/modules/web_infrastructure/auth0_user.py:146:7: E111 indentation is not a multiple of four (current)
2017-02-05 13:03:17 ERROR: PEP 8: lib/ansible/modules/web_infrastructure/auth0_user.py:148:7: E111 indentation is not a multiple of four (current)
2017-02-05 13:03:17 ERROR: PEP 8: lib/ansible/modules/web_infrastructure/auth0_user.py:149:7: E111 indentation is not a multiple of four (current)
2017-02-05 13:03:17 ERROR: PEP 8: lib/ansible/modules/web_infrastructure/auth0_user.py:152:7: E111 indentation is not a multiple of four (current)
2017-02-05 13:03:17 ERROR: PEP 8: lib/ansible/modules/web_infrastructure/auth0_user.py:155:7: E111 indentation is not a multiple of four (current)
2017-02-05 13:03:17 ERROR: PEP 8: lib/ansible/modules/web_infrastructure/auth0_user.py:157:7: E111 indentation is not a multiple of four (current)
2017-02-05 13:03:17 ERROR: PEP 8: lib/ansible/modules/web_infrastructure/auth0_user_facts.py:85:15: E126 continuation line over-indented for hanging indent (current)
2017-02-05 13:03:17 ERROR: PEP 8: lib/ansible/modules/web_infrastructure/auth0_user_facts.py:90:7: E121 continuation line under-indented for hanging indent (current)
2017-02-05 13:03:17 ERROR: PEP 8: lib/ansible/modules/web_infrastructure/auth0_user_facts.py:99:7: E111 indentation is not a multiple of four (current)

@mattclay mattclay added the ci_verified label Feb 6, 2017

@haad haad force-pushed the haad:auth0-modules branch to d186d53 Feb 25, 2017

@ansibot ansibot removed the ci_verified label Feb 25, 2017

@mattclay

This comment has been minimized.

Member

mattclay commented Feb 28, 2017

CI failure in module validation:

2017-02-25 14:14:22 ============================================================================
2017-02-25 14:14:22 lib/ansible/modules/web_infrastructure/auth0_user.py
2017-02-25 14:14:22 ============================================================================
2017-02-25 14:14:22 ERROR:203:requests import found, should use ansible.module_utils.urls instead
2017-02-25 14:14:22 
2017-02-25 14:14:22 ============================================================================
2017-02-25 14:14:22 lib/ansible/modules/web_infrastructure/auth0_user_facts.py
2017-02-25 14:14:22 ============================================================================
2017-02-25 14:14:22 ERROR:203:requests import found, should use ansible.module_utils.urls instead
@haad

This comment has been minimized.

Contributor

haad commented Feb 28, 2017

I know about this. What is proper way to import requests library in a ansible module ?

@mattclay

This comment has been minimized.

Member

mattclay commented Feb 28, 2017

Is there a reason you can't use ansible.module_utils.urls instead of requests?

@haad

This comment has been minimized.

Contributor

haad commented Mar 1, 2017

As there are already modules using requests in a tree I would prefer to keep it as it is. Rather than to rewrite it to use ansible url utils.

@mattclay

This comment has been minimized.

Member

mattclay commented Mar 1, 2017

New modules should use ansible.module_utils.urls. Existing modules using requests are permitted until they can updated. The rationale for using ansible.module_utils.urls is here:

https://github.com/ansible/ansible/blob/devel/lib/ansible/module_utils/urls.py#L92

@ansibot

This comment has been minimized.

Contributor

ansibot commented Jul 3, 2017

@haad this PR contains more than one new module.

Please submit only one new module per pullrequest. For further explanation, please read grouped module documentation

click here for bot help

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment