Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Refactor format_allowed_section in gce_net module. #20814
This is to increase understandability of the code, so hopefully the flow
Hi @peterandiw, thanks for having a look at this. I agree this code is convoluted.
Would you mind some unit tests in test/units/modules/cloud/google/test_gce_net.py (you'll need to create this file)? Adding the tests will allow everyone to keep this function maintained. Furthermore, we're planning a refactoring of the entire module, and so, having tests for standalone functions like this will allow them to be easily ported over.
CI failure due to unit tests: https://app.shippable.com/runs/58945c7fbc668d1000b1047b/2/tests