Fix connection_draining idempotency in ec2_elb_lb #21323
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ansibot
added
affects_2.3
willthames
force-pushed
the
elb_connection_draining_changed
branch
from
e9d70d9
to
cbbcaa3
Compare
willthames
force-pushed
the
elb_connection_draining_changed
branch
from
16a3d3c
to
f5b46be
Compare
ansibot
added
committer_review
bcoca
removed
the
needs_triage
willthames
force-pushed
the
elb_connection_draining_changed
branch
from
f5b46be
to
265dec9
Compare
willthames
force-pushed
the
elb_connection_draining_changed
branch
from
265dec9
to
7648d3c
Compare
|
I don't understand how this fixes #20111. |
added 2 commits
March 9, 2017 09:27
Ensure connection_draining types are equivalent when comparing whether or not connection_draining is being changed. This means that running `ec2_elb_lb` with connection_draining set a second time will now report `changed=False`
Update to current pep8 standards, fix module imports and remove module from exclusion file
willthames
force-pushed
the
elb_connection_draining_changed
branch
from
7648d3c
to
c482368
Compare
s-hertel
approved these changes
Mar 9, 2017
|
shipit |
ryansb
approved these changes
Mar 13, 2017
wilvk
pushed a commit
to wilvk/ansible
that referenced
this pull request
Aug 22, 2017
# This is the 1st commit message:
squash
cloudfront_facts module improvements
* Make more use of AWS Exception information
* Use pythonic dict assignments
* Improve documentation formatting to make option names clearer
in descriptions
* Meet ansible line length requirements
* Tidy up flake8 messages
# This is the commit message #2:
jira: comply with current pep8 rule set
# This is the commit message #3:
[cloud] S3 tests check for boto, but then ask for boto3 in error message (#22002)
# This is the commit message #4:
Update win_robocopy example (#21992)
"flags" is set, thus "recurse" and "purge" will be ignored.
# This is the commit message #5:
corrected some errors/typos and missing import
# This is the commit message #6:
Network action plugin misusing display.debug (#21995)
* The correct answer was in fact display.vvvv
# This is the commit message #7:
Change warning message as advised by bcoca
# This is the commit message #8:
Exceptit (#21864)
* more centralized exception handling
* only remove when verboxse
# This is the commit message #9:
Run destructive win tests when creating instances.
# This is the commit message #10:
Improve galaxy handling of tgz roles
Gerrithub presents tgz downloads that do not have a containing
directory. This causes a stack trace.
As all roles must contain a meta/main.yml, change ansible-galaxy
to use that to determine the enclosing directory (in the case
of multiple meta/main.yml files, use the one with the shortest parent)
Fixes #15413
# This is the commit message #1:
fix for #21729, use VERSION_ID instead of PRETTY_NAME to get release (#21730)
* fix for #21729, use VERSION_ID instead of PRETTY_NAME to get release
# This is the commit message #2:
Fact proccessing fixes (#22003)
* clarify facts assignment for several corner cases
run_once/delegate_facts:
now delegate_facts > run_once, previously run_once always published facts to all hosts in play
include_vars/delegate_to:
now include_vars allows to delegate to a specific host
also fix task_vars exception in delegate_facts/loop as var was removed
fixes #15365
* removed unused loop_var
# This is the commit message #3:
[cloud] ec2_elb_facts fails on accounts with to many ELBs (#21602)
The list_elbs call to boto doesn't use any pagination, so any time there
are more ELBs than the API page size, this module will fail. This change
uses the `next_token` attribute of `ResultSet` to check if there are
still more ELBs to return.
Fixes #21361
# This is the commit message #4:
Fix doc s/Slack/Mattermost/ (#22017)
# This is the commit message #5:
suppress PS "unapproved verb" warning (#22018)
# This is the commit message #6:
removed unused imports and var
# This is the commit message #7:
Deduplicate arcs when combining coverage data. (#22022)
# This is the commit message #8:
initial commit of win_dns_client module (#22016)
# This is the commit message #9:
more compact metadata
# This is the commit message #10:
Run unit tests in isolation w/ coverage support.
# This is the commit message #1:
add common arguments to eos_banner (#22024)
fixes #22015
# This is the commit message #2:
CHANGELOG win_dns_client and win_domain_membership
# This is the commit message #3:
initial commit of win_domain_membership module (#22027)
# This is the commit message #4:
Remove shebangs from unit tests.
# This is the commit message #5:
Add boto to units requirements for s3 test.
# This is the commit message #6:
Disable newer shellcheck tests which don't pass.
# This is the commit message #7:
Reduce CI output processing code coverage.
# This is the commit message #8:
Add retries for ansible-test docker run.
# This is the commit message #9:
win_iis_webapppool module, fixes and improvement (#20680)
* fixes and improvments for win_iis_webapppool module
* fixes following review feedback on win_iis_webapppool
* Fixed a too-long line in win_iis_webapppool documentation.
* Fixed trailing whitespace for pep8 compliance in documentation win_iis_webapppool.py
* fixed bracket bug
* module parameter attributes now populated. Switched to hashtable for result object. Removed remaining ; statement terminators.
* Remove example that was causing CI check failure
# This is the commit message #10:
Extend os image container and disk formats (#21275)
* Support docker as an os_image container format
As says openstack documentation
http://docs.openstack.org/developer/glance/formats.html
docker can be a container format for glance image.
* Support vhdx and ploop as an os_image container formats
As stands in openstack documentation
http://docs.openstack.org/developer/glance/formats.html
those are supported disk formats for glance image.
# This is the commit message #1:
Add quota for the number of floating IP's to allow in Network. (#21471)
* Add quota for the number of floating IP's to allow in Network.
* Add nova_floating_ips and neutron_floating_ips aliases to avoid confusion.
* rename aliases to compute_floating_ips and network_floating_ips.
# This is the commit message #2:
more set/list stuff
# This is the commit message #3:
dont merge extra vars data if none
fixes #21889
# This is the commit message #4:
Ensure that a deprecated module has DOCUMENTATION.deprecated (#22090)
# This is the commit message #5:
cloudstack: fix pep8 cloudstack inventory (#22092)
# This is the commit message #6:
Added support for ANSIBLE_VERBOSITY environment variable
Fixes 22087
Signed-off-by: Sorin Sbarnea <ssbarnea@redhat.com>
# This is the commit message #7:
Added check for avi SDK version as suggested in review. (#21927)
* Added check for avi SDK version as suggested in review.
* Fixed documentation based on review.
* Renamed module_utils.avi to module_utils.avi_ansible_utils
as import of avi.sdk would fail due to name collisions.
Moved the code to check for AVI version into the ansible modules.
* Updated the module with note about reason for name change.
# This is the commit message #8:
Remove `platform` var from container_enabled meta (#22096)
# This is the commit message #9:
S3 object parameter and bucket deletion exclusive (#21830)
Fixes ansible#21796 Prevent users from deleting buckets rather than objects by making object parameter and mode=delobj mutually exclusive in task.
https://github.com/ansible/ansible/issues/21796
# This is the commit message #10:
initial commit of win_domain_controller (#22115)
# This is the commit message #1:
Change `OS` to `VyOS` in vyos_facts module's short description. (#22120)
modified: lib/ansible/modules/network/vyos/vyos_facts.py
# This is the commit message #2:
Check right CLI context is set on iosxr action plugin (#22108)
Fixes #21994
# This is the commit message #3:
Clean up group name before creation to remove spaces etc .. (#22020)
# This is the commit message #4:
Fix/cs resoucelimit pep8 (#22102)
* cloudstack: cs_resourcelimit: fix type for limit
* cloudstack: cs_resourcelimit: fix pep8
# This is the commit message #5:
fix unquoted dict key (#22105)
# This is the commit message #6:
hpilo_boot: Boot/power via HP iLO mgmt board (#21674)
This is the original `hpilo_boot` module that was once accepted in
Ansible but had been removed subsequently because it could not be tested
by the Ansible project.
Since then it was moved to the ansible-provisioning project and
maintained by HP engineers going forward.
Now we are trying to get it upstreamed again.
# This is the commit message #7:
result.commands (not .updates) (#22139)
# This is the commit message #8:
Added new Avi module to setup SSL profile. (#21934)
* Added new Avi module to setup SSL profile.
* Fixed URL in the documentation.
# This is the commit message #9:
Added new Avi module to setup User Roles. (#21935)
* Added new Avi module to setup User Roles.
* Fixed documentation based on review.
# This is the commit message #10:
Added new Avi module to setup PKI profile. (#21936)
* Added new Avi module to setup PKI profile.
* Fixed documentation based on review.
# This is the commit message #1:
Added new Avi module to setup Network Profile. (#21937)
# This is the commit message #2:
Added new Avi module to setup Certificate Management Profile. (#21938)
* Added new Avi module to setup Certificate Management Profile.
* Fixed documentation based on review.
# This is the commit message #3:
Added new Avi module to setup Application profile. (#21939)
# This is the commit message #4:
Added new Avi module to setup Application Persistence profile. (#21940)
# This is the commit message #5:
Added new Avi module to setup Analytics Profile (#21941)
* Added new Avi module to setup Analytics Profile
* Fixed typos in documentation
# This is the commit message #6:
Added new Avi module to setup System configuration. (#21942)
# This is the commit message #7:
Added new Avi module to setup Tenant configuration. (#21943)
# This is the commit message #8:
iso_extract: new module to extract files from ISO images (#21957)
This is the original iso_extract module from the ansible-provisioning project.
We are upstreaming all our modules, and this PR is part of that process.
# This is the commit message #9:
Add win_msg module (#22008)
* new implementation of win_msg. TODO tests
* added check_mode. Get-AnsibleParam for parameters. Default msg is now 'Hello world!'. Use hash for $results.
Re-ordered some parameters alphabetically.
Documentation now in raw strings. Removed spurious required: false. Added metadata.
* Keep pep8 checks happy
* Really keep pep8 checks happy this time
* update Changelog.md
* make bracket style internally consistent
* added units to display_seconds description
# This is the commit message #10:
hpilo_facts: Get facts from HP iLO mgmt board (#21673)
This is the original `hpilo_facts` module that was once accepted in
Ansible but had been removed subsequently because it could not be tested
by the Ansible project.
Since then it was moved to the ansible-provisioning project and
maintained by HP engineers going forward.
Now we are trying to get it upstreamed again.
# This is the commit message #1:
[cloud] Fix AWS Lambda module tests (#21950)
* Revert "Disable broken tests."
This reverts commit 0d455037a2acd4f42ddbc862bfa3a15ed5a1b6f1.
* lambda module - tests - fix year in copyright
* lambda module - tests - mod arguments in each test and eliminate pytest dependency
* lambda module - tests - broaden mocking to protect calls to get_aws_connection_info
* lambda module - tests - refactoring and cleanup
# This is the commit message #2:
Renamed the avi_ansible_utils to avi. Fixed the import error and clea… (#22112)
* Renamed the avi_ansible_utils to avi. Fixed the import error and cleaned up code.
* Refactored all new modules to use the new module_utils.avi
* Added module_utils.avi to python 2.4 skip list
# This is the commit message #3:
Fix #22130 (ini_file crash when destination file don't exists or is e… (#22132)
* Fix #22130 (ini_file crash when destination file don't exists or is empty)
# This is the commit message #4:
docks: add missing colon character
Without the missing colon character, the code block that followed
wasn't rendering properly.
Signed-off-by: Micah Abbott <miabbott@redhat.com>
# This is the commit message #5:
Warn when using the deprecated HEADER_ arguments (#20236)
* Make sure the uri module warns about using the deprecated HEADER_ arguments, so that we can actually deprecate in a future version
* Use module.deprecate
* No need to de-dupe ourselves, looks like it is done somewhere I didn't initially see
# This is the commit message #6:
Fix log_invocation function to pass unittests on python3
Normalize this function to use native strings. Native strings won't
display an extra "u" or "b" character to denote py2 unicode or py3 bytes
types.
# This is the commit message #7:
Provide message instead of backtrace on bad operator (#21851)
Fixes #21847
# This is the commit message #8:
cloud: ovirt/rhev add note old modules were replaced (#22118)
# This is the commit message #9:
Junos provider readd (#21869)
* Restore `provider` to junos_*
Fixes #21824
Fixes #21824
Fixes #21827
* Fix `confirm_timeout` related errors
* Fix glaring issues with _junos_template
# This is the commit message #10:
catches exception in nxos_command and returns failed message (#22151)
Catches exception in Conditional check and returns appropriated failed
message
# This is the commit message #1:
moved metadata to bottom
# This is the commit message #2:
minor display changes in metadata
# This is the commit message #3:
more examples and clearer override docs for conn
fixes #21866
# This is the commit message #4:
Update playbooks_variables.rst
Minor edits
# This is the commit message #5:
wait_for_connection: Wait for system to become reachable (#20011)
* WIP: wait_for_connection: Wait for system to be reachable
This action plugin allows to check when a system is back online and
usable by Ansible.
As an example, when doing a SysPrep and running Enable-WinRM.ps1, it
takes between 10 to 20 seconds between the WinRM TCP port to open, and
it actually being able to server Ansible requests. This time is variable
and depends on the boot process.
Current implementation is specific for Windows (WinRM) only, this will
be fixed shortly.
This fixes #19998
* Support other transport types
* Various improvements
- Fix reported typo
- Add transport_test support in accelerate plugin
- Ensure port is an integer
* Improve examples
* Small fixes
- Use correct ConfigureRemotingForAnsible.ps1 script name
- Only use win_ping when remote shell is known to be Powershell
- Add integration tests to CI framework
# This is the commit message #6:
[GCE] New module: Google Cloud Spanner (#21731)
* [GCE] Google Cloud Spanner module
Supports the creation/updating/deletion of Spanner instances and create/drop databases.
* [GCE] On update, node count will not be reset to one if not specified.
* [GCE] fixed some imports.
* [GCE] rename display_name to instance_display_name
* [GCE] Recreate instance in order to have desired values at create time.
* Fix linter error on imports
* [GCE] Added force_instance_delete option to ensure an instance is not removed by mistake.
* [GCE] Google Cloud Spanner module
Supports the creation/updating/deletion of Spanner instances and create/drop databases.
* [GCE] On update, node count will not be reset to one if not specified.
* [GCE] rename display_name to instance_display_name
* Fix linter error on imports
* fixed doc bug
* Remove imports mistakenly brought in during merge
# This is the commit message #7:
cloud: ovirt: add note about ENGINE_API_FILTER_BY_DEFAULT (#22155)
# This is the commit message #8:
updates prepare_nxos_tests to use nxos_nxapi module (#22150)
replaces nxos_config with nxos_nxapi
# This is the commit message #9:
Ansible Tower job_launch module (#22148)
* Ansible Tower job_launch module
* Added RETURN documentation and fixed import locations
* remove superfluos required attributes, make tags a list, and fix some typos
* only join tags if they are actually a list
* use isinstance instead of type, cleanup imports
# This is the commit message #10:
cloud: ovirt: logout if token is not used (#21517)
# This is the commit message #1:
Added parted module (#20399)
* Added parted module
* Amended documentation
* Improved documentation
* Managed the case of parted not returning device information.
* Fixed Shippable test not passing
* Fixed compatibility with Python 2.4
* Cleanup of the state option, improved flags management, documentation refinements.
* Compacted format function, code style cleanups, amended comments.
* Fixed bug related to parted data parsing.
* Support for check-mode, amended size data type.
* Fixed Shippable test not passing.
* Added full suport for CHS and CYL units, applied suggested changes.
# This is the commit message #2:
[cloud] New module: gce_template (#20918)
* add gce_template.py
gce template manage GCE Instance Templates in Google Cloud Plateform.
* change gce_template on style/formating
Apply change on style/formating from reviewer request.
* change gce_template on style/formating again.
* Rename gce_template.py to gce_instance_template.py
* update gce_instance_template.py to pass CI
Oops :)
ERROR: Import found before documentation variables.
All imports must appear below DOCUMENTATION/EXAMPLES/RETURN/ANSIBLE_METADATA.
* Update gce_instance_template.py
change documentation replace gce_template by gce_instance_template
* Update gce_instance_template.py
Sorry for the typography fault. The day begins badly.
* Update gce_instance_template.py
apply text change
s/Compte/Compute/
s/Plateform/Platform/
s/forword/forward/
change documentation for subnetwork, subnetwork is name.
add mutually_exclusive in AnsibleModule arguments.
change disk_type as an option type.
* Update gce_instance_template.py
change the documentation.
* Update gce_instance_template.py
RETURN is required for all new modules. Is empty because no new return variable returned.
* Update gce_instance_template.py
Ansible will verify that only present/absent are passed as the state. This else is not needed.
# This is the commit message #3:
Fortios ipv4 policy (#21849)
* New module fortios_address_group
* New module fortios_ipv4_policy
* New module fortios_ipv4_policy
* Fix pep8
* Fix alias doc problem
* Fix string format for 2.5 compat + close cnx
* Forgoten if string != ""
* Fix doc, change action to policy_action & add action as alias
* fix doc + bug in timeout + duplicate code for config compare
* Create class AnsibleFortios in module_utils/forios.py + use in ipv4_policy module
* remove json import
* python3 error handling compatibility
bad examples for srcadd or dstaddr s/any/all/
remove pyFG dependency in module (moved to module_utils)
id type is int but casted as string
call fortiosansible object sooner
typo in doc
# This is the commit message #4:
Support ansible commands in sanity tests. (#22172)
# This is the commit message #5:
tweak transport_tests to avoid logic duplication (#22158)
# This is the commit message #6:
initial commit of win_disk_image (#22175)
# This is the commit message #7:
Update CHANGELOG.md
# This is the commit message #8:
Add role skeleton support (#17079)
* Add role skeleton support
The default role skeleton used by ansible-galaxy is good, but it doesn't
allow organizations to customize it to suit their needs. This patch
addresses that by adding the option to point ansible-galaxy at a
role skeleton directory. The contents of this directory are then
copied (or rendered) into the output role directory. Appropriate
command line options and configuration entries are added to allow for
further customization from the role skeleton.
* Remove dependency on platforms list from test
Platforms are no longer provided to the template by galaxy init.
Removing the code in our test meta/main.yml template that relied on it.
* Fix whitespace issue
# This is the commit message #9:
initial commit of win_domain module (#22179)
# This is the commit message #10:
win_service_stat: Added module (#21944)
# This is the commit message #1:
Clarify what modules are available for Windows (#21888)
Remove repeated mentions of an incorrect list.
This fixes #20696
# This is the commit message #2:
Rewrote win_service with more options/check_mode (#19143)
# This is the commit message #3:
Typo in Add-DeprecationWarning call (#22168)
Unfortunately the script does not stop/fail because of such errors.
# This is the commit message #4:
win_chocolatey: Add example to upgrade all installed software (#22167)
Add a missing example on how to upgrade all installed software using win_chocolatey.
This fixes #21559
# This is the commit message #5:
win_copy: added remote and content options (#21546)
* win_copy: added remote and content options
* readded comment about original_basename accidentally removed
# This is the commit message #6:
Add Support for CachingMode Setting (#21103)
Add Support for CachingMode Setting
# This is the commit message #7:
Adding registry functionality to win_acl module (#19443)
* Updated win_acl.ps1 module with registry functionality
* adding registry functionality to the most recent win_acl module in ansible/ansible
* updated in sync with win_regedit.ps1
# This is the commit message #8:
fix conflicts in win_chocolatey execution_timeout (#22182)
# This is the commit message #9:
Revert "win_service_stat: Added module" (#22184)
# This is the commit message #10:
added new RETURN block (#22183)
# This is the commit message #1:
cloud: ovirt: Add download image support to disks module (#22101)
This PR fixes: https://github.com/ansible/ansible/issues/22088
# This is the commit message #2:
[cloud] bugfix for `lambda` module with empty environment (#22196)
* lambda module - failing test case: shows lambda create mishandles empty environment
* lambda module - fix lambda create with empty environment
* lambda module - fix lambda create with empty environment - style fixes
# This is the commit message #3:
Ansible Tower job list module (#22164)
# This is the commit message #4:
Ansible Tower job cancel module (#22161)
* Ansible Tower job cancel module
* fix interpreter line
# This is the commit message #5:
Ansible Tower job_wait module (#22160)
* Ansible Tower job_wait module
* clean up documentation and update code comment
# This is the commit message #6:
systemd: return an error when systemctl command isn't available
# This is the commit message #7:
moved any_errors_fatal to base (#21585)
# This is the commit message #8:
New module: cnos_bgp (#21587)
* cnos_bgp module
* Move roles to integration/roles directory and remove aliases file.
* update module short description
* Change module directory name to Lenovo
* change import cnos statement
# This is the commit message #9:
New module: cnos_portchannel (#21589)
* cnos_portchannel initial commit
* Fix line length issue in module
* fix whitespace on line 90
* correct yamllint space issue
* Move roles to integration/roles directory and remove aliases file.
* update module short description
* Change module directory name to Lenovo
* change import cnos statement
# This is the commit message #10:
New module: cnos_interface (#21613)
* initial commit
* fix tab/space issue
* fix space issue in vars/main.yml
* Move roles to integration/roles directory and remove aliases file.
* update module short description
* change module directory name to Lenovo and change import cnos statement
# This is the commit message #1:
New module: cnos_factory (#21740)
* Commit cnos_factory
* fix options {} issue
* update the module short description
* Change module directory name to Lenovo
* change import cnos statement
# This is the commit message #2:
New module: cnos_facts (#21743)
* cnos_facts module commit
* fix options string
* Move roles to integration/roles directory and remove aliases file.
* update module short description
* Change module directory name to Lenovo
* change import cnos statement
# This is the commit message #3:
Fix for cnos.py utility file for Python3.5 (#21750)
* fix in cnos.py utility file
* fix compile errors in cnos.py, update module short description in cnos_vlan.py, move vlan roles under integration/roles
* corrections in readme
* Change module directory name to Lenovo
* change import cnos statement
# This is the commit message #4:
New module: cnos_showrun (#21752)
* initial commit of cnos_showrun
* Move roles to integration/roles directory and remove aliases file.
* update module short description
* Change module directory name to Lenovo
* change import cnos statement
# This is the commit message #5:
New module: cnos_reload (#21753)
* initial commit of cnos_reload
* add parens to options
* update module short description
* Change module directory name to Lenovo
* change import cnos statement
# This is the commit message #6:
New module: cnos_save (#21754)
* initial comment of cnos_save
* Move roles to integration/roles directory and remove aliases file.
* update the module short description
* Change module directory name to Lenovo
* change import cnos statement
# This is the commit message #7:
New module: cnos_command (#21785)
* Initial commit for cnos_command
* Move roles to integration/roles directory and remove aliases file.
* update module short description
* Change module directory name to Lenovo
* change import cnos statement
# This is the commit message #8:
New module: cnos_template (#21786)
* Initial cnos_template commit
* fix compile errs, update short description, move roles to integration/roles
* now commit the module
* Change module directory name to Lenovo
* change import cnos statement
# This is the commit message #9:
New module: cnos_backup (#21787)
* Initial commit of cnos_backup
* Move roles to integration/roles directory and remove aliases file.
* update module short description
* change import cnos statement
# This is the commit message #10:
New module: cnos_rollback (#21788)
* Initial commit for cnos_rollback
* Move roles to integration/roles directory and remove aliases file.
* update module short description
* Change module directory name to Lenovo
* change import cnos statement
# This is the commit message #1:
Initial cnos_image commit (#21789)
* Initial cnos_image commit
* corrected required/default values in documentaiton
* fixed choices for imgtype
* removed a colon
* Move roles to integration/roles directory and remove aliases file.
* update module short description
* Change module directory name to Lenovo
* change import cnos statement
# This is the commit message #2:
New module: cnos_condition_command (#21793)
* Initial commit of cnos_condition_command
* fix pep8 error of line too long
* fix pep8 tab/space issue
* Move roles to integration/roles directory and remove aliases file.
* Update module short description
* Change module directory name to Lenovo
* change import cnos statement
# This is the commit message #3:
New module: cnos_conditional_template (#21794)
* Initial commit of cnos_conditional_template
* fix compile error in module, change module short description, move roles to integration/roles
* fix line length
* Change module directory name to Lenovo
* change import cnos statement
# This is the commit message #4:
New module: cnos_vlag (#21535)
* VLAG module and tests
* Correct the link in the description of the module
* Move roles to integration/roles directory and remove aliases file.
* update module short description
* Change module directory name to Lenovo
* change import cnos statement
# This is the commit message #5:
new module that allows for address service object creation (#20660)
* new module that allows for address service object creation
* added missing check for external library
* doc changes per review
* fixed choices string
* doc changes based on reviewer comments
* - changes per reviewer comments
# This is the commit message #6:
panos new module used for security policy creation (#20778)
* - new module used for security policy creation
* - added support for API key authentication
- added support for Panorama
* documentation changes
* documentation update
* minor doc changes based on review comments
* move ANSIBLE_METADATA
* changes to docs per reviewer comments
# This is the commit message #7:
Adds --role-skeleton to ansible-galaxy man page (#22199)
# This is the commit message #8:
Move cnos_backup. to correct dir (#22207)
# This is the commit message #9:
minor fixes to apt
fixes #22124
# This is the commit message #10:
Ensure that filenames from archives are not expanded
This fixes #21795
# This is the commit message #1:
Overhaul `ansible-test sanity` implementation. (#22177)
- Tests are run to completion instead of stopping on first failure.
- Test results are now parsed instead of passing through to the console.
- Test results can be saved in junit xml format.
- Test results will show up on the Shippable "Tests" result tab.
- Added an experimental --lint option for easier integration with other tools.
- Code smell tests are now usable with the --list-tests, --test and --skip-test options.
- Code split out from executor.py into sanity.py.
- Rename download-logs to download.py and add support for test and coverage results.
- Miscellaneous improvements.
# This is the commit message #2:
fix for handling commands that return no data or error (#22086)
This patch addresses a problem in nxos_facts where certain commands are
not supported or return no data, the module would raise an exception.
With this patch, the nxos_facts module will now print a warning for any
commands that return no data and not populate the facts.
fixes #22001
# This is the commit message #3:
returns xml as a display option to junos_command (#21833)
The display option xml as accidentially removed from the display
argument. This patch adds xml back as an option.
fixes #21823
# This is the commit message #4:
[cloud][test] Use pytest conditional imports instead of nose/SkipTest (#22019)
# This is the commit message #5:
Fix git clone tag with depth=1
* Fixes #21316, add testcase based on this
* Add option `--branch NAME` to git clone command in case of branch or
tag in combination with depth=1
* This option should work back to at least git 1.8 and thus on all
supported distributions
* Provide better warning if depth is dropped
# This is the commit message #6:
update junos_command integration tests (#22213)
fixes integration test to check for full rpc-reply string when
converted from xml. This is a change from 2.2 as the rpc-reply tag
is no longer stripped off
# This is the commit message #7:
Extend SSH Retry to put_file and fetch_file (#20187)
* Move retry logic into _ssh_retry decorator, and apply to exec_command, put_file and fetch_file
* Update tests to reflect change
* Move _ssh_retry to _run, and update tests to reflect
* piped should use exec_command instead of removed _exec_command
* Rework tests to support selectors instead of select.select
# This is the commit message #8:
Warn when jinja2 delimiters are found in a when statement (#20312)
* Warn when jinja2 delimiters are found in a when statement
* Use templar._clean_data to look for templating
# This is the commit message #9:
Fix variable precedence of INI/script vars to be in-line with docs.
This commit also adds a new test script (ansible-var-precedence-check.py in code-smell/)
to provide us with another line of defense against precedence bugs going forward.
The precedence docs state that the INI vars have a lower precedence than group/host
vars files for inventory and playbooks, however that has not been the case since 2.0
was released. This change fixes that in one way, though not exactly as the docs say.
The rules are:
1) INI/script < inventory dir < playbook dir
2) "all" group vars < other group_vars < host_vars
So the new order will be (from the test script mentioned above):
8. pb_host_vars_file - var in playbook/host_vars/host
9. ini_host_vars_file - var in inventory/host_vars/host
10. ini_host - host var inside the ini
11. pb_group_vars_file_child - var in playbook/group_vars/child
12. ini_group_vars_file_child - var in inventory/group_vars/child
13. pb_group_vars_file_parent - var in playbook/group_vars/parent
14. ini_group_vars_file_parent - var in inventory/group_vars/parent
15. pb_group_vars_file_all - var in playbook/group_vars/all
16. ini_group_vars_file_all - var in inventory/group_vars/all
17. ini_child - child group var inside the ini
18. ini_parent - parent group var inside the ini
19. ini_all - all group var inside the ini
Fixes #21845
# This is the commit message #10:
Disable failing tests until they can be fixed.
# This is the commit message #1:
adds eos_system integration tests (#22214)
* adds integration test cases
* updates eos_system with minor bug fixes
# This is the commit message #2:
Re-enable ssh retry tests with isolation fixes (#22221)
* Re-enable ssh retry tests with isolation fixes
* Don't use mock, use monkeypatch instead
# This is the commit message #3:
Bumping docs footer copyright year (#22210)
# This is the commit message #4:
Clarified when control_path is ignored (#20968)
# This is the commit message #5:
Update documentation for passwordstore lookup (#21448)
* Update documentation for passwordstore lookup
* Style fixes
* Style fixes
* Reword introduction text
* Update playbooks_lookups.rst
Minor tweaks.
# This is the commit message #6:
Update dead support link (#22212)
* Update dead support link
Visit https://www.ansible.com/, and you'll find the support link points to this URL, https://access.redhat.com/products/ansible-tower-red-hat/.
The current link is a dead link.
* update github code blocks link
# This is the commit message #7:
ansible_winrm_kerberos_delegation (#22113)
Add a note of how to turn on delegation when using kerberos.
# This is the commit message #8:
Fixes #22136 (#22137)
# This is the commit message #9:
Add flag to Docker pull_image to know when the image is already latest (#21508)
* Add flag to Docker pull_image to know when the image is already latest
Whenever the flag pull is set to 'yes' the resource is always defined
as 'changed'. That is not true in case the image is already at the
latest version.
Related to ansible/ansible#19549
* Docker pull_image does not change status if the image is latest
# This is the commit message #10:
Change comment to reflect the actual code
# This is the commit message #1:
respond with correct vaulting suggestion
fixes #22247
# This is the commit message #2:
[cloud][lxc] Prevent hostname to be set (#22246)
If the host .bashrc holds a var named HOSTNAME, the container
where the lxc_container module will attach to will inherit from
this var, potentially breaking some applications (like rabbitmqctl)
due to an incorrect $HOSTNAME reported in the container.
# This is the commit message #3:
[cloud] Add supports_check_mode to ec2_ami_find (#22180)
ec2_ami_find is a facts module, and makes no
changes, so trivially supports check mode
# This is the commit message #4:
ec2_vpc_subnet: cope with empty tags (#21813)
ensure_tags fails if `tags` is None rather than an empty
dict. Ensure that not passing `tags` parameter is equivalent
to passing an empty dict.
Fixes #21778
# This is the commit message #5:
Create custom JSONEncoder to stringify Exceptions
# This is the commit message #6:
[inventory/aos] Few fixes and small tweaks (#22259)
* Add ads server itself as an host in the inventory
* Comment all value in example
* Add Id in variable list per device
* Centralize code to add device status to variables
* Fix device variable name for blueprint
# This is the commit message #7:
CHANGELOG adding missing PANOS modules (#22209)
# This is the commit message #8:
Update expired keys (#21539)
If a key has expired it will not be added by this module, so check for "expired" in the list of keys.
Example output with expired key:
pub 1024D/5072E1F5 2003-02-03 [expired: 2017-02-16]
uid MySQL Release Engineering <mysql-build@oss.oracle.com>
# This is the commit message #9:
Improve YAMLSyntax/Gotchas (#21575)
* Improve YAMLSyntax/Gotchas
Colons don't need to be quoted unless when followed by a space or the end of the line
* Update YAMLSyntax.rst
Minor edit.
# This is the commit message #10:
fix azure_rm version checks (#22270)
* Use packaging.version.Version instead of LooseVersion for better support of prerelease tags (eg, 0.30.0 > 0.30.0rc6)
* Add explicit check/error for msrestazure package
# This is the commit message #1:
add python version info to --version (#22089)
* add python info to ansible --version
* Add unit tests for cli.CLI.version
# This is the commit message #2:
Support matching original path for a moved module location
# This is the commit message #3:
Support option renaming in validate-modules.
# This is the commit message #4:
Fix encoding issue in shippable downloader.
# This is the commit message #5:
doc: Document --syntax-check flag for ansible-playbook (#22256)
It wasn't previously documented outside of the help / manpage, which made it less discoverable.
# This is the commit message #6:
documentation: add important information about attributes parameter (#18732)
If the attributes aren't set in the right order the module always detect
an attributes change.
# This is the commit message #7:
timezone: Inline emphasis start-string without end-string (#22292)
Fixes
`docs/docsite/rst/timezone_module.rst:20: WARNING: Inline emphasis start-string without end-string.`
# This is the commit message #8:
Add extends_documentation_fragment back (#22293)
# This is the commit message #9:
Inventory default groups 'all' and 'ungrouped': add tests and documentation (#21728)
* inventory: test 'all' & 'ungrouped' groups created by default
* Mention default groups 'all' & 'ungrouped'
* Update intro_inventory.rst
Minor grammatical edit.
# This is the commit message #10:
Added example of referring to AWS-credentials (#21560)
* Added example of referring to AWS-credentials
.. when they're stored in variables. Spent few hours trying to figure out why credentials from vault/variables were not used.
* Update guide_aws.rst
Edited for grammar.
# This is the commit message #1:
Add some additional value quoting examples (#20464)
The existing examples in the "Gotchas" section were rather simple. Expanded upon those to add some additional clarity around how the quoting in YAML works.
# This is the commit message #2:
Fix Docs build issues (#22295)
* restore network docs fragments
* Fix RST errors
* code-block formatting
# This is the commit message #3:
cloudstack: cs_sshkeypair: fix fingerprint not used as identifier (#22276)
* cloudstack: cs_sshkeypair: fix fingerprint not used as identifier
* remove from legacy
* fix for 2 keys, one with name and one with fingerprint
# This is the commit message #4:
cloudscale: Document SSH host key retrieval (#22299)
Document how the cloudscale_server module can be used to retrieve the
SSH host keys of the server.
# This is the commit message #5:
dellos* modules- Documentation Update (#22306)
# This is the commit message #6:
Fixes idempotency issue when upgrading chocolatey packages (#21476)
# This is the commit message #7:
Restore extends_documentation_fragment: nxos (#22312)
* Restore extends_documentation_fragment: nxos
* Restore extends_documentation_fragment: nxos
# This is the commit message #8:
[cloud] allow ec2_lc to take user data from binary files w/ user_data_path (#20138)
* Add user_data_path parameter to ec2_lc module
* Improve user_data_path parameter documentation
- Specify mutual exclusivity
- Specify `version_added`
- Change module parameter type to `path`
* Use correct comparison for user_data result
* Include traceback on error and use with block
* Only hide user data if provided in file
# This is the commit message #9:
lambda: Fix adding environment variables to functions previously not having any (#22313)
# This is the commit message #10:
Show diff when file: state=link changes the symlink target (#22243)
* Show diff when file: state=link changes the symlink target
* Integration test for symlink target change
* Also check soft link idempotency
# This is the commit message #1:
simplified if
# This is the commit message #2:
[cloud] Fix data types in ec2_elb_lb causing resource to be spuriously updated (#21906)
fixes broken idempotence caused by the idle_timeout and cross_az_load_balancing params. (#21906)
# This is the commit message #3:
Do not pass filters to os_group get_group call (#22321)
As default is set to None, the get_group call doesn't find groups
on domain 'None'.
Only pass filters in case we pass domain_id value.
# This is the commit message #4:
[cloud] Avoid failures in RDS modyue due to throttling while waiting (#22271)
1. Check less aggressively for resources that take a long time to return
(some resources can take an hour or more).
2. Handle throttling when checking for resources, and back off quickly
when it occurs.
# This is the commit message #5:
Pre-compile regexes to speed up target processing.
Without this, changing a large number of files results in target
processing taking a very long time due to repeatedly compiling
the same patterns in a loop over many targets.
# This is the commit message #6:
Fix Issue #20553 #15737 - merge with reg functionality #19443 (#20555)
# This is the commit message #7:
Use a dedicated directory for the mongodb modules (#22187)
* Use a dedicated directory for the mongodb modules
* Missing the RETURN documentation in mongodb_user
# This is the commit message #8:
Fixes baseclass for new f5 modules (#22333)
# This is the commit message #9:
Add changelog entry for Lambda module updates (#22327)
# This is the commit message #10:
[cloud] Fix ZeroDivisionError in ec2_elb_facts module (#22332)
# This is the commit message #1:
Standardizing syntax for 'Playbook Loops' documentation (#20863)
# This is the commit message #2:
azure_rm inventory version comparison fix (#22341)
# This is the commit message #3:
Remove 'update' param from documentation examples (#22350)
The 'update' param is no longer supported, thus removing from docs.
# This is the commit message #4:
I think for now I'll just not use dunder setter (#22336)
# This is the commit message #5:
Correct `module:`, it should match filename (#22296)
* Validate module: matches filename
* remove testcase
* Revert module validation, move to different PR
# This is the commit message #6:
Ec2_tag support for check mode (#21779)
# This is the commit message #7:
virt.py: autostart VM attribute (#22208)
* virt.py: autostart VM attribute
autostart is now an idempotent VM attribute instead of a non idempotent forced autostart attribute set to True
* Make shippable happy
* Missing version added
* Fix some points
* Autostart default is now None
* Ident fix
# This is the commit message #8:
Fixing issue #22193 - authorize argument is not deprecated for 2.3 for ios and eos (#22326)
# This is the commit message #9:
Verify that the role specification is using a comma before warning
One way to trigger this is having this snippet in meta/main.yml:
dependencies:
- role: foo
when: "use_foo == True"
It shouldn't show a warning but since we assume that 'foo' is the old
style format, it always show one. So we should verify the
style before calling role_spec_parse.
# This is the commit message #10:
Fix invocations of module.fail_json with no msg=
Bonus: add missing % in cs_nic.py
# This is the commit message #1:
Idempotency fix for iosxr_config (#22365)
Multiple fixes to address idempotency issues, along with refactor of
module_utils iosxr to look like ios, for code consistency.
Fixes #22315
# This is the commit message #2:
Move summary to be next to where github places the commit message. (#22368)
If a user makes a PR with a single, detailed commit message, github will
put that at the top of the PR. Move our summary field to the top of
the PR template so that it is next to where the commit message is
placed. Users can then easily merge the two together or supplement the
commit message with additional information that we ask for.
# This is the commit message #3:
rename return var to avoid conflicts
fixes #22323
# This is the commit message #4:
fix 'ungrouped' issue with some inventory formats
# This is the commit message #5:
fixed ungrouped definition
# This is the commit message #6:
Document synchronize limitations around become and connections (#22373)
* Document synchronize limitations around become and connections
# This is the commit message #7:
Bad extra early (#22322)
* catch bad extra vars data earlier
* incoporated @alkins feedback
# This is the commit message #8:
composer: fix escape working_dir (#22363)
* composer: fix escaping of path working_dir
* composer: fix pep8
# This is the commit message #9:
ec2_group: description is only required when group state is present (#19791)
* description is only required when group state is present
also note that AWS requires a non-empty description when creating a security group
* clarify description requirement
# This is the commit message #10:
Retain vault password as bytes in 2.2 (#22378)
* Retain vault password as bytes in 2.2
Prior to 2.2.1, the vault password was read in as byes and then remained
bytes all the way through the code. A bug existed where bytes and text
were mixed, leading to a traceback with non-ascii passwords. In devel,
this was fixed by changing the read in password to text type to match
with our overall strategy of converting at the borders. This was
backported to stable-2.2 for the 2.2.1 release.
On reflection, this should not have been backported as it causes
passwords which were originally non-utf-8 to become utf-8. People will
then have their working 2.2.x vault files become in-accessible.
this commit pipes bytes all the way through the system for vault
password. That way if a password is read in as a non-utf-8 character
sequence, it will continue to work in 2.2.2+. This change is only for
the 2.2 branch, not for 2.3 and beyond.
Why not everywhere? The reason is that non-utf-8 passwords will cause
problems when vault files are shared between systems or users. If the
password is read from the prompt and one user/machine has a latin1
encoded locale while a second one has utf-8, the non-ascii password
typed in won't match between machines. Deal with this by making sure
that when we encrypt the data, we always use valid utf-8.
Fixes #20398
(cherry picked from commit 5dcce0666a81917c68b76286685642fd72d84327)
# This is the commit message #1:
Moved exception handler in a little bit (#22376)
It wasn't being caught in the previous indentation
# This is the commit message #2:
Create bot friendly sanity output. (#22381)
# This is the commit message #3:
Add `test/runner` to $PATH in `hacking/env-setup`. (#22387)
# This is the commit message #4:
Run all `other` tests on Shippable before failing.
# This is the commit message #5:
Use lint friendly output for python syntax checks. (#22390)
# This is the commit message #6:
Using the wrong variable (#22386)
# This is the commit message #7:
Use lint/junit output for compile test. (#22395)
* Refactor sanity classes for use in all tests.
* Use lint/junit output for compile test.
* Add missing options for compile test.
* Fix early bailout on requirements install.
# This is the commit message #8:
Fix error handling in CI other script.
# This is the commit message #9:
wakeonlan: Bugfix and small improvements (#22389)
- Close the socket after use
- Use proper parameter types
- Remove redundant parameter options
- Clean up docs
- Move module from network/ to remote_management/
- Add check-mode support
# This is the commit message #10:
Add a new module for Cisco Spark notifications (#19348)
* Add a new module for Cisco Spark notifications
* Added authentication validation to check mode
* Re-added description and removed Pylint references
* Moved the authentication test to the spark_message function
* removed duplicate fetch_url statements
* documentation formatting updates and if __name__ update
* recipient typo fix and added correct Formatting options to documentation options
* updated version added to 2.3
# This is the commit message #1:
Fix docs type (#22405)
Fix docs typo
# This is the commit message #2:
cloudstack: cs_firewall: fix pep8 and typo s/endpoint/endport/ (#22406)
# This is the commit message #3:
include upgraded packages in pacman upgrade action (#20713)
* include upgraded packages in pacman upgrade action
* display upgraded packages as diff output for pacman upgrade
* document the packages return key
* add --diff support for installing, removing and checking packages
* include package versions in pacman diff output
# This is the commit message #4:
win_region: Small changes to Add-AnsibleParam and docs (#22310)
# This is the commit message #5:
fixes cache file modules with bad path permissions
now module will fail to load and report an error (turned into warning as this should not be fatal)
fixes #13093
# This is the commit message #6:
iptables module: match=conntrack with ctstate not working (#21976)
# This is the commit message #7:
Add manpage for ansible-console. (Closes: #16244) (#16245)
* Add manpage for ansible-console. (Closes: #16244)
* Mark host as an optional field in ansible-console.1
# This is the commit message #8:
Fixes for idempotent issue in cnos_vlan module and fixes for vlag/portchannel tests. (#22385)
* misc fixes for idempotent issue in cnos_vlan
* Fix up hyperlinks in module documentation
* spell correction
# This is the commit message #9:
cloudstack: cs_vpc: fix vpc in projects not found (#22416)
# This is the commit message #10:
Fix PEP 8 issue.
# This is the commit message #1:
Test system (#22420)
* ios_system
* tests for ios_system
* tests for *_system
* working ios_system on cli
* Typo
* Loopback10 (single word, upeprcase)
* Revert docs changes
* Working iosxr_system tests
* eos, not nxos
* nxos_system
# This is the commit message #2:
updated better yaml host examples
# This is the commit message #3:
ensure all hosts in all
fixes #20252
# This is the commit message #4:
vault: call is_encrypted directly in is_encrypted_file
Doing the conversion and checking for exceptions there is pointless
since is_encrypted already does it.
# This is the commit message #5:
vault: Uniformize construction of cipher objects
# This is the commit message #6:
Disable ansible color output on sanity tests.
# This is the commit message #7:
readd all.add_host as for loop uses diff data
# This is the commit message #8:
Actual attributes were being created and messing with the modules (#22424)
# This is the commit message #9:
Add document about connecting to localhost (#20534)
* Add document about connecting to localhost
* Update intro_getting_started.rst
* Update intro_getting_started.rst
Edited.
* Added description about ansible_python_interpreter
# This is the commit message #10:
Fix the eos_banner idempotency (#22413)
The map_config_to_obj calls the run_commands helper function,
which returns a list of results.
However, the map_params_to_obj return a single string.
Therefore, the comparison between the two datasets could never be equal,
breaking idempotency.
Also, the 'no banner' command should be run on absent only if there's a banner
text set.
Fixes #22194
# This is the commit message #1:
wait_for_connection: Update the docs to implementation (#22400)
* Update the docs to conform to implementation
Somehow the docs were still mentioning a default timeout of 300 seconds.
Whereas the implementation defaults to 600 seconds.
* Improve examples even more
# This is the commit message #2:
Update roadmap for Amazon Modules
# This is the commit message #3:
Fix invalid fields in module DOCUMENATION (#22297)
* fix module doc fields
* More module docs corrections
* More module docs corrections
* More module docs corrections
* More module docs corrections
* correct aliases
* Review comments
* Must quote ':'
* More authors
* Use suboptions:
* restore type: bool
* type should be in the same place
* More tidyups
* authors
* Use suboptions
* revert
* remove duplicate author
* More issues post rebase
# This is the commit message #4:
Add simple module to import/delete ssl certificate from/to java keystore (#20274)
* Add simple module to import/delete ssl certificate from/to java keystore.
* add diff/check mode support, fix reported issues and simplify decision logic
* Fix build by adding new line at the end of file.
* Some updates to module requested PR review
* Add simple executable parameter
* Fix build error
# This is the commit message #5:
Make vault encrypt/create/etc confirm pass again.
Make the 'write' modes of vault confirm a new password
before using, again.
This was unintentionally disabled in
309f54b709d489114841530663642b7f3ad262ec previously.
Fixes #22438
# This is the commit message #6:
added java_cert module, did some cleanup
# This is the commit message #7:
added stuff to changelog
# This is the commit message #8:
deal with other 'ungrouped' corner cases
# This is the commit message #9:
moved network module magic from hardcoded to conf
# This is the commit message #10:
Fix bug in 'Building A Simple Module' doc (#22447)
# This is the commit message #1:
ovirt: dyn_inventory fix Python2 and Python3 compat (#22453)
# This is the commit message #2:
Fix issue on nxos modules when transport is passed via provider (#22488)
The nxos modules read the task level transport variable, thus if
the user pass it via provider the all fail with an UnboundLocalError.
Fixes #22355
# This is the commit message #3:
Test eos_banner (#22201)
* eos_banner docs improvements
* run eos_banner tests
* basic eos_banner tests
* remove trailing newlines
* remove hack
* Various eos_banner fixes
No unicode tests, as the device doesn't support it
Correctly set provider
result.command should be empty list if no changes
* test eos_banner over eapi
* revert docs changes, moved to separate PR
# This is the commit message #4:
add missing files (#22496)
# This is the commit message #5:
Check if file is not a directory with get_bin_path function (#13985)
# This is the commit message #6:
Fix Elasticcache issue where ec2 script would fail on finding lack of primary endpoint address on Redis cluster (#20190)
# This is the commit message #7:
Handle downstream version additions (#22428)
Some downstreams want to ship multiple versions of ansible (Either to
have multiple ansible versions or to have a version that uses python3.X
and a version that uses python2.x). When they do this, they append
a version number to the cli scripts in /usr/bin. This patch will remove
those version numbers before trying to find the ansible python module to
import for this commandline
# This is the commit message #8:
Typo + rephrase (#22526)
# This is the commit message #9:
correctly maps task arguments for eapi transport (#22490)
The provider arguments where not correctly being mapped in the action
plugin for eapi transport. This will now correctly map existing
arguments as well as set the correct defaults for values.
fixes #22442
# This is the commit message #10:
fixes mapping nxapi arguments for nxos action plugin (#22491)
The nxos action plugin does not properly map task arguments when using
provider. This patch will fix the problem and properly map the
arguments
# This is the commit message #1:
Junos fixes (#22423)
* Fixes for junos_config errors
* Check transport settings for core Junos
* Don't pop from the same list you iterate over
* use of persistent connections are now explicitly enabled in junos
* modules must now explicitly enable persistent connections
* adds rpc support to junos_command
fixes #22166
# This is the commit message #2:
updates junos shared lib and action handler (#22541)
* removes cli functions from shared lib
* adds cli functions to junos_netconf module
* statically pins junos_netconf to cli transport
* all other modules use netconf transport
* adds command rpc function to junos shared
# This is the commit message #3:
updates junos_command to send commands over netconf (#22540)
* junos_command should send all cli commands over netconf
* task based credentials are now optional
* commands and rpcs are not mutually exclusive anymore
# This is the commit message #4:
minor clean up of junos_command (#22545)
* removes unneeded check_transport function
* removes unneeded global vars
* verifies all integration tests are passing
# This is the commit message #5:
clean tests results
removed redundant pyc line
# This is the commit message #6:
roll up of fixes and updates for junos modules (#22543)
* removes cli functions
* adds comment and confirm to arguments
* implements zeroize argument
* fixes get_diff function in junos shared lib to return diff
* lots of minor bug fixes in junos_config
* minor syntax fixes in junos_netconf
* updates netconf integration tests
# This is the commit message #7:
Remove invalid `type:` (#22548)
# This is the commit message #8:
eos_template is deprecated (#22549)
# This is the commit message #9:
Enable path expansion in GCE modules
This is basically a replay of #16064 from `gce.py` to other pertinent
`gce_*.py` files. It enables expansions of paths in `gce.ini` like
`~/.project.json`
# This is the commit message #10:
Junos facts (#22550)
* Update metadata & docs
* basic facts add
* Start building facts
* Retrofit more junos_facts
* Reimplement facts again
* Hardware
* Hook up config
* Hook up interfaces
* updates junos_facts to use netconf
* updates default facts
* adds config facts
* updates hardware facts
* updates interface facts
# This is the commit message #1:
fixes candidate var type in junos shared lib (#22551)
* candidate var can now be string, list or element
* fixes minor bug in junos_template for backup argument
* disabled invalid integration test for junos_template
# This is the commit message #2:
Fix junos prompt issue (#22536)
Need to handle junos shell prompt
that end's with '%'
# This is the commit message #3:
s3_bucket: fixes #22464 without fully implementing support for ceph bucket update (#22538)
# This is the commit message #4:
Mark keystore_pass as 'no_log', to avoid leaking it
# This is the commit message #5:
Fix iptables TypeError if state/match/ctstate missing
Completely untested...
Fixes #22465
# This is the commit message #6:
[cloud] Convert nat gateway facts to ansible format (#20962)
Use camel_dict_to_snake_dict
# This is the commit message #7:
cloud: ovirt: Fix ovirt_tags documentation (#22569)
# This is the commit message #8:
[cloud] change returned type of tag in ec2_snapshot_facts, fix #22431. (#22432)
Signed-off-by: Xia Kai(夏恺) <xiaket@gmail.com>
# This is the commit message #9:
Update ROADMAP_2_3.rst
# This is the commit message #10:
[cloud] fix connection_draining idempotency in ec2_elb_lb (#21323)
* Fix connection_draining idempotency in ec2_elb_lb
Ensure connection_draining types are equivalent when comparing
whether or not connection_draining is being changed.
This means that running `ec2_elb_lb` with connection_draining
set a second time will now report `changed=False`
* ec2_elb_lb: fixed latest Ansible standards compliance
Update to current pep8 standards, fix module imports
and remove module from exclusion file
# This is the commit message #1:
Changes command and entrypoint to type list
# This is the commit message #2:
Add no_log to all network module_utils provider argument (#22566)
The provider argument on the network modules argspec can contain
credentials.
Make sure we don't log it.
Fixes #21892
# This is the commit message #3:
Stricter module documentation validation (#22353)
Raise the bar for module `DOCUMENTAION`
This validator update was used to find the issues in https://github.com/ansible/ansible/pull/22297/files
**Validation**
* Updated Validation and docs to enforce more (items fixed in https://github.com/ansible/ansible/pull/22297/files)
* Use `suboptions` to document complex options
* Validate module name
* Validate deprecated modules have correct ANSIBLE_METADATA
**Module Documentation Generation**
* Document `suboptions:` Example https://gist.github.com/gundalow/4bdc3669d696268328ccc18528cc6718
* Tidy up HTML generation (valid HTML, no empty lists, etc)
**Documentation**
* Clarify the steps for deprecating a module
* Use correct RST headings
* Document `suboptions:` (options)
* Document `contains:` (returns)
**Details**
The aim is to get this (and corresponding module updates) complete by the time `devel` becomes `2.4`, as this allows us to raise the bar for new modules
Example `suboptions` https://gist.github.com/gundalow/4bdc3669d696268328ccc18528cc6718
The aim is to get this PR integrated into `devel` *before* we branch `stable-2.3`, this will allows us to:
* Raise the bar for new modules in 2.4
* Ensure the generated module documentation for 2.3 and higher is improved, important as we will be doing versioned docs moving forward.
# This is the commit message #4:
Handle throttling and move BotoServerError handling to main. (#22383)
Unclear how useful it is to still be catching BotoServerError exceptions
generally, especially when we are now hopefully handling most instances
of throttling, but kept it as it was already in the code. Moved to main
as catching BotoServerErrors inside individual functions will bypass any
AWSRetry.backoff decorator.
Move additional imports to top.
Use python2.6 formatting
A bit of cleanup on imports
Make one more string interpolation Python 2.6 compatible.
# This is the commit message #5:
Format ELBInfo call (#22383)
Move declaration of AWSRetry of get_all_load_balancers so it isn't redeclared for every page of data.
# This is the commit message #6:
warn when name is overloaded as both host and group
added small optimization to base group comparisson
fixes #6545
# This is the commit message #7:
prevent winrm Add-Type debug noise from polluting stderr (#22583)
# This is the commit message #8:
Sort test messages for deterministic output. (#22581)
# This is the commit message #9:
adds connection established message to ansible-connection (#22492)
This will now print a log message that displays how long the ssh
connection took to establish to the remote device. If the connection
established time is exceed it will also print a message to the log file
that the connection attempts have exceed.
Updates default connection retries to 30
fixes #22319
# This is the commit message #10:
[cloud][docs] update ec2_tag documentation example (#22586)
Currently the documentation utilizes with_subelements, but it does not parse the results correctly. By changing to with_items: and specifying the proper list, we are able to tag the instances as expected.
# This is the commit message #1:
cloudstack: fix wrong vpc found by name (#22603)
Fail fast if more than one VPC found with given identifier.
# This is the commit message #2:
New metadata 1.0 (#22587)
Changes to the metadata format were approved here:
https://github.com/ansible/proposals/issues/54
* Update documentation to the new metadata format
* Changes to metadata-tool to account for new metadata
* Add GPL license header
* Add upgrade subcommand to upgrade metadata version
* Change default metadata to the new format
* Fix exclusion of non-modules from the metadata report
* Fix ansible-doc for new module metadata
* Exclude metadata version from ansible-doc output
* Fix website docs generation for the new metadata
* Update metadata schema in valiate-modules test
* Update the metadata in all modules to the new version
# This is the commit message #3:
ovirt: cloud: make the datacenter input compatible (#22483)
This patch makes sure that all inputs of datacenter are compatible. So
it's 'data_center' everywhere.
# This is the commit message #4:
Implement eos_banner for EAPI (#22609)
On EAPI, the multi-line commands are expected to be a dict,
with key/value pairs 'cmd'/'input' .
This change implements that behaviour and fixes the idempotency
on EAPI as well.
Fixes #22494
# This is the commit message #5:
Fix root volume security style options
# This is the commit message #6:
Fixes the build issue pertaining to sphinx-build which is required to build ansible (#22480)
* sphinx-build is required to build ansible
* Fix for building docssite
* Update docsite_requirements.txt
# This is the commit message #7:
Add `--failure-ok` option to `ansible-test`. (#22623)
# This is the commit message #8:
make windows async ... async (#22624)
Fixes #22575 - issue under new exec wrapper where unconstrained handle inheritance (for stdin) caused WinRM to block on breakaway processes. Uses explicit handle inheritance to ensure that only stdin read handle gets inherited. Adds test to ensure that async is actually async.
# This is the commit message #9:
cloudstack: cs_ip_address: fix vpc support (#22625)
* cloudstack: cs_ip_address: fix vpc support
* cloudstack: cs_ip_address: fix pep8
# This is the commit message #10:
cloudstack: cs_staticnat: fix VPC support (#22626)
- Fix the VPC support by adding network to create and update methods
- Fix pep8
# This is the commit message #1:
cloudstack: cs_network: fix VPC support (#22627)
* cloudstack: cs_network: fix vpc support
* cloudstack: cs_network: fix pep8
# This is the commit message #2:
cloudstack: cs_instance: revert VPC support (#22629)
Partly reverts 5374c7cd096b72b7998fb9ef0cad11600273b62c
# This is the commit message #3:
win_service Added -Force option and minor cleanup (#22598)
* win_service Added -Force option and minor cleanup
* Changed parameter and fixed typos
# This is the commit message #4:
win_…
ansibot
added
bug
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ISSUE TYPE
COMPONENT NAME
ec2_elb_lb
ANSIBLE VERSION
SUMMARY
Ensure connection_draining types are equivalent when comparing
whether or not connection_draining is being changed.
This means that running
ec2_elb_lbwith connection_drainingset a second time will now report
changed=False