Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

win_user: Clean up parameter handling and $result hash #21375

Merged
merged 3 commits into from Feb 24, 2017
Merged

win_user: Clean up parameter handling and $result hash #21375

merged 3 commits into from Feb 24, 2017

Conversation

dagwieers
Copy link
Member

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

win_user

ANSIBLE VERSION

v2.3

SUMMARY

Changes include:

  • Use of Get-AnsibleParam and parameter types/validateset
  • Removed parameter validation
  • Replace $result PSObject with normal hash

@dagwieers
win_user: Clean up parameter handling and $result hash
4376c9e 
Changes include:
- Use of Get-AnsibleParam and parameter types/validateset
- Removed parameter validation
- Replace $result PSObject with normal hash
@ansibot
Copy link
Contributor

ansibot commented Feb 14, 2017

cc @nitzmahone
click here for bot help

@ansibot ansibot added affects_2.3 This issue/PR affects Ansible v2.3 bugfix_pull_request module This issue/PR relates to a module. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. needs_triage Needs a first human triage before being processed. windows Windows community labels Feb 14, 2017
@bcoca bcoca removed the needs_triage Needs a first human triage before being processed. label Feb 14, 2017
@dagwieers
Copy link
Member Author

This PR requires PR #21377 to work.

@mattclay mattclay added the ci_verified Changes made in this PR are causing tests to fail. label Feb 14, 2017
@ansibot ansibot removed the ci_verified Changes made in this PR are causing tests to fail. label Feb 23, 2017
@nitzmahone
Copy link
Member

Code looks good to merge, but failing at least one test

@dagwieers
Copy link
Member Author

dagwieers commented Feb 24, 2017 •
edited

Yes, this PR requires PR #21377 to be merged. So close and re-open and fingers crossed :-)

@dagwieers dagwieers closed this Feb 24, 2017
@dagwieers dagwieers reopened this Feb 24, 2017
@ansibot ansibot added core_review In order to be merged, this PR must follow the core review workflow. and removed needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Feb 24, 2017
@dagwieers
Copy link
Member Author

ready_for_review

@gundalow
Copy link
Contributor

Given tests are now green an @nitzmahone approval above I'm merging this into devel

@gundalow gundalow merged commit 78c3004 into ansible:devel Feb 24, 2017
@ansibot ansibot added bug This issue/PR relates to a bug. and removed bugfix_pull_request labels Mar 5, 2018
@ansible ansible locked and limited conversation to collaborators Apr 26, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@nitzmahone nitzmahone nitzmahone approved these changes

Assignees

@nitzmahone nitzmahone

Labels
affects_2.3 This issue/PR affects Ansible v2.3 bug This issue/PR relates to a bug. core_review In order to be merged, this PR must follow the core review workflow. module This issue/PR relates to a module. windows Windows community
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@dagwieers @ansibot @nitzmahone @gundalow @mattclay @bcoca