Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add intg tests for delegate_to/delegate_facts/run_once together #22010

Closed
wants to merge 2 commits into from

Conversation

alikins
Copy link
Contributor

@alikins alikins commented Feb 27, 2017

Cover some of the cases related to issue #15365 and
in particular, exercise the code path that hit
#15365 (comment)

Note: run_once in a 'with_items: {{ groups.some_group }}' likely
doesn't do anything practical since those contradict. But this
tests covers it to avoid any regressions.

ISSUE TYPE
  • Test pull request
COMPONENT NAME

test/integration/targets/delegate_to

ANSIBLE VERSION
ansible 2.3.0 (intg_test_delegate_facts_15365 9e65740488) last updated 2017/02/27 13:06:02 (GMT -400)
  config file = /home/adrian/.ansible.cfg
  configured module search path = [u'/home/adrian/ansible/my-modules']

SUMMARY

Cover some of the cases related to issue #15365 and
in particular, exercise the code path that hit
#15365 (comment)

Note: run_once in a 'with_items: {{ groups.some_group }}' likely
doesn't do anything practical since those contradict. But this
tests covers it to avoid any regressions.

NOTE: This will fail intg tests until #22003 is merged.


@ansibot ansibot added affects_2.3 This issue/PR affects Ansible v2.3 needs_triage Needs a first human triage before being processed. test_pull_requests needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Feb 27, 2017
@@ -54,3 +57,108 @@

- name: remove test file
file: path={{ output_dir }}/tmp.txt state=absent


# For testing the case that hit the traceback at https://github.com/ansible/ansible/issues/15365#issuecomment-282752186
Copy link
Member

@bcoca bcoca Feb 27, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

instead of comments you can set this as 'play name'


# For testing the case that hit the traceback at https://github.com/ansible/ansible/issues/15365#issuecomment-282752186
- hosts: testhost3
tasks:
Copy link
Member

@bcoca bcoca Feb 27, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

for the tests you can disable fact gathering at play level

@alikins alikins force-pushed the intg_test_delegate_facts_15365 branch from 9e65740 to e8b4bf7 Compare Feb 27, 2017
@bcoca bcoca removed the needs_triage Needs a first human triage before being processed. label Feb 27, 2017
@mattclay
Copy link
Member

mattclay commented Feb 28, 2017

CI failure due to yamllint error:

2017-02-27 21:41:12 test/integration/targets/delegate_to/test_delegate_to.yml
2017-02-27 21:41:12   174:1     error    too many blank lines (1 > 0)  (empty-lines)

@mattclay mattclay added the ci_verified Changes made in this PR are causing tests to fail. label Feb 28, 2017
@ansibot ansibot added the affects_2.4 This issue/PR affects Ansible v2.4 label Mar 27, 2017
@ansibot ansibot added the stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. label Apr 11, 2017
@alikins alikins force-pushed the intg_test_delegate_facts_15365 branch from e8b4bf7 to 95e677c Compare May 9, 2017
@ansibot ansibot removed ci_verified Changes made in this PR are causing tests to fail. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. labels May 9, 2017
@alikins alikins force-pushed the intg_test_delegate_facts_15365 branch from 95e677c to 112610c Compare Jun 8, 2017
@alikins alikins force-pushed the intg_test_delegate_facts_15365 branch from 112610c to aef24a4 Compare Jun 19, 2017
@ansibot ansibot added needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. and removed needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Jun 19, 2017
@ansibot ansibot added support:core This issue/PR relates to code supported by the Ansible Engineering Team. stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. labels Jun 29, 2017
@alikins alikins force-pushed the intg_test_delegate_facts_15365 branch from aef24a4 to b8d3fe8 Compare Jul 11, 2017
@ansibot ansibot added needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. and removed stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. labels Jul 11, 2017
@ansibot ansibot removed the needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. label Jul 19, 2017
@ansibot ansibot added the stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. label Jul 27, 2017
@ansibot ansibot added needs_rebase https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Aug 16, 2017
@ansibot ansibot added the test This PR relates to tests. label Sep 10, 2017
@ansibot ansibot added the support:community This issue/PR relates to code supported by the Ansible community. label Nov 21, 2017
alikins added 2 commits Jan 29, 2018
Cover some of the cases related to issue ansible#15365 and
in particular, exercise the code path that hit
ansible#15365 (comment)

Note: run_once in a 'with_items: {{ groups.some_group }}' likely
doesn't do anything practical since those contradict. But this
tests covers it to avoid any regressions.
@alikins alikins force-pushed the intg_test_delegate_facts_15365 branch from b8d3fe8 to ff66e98 Compare Jan 29, 2018
@ansibot ansibot removed needs_rebase https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Jan 29, 2018
@ansibot ansibot added the stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. label Feb 7, 2018
@dagwieers dagwieers added test This PR relates to tests. and removed test This PR relates to tests. test_pull_requests labels Jun 22, 2018
@ansibot ansibot added the core_review In order to be merged, this PR must follow the core review workflow. label Oct 25, 2018
@ansibot ansibot added needs_rebase https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. and removed core_review In order to be merged, this PR must follow the core review workflow. labels Jan 16, 2019
@mattclay
Copy link
Member

mattclay commented Mar 28, 2019

@alikins Are these tests worth rebasing and keeping, or should this PR be closed?

@ansibot ansibot added collection Related to Ansible Collections work collection:f5networks.f5_modules labels Apr 29, 2020
@ansibot ansibot added pre_azp This PR was last tested before migration to Azure Pipelines. and removed stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. labels Dec 7, 2020
@bcoca
Copy link
Member

bcoca commented May 11, 2022

@alikins can you rebase this?

@nitzmahone
Copy link
Member

nitzmahone commented Sep 14, 2022

Closing for inactivity...

@nitzmahone nitzmahone closed this Sep 14, 2022
@ansible ansible locked and limited conversation to collaborators Sep 21, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
affects_2.3 This issue/PR affects Ansible v2.3 affects_2.4 This issue/PR affects Ansible v2.4 collection Related to Ansible Collections work has_issue needs_rebase https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. pre_azp This PR was last tested before migration to Azure Pipelines. support:community This issue/PR relates to code supported by the Ansible community. support:core This issue/PR relates to code supported by the Ansible Engineering Team. test This PR relates to tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants