Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docker_container: add gcplogs to list of supported log_drivers #22433

Closed
wants to merge 1 commit into from

Conversation

isaacliao
Copy link

SUMMARY

Allows the docker_container module to use Docker's Google Cloud Platform logging driver: https://docs.docker.com/engine/admin/logging/gcplogs/

ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME

docker_container

ANSIBLE VERSION
ansible 2.3.0 (devel 2a34f0ce4f) last updated 2017/03/08 16:50:20 (GMT -700)
  config file = 
  configured module search path = Default w/o overrides
  python version = 2.7.5 (default, Aug  2 2016, 04:20:16) [GCC 4.8.5 20150623 (Red Hat 4.8.5-4)]
ADDITIONAL INFORMATION

Before:

TASK [Start a MySQL database container] ****************************************
fatal: [10.4.20.5]: FAILED! => {"changed": false, "failed": true, "msg": "value of log_driver must be one of: json-file,syslog,journald,gelf,fluentd,awslogs,splunk, got: gcplogs"}

After:

TASK [Start a MySQL database container] ****************************************
changed: [10.4.20.5]

@ansibot ansibot added affects_2.3 This issue/PR affects Ansible v2.3 cloud committer_review In order to be merged, this PR must follow the certified review workflow. docker feature_pull_request module This issue/PR relates to a module. needs_triage Needs a first human triage before being processed. labels Mar 9, 2017
@s-hertel s-hertel removed the needs_triage Needs a first human triage before being processed. label Mar 10, 2017
@ansibot ansibot added affects_2.4 This issue/PR affects Ansible v2.4 community_review In order to be merged, this PR must follow the community review workflow. and removed committer_review In order to be merged, this PR must follow the certified review workflow. labels Mar 23, 2017
@ansibot ansibot added the stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. label Apr 11, 2017
@ansibot ansibot added the support:community This issue/PR relates to code supported by the Ansible community. label Jun 29, 2017
@ansibot
Copy link
Contributor

ansibot commented Jul 18, 2017

Copy link
Contributor

@kassiansun kassiansun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chouseknecht
Copy link
Contributor

@isaacliao

Would love to hear your opinions and ideas on the docker_container module at the Ansible Container Working Group. Would you be able to join us? We meet every Monday at 12:00 PM Eastern. Would really appreciate it if you could stop by and help us out.

View more info about the Ansible Container Working Group here.

@ansibot ansibot added the new_contributor This PR is the first contribution by a new community member. label Oct 18, 2017
@ansibot ansibot removed the new_contributor This PR is the first contribution by a new community member. label Nov 3, 2017
@ansibot ansibot added the new_contributor This PR is the first contribution by a new community member. label Jan 22, 2018
@ansibot ansibot added feature This issue/PR relates to a feature request. and removed feature_pull_request labels Mar 2, 2018
@ansibot ansibot added needs_rebase https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. and removed community_review In order to be merged, this PR must follow the community review workflow. labels Mar 18, 2018
@felixfontein
Copy link
Contributor

This has been superseeded by #33579.

@felixfontein
Copy link
Contributor

Since #33579 has been merged, this can be closed.

@jctanner
Copy link
Contributor

@felixfontein checkout out the list of commands in https://github.com/ansible/ansibullbot/blob/master/ISSUE_HELP.md#commands

As a maintainer, you can use one of the various closure commands to close issues and PRs like this.

@jctanner jctanner closed this Aug 23, 2018
@felixfontein
Copy link
Contributor

@jctanner Thanks! I forgot about the additional commands (besides resolved_by_pr, which doesn't apply here) :)

@ansible ansible locked and limited conversation to collaborators Jul 22, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
affects_2.3 This issue/PR affects Ansible v2.3 affects_2.4 This issue/PR affects Ansible v2.4 cloud docker feature This issue/PR relates to a feature request. module This issue/PR relates to a module. needs_rebase https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. new_contributor This PR is the first contribution by a new community member. small_patch stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. support:community This issue/PR relates to code supported by the Ansible community.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants