Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nxos_acl fixes #23915

Merged
merged 4 commits into from Apr 26, 2017
Merged

nxos_acl fixes #23915

merged 4 commits into from Apr 26, 2017

Conversation

Qalthos
Copy link
Contributor

@Qalthos Qalthos commented Apr 24, 2017 •
edited

SUMMARY
ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

nxos_acl

ANSIBLE VERSION
2.4

@ansibot
Copy link
Contributor

ansibot commented Apr 24, 2017

cc @jedelman8 @GGabriele @rahushen @privateip @rcarrillocruz
click here for bot help

@ansibot ansibot added affects_2.4 This issue/PR affects Ansible v2.4 bugfix_pull_request community_review In order to be merged, this PR must follow the community review workflow. module This issue/PR relates to a module. needs_triage Needs a first human triage before being processed. networking Network category labels Apr 24, 2017
@ansibot ansibot assigned privateip and rcarrillocruz and unassigned privateip Apr 24, 2017
@ryansb ryansb removed the needs_triage Needs a first human triage before being processed. label Apr 25, 2017
trishnaguha
trishnaguha suggested changes Apr 26, 2017
View reviewed changes
Copy link
Member

@trishnaguha trishnaguha left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So this initialization results = {} can be removed now https://github.com/Qalthos/ansible/blob/3571cfd7919c0be455f989a987bf87a96ed57148/lib/ansible/modules/network/nxos/nxos_acl.py#L538

@ansibot ansibot added needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. and removed community_review In order to be merged, this PR must follow the community review workflow. labels Apr 26, 2017
@Qalthos
Copy link
Contributor Author

Qalthos commented Apr 26, 2017

Good catch, @trishnaguha, fixed.

@ansibot ansibot added community_review In order to be merged, this PR must follow the community review workflow. and removed needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Apr 26, 2017
@Qalthos Qalthos merged commit f0914ee into ansible:devel Apr 26, 2017
@ansibot ansibot added bug This issue/PR relates to a bug. and removed bugfix_pull_request labels Mar 6, 2018
@Qalthos Qalthos deleted the nxos-vpc-int branch March 13, 2018 16:41
@dagwieers dagwieers added nxos Cisco NXOS community cisco Cisco technologies labels Feb 22, 2019
@ansible ansible locked and limited conversation to collaborators Apr 26, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@rcarrillocruz rcarrillocruz rcarrillocruz approved these changes

@trishnaguha trishnaguha trishnaguha approved these changes

@privateip privateip Awaiting requested review from privateip

Assignees

@rcarrillocruz rcarrillocruz

Labels
affects_2.4 This issue/PR affects Ansible v2.4 bug This issue/PR relates to a bug. cisco Cisco technologies community_review In order to be merged, this PR must follow the community review workflow. module This issue/PR relates to a module. networking Network category nxos Cisco NXOS community
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@Qalthos @ansibot @rcarrillocruz @trishnaguha @dagwieers @privateip @ryansb