New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Ambari Module to gather facts from Apache Ambari. #25103

Open
wants to merge 3 commits into
base: devel
from

Conversation

Projects
None yet
4 participants
@thmshmm

thmshmm commented May 27, 2017

SUMMARY

This module can be used to pull facts from Apache Ambari managed clusters. The first version supports gathering facts about component versions currently deployed on a cluster.

ISSUE TYPE
  • New Module Pull Request
COMPONENT NAME

ambari_facts

Thomas Hamm added some commits May 26, 2017

@ansibot

This comment has been minimized.

Contributor

ansibot commented May 27, 2017

The test ansible-test sanity --test ansible-doc --python 2.6 failed with the following error:

Command "ansible-doc ambari_facts" returned exit status 1.
>>> Standard Error
ERROR! module ambari_facts missing documentation (or could not parse documentation): 'description'

The test ansible-test sanity --test ansible-doc --python 2.7 failed with the following error:

Command "ansible-doc ambari_facts" returned exit status 1.
>>> Standard Error
ERROR! module ambari_facts missing documentation (or could not parse documentation): 'description'

The test ansible-test sanity --test ansible-doc --python 3.5 failed with the following error:

Command "ansible-doc ambari_facts" returned exit status 1.
>>> Standard Error
ERROR! module ambari_facts missing documentation (or could not parse documentation): 'description'

The test ansible-test sanity --test ansible-doc --python 3.6 failed with the following error:

Command "ansible-doc ambari_facts" returned exit status 1.
>>> Standard Error
ERROR! module ambari_facts missing documentation (or could not parse documentation): 'description'

The test ansible-test sanity --test pep8 failed with the following error:

lib/ansible/modules/clustering/ambari_facts.py:195:161: E501 line too long (214 > 160 characters)

The test ansible-test sanity --test replace-urlopen failed with the following error:

Command "test/sanity/code-smell/replace-urlopen.sh" returned exit status 1.
>>> Standard Output
./lib/ansible/modules/clustering/ambari_facts.py:            response = urllib2.urlopen(request)
One or more file(s) listed above use urlopen.
Use open_url from module_utils instead of urlopen.

The test ansible-test sanity --test validate-modules failed with the following errors:

lib/ansible/modules/clustering/ambari_facts.py:0:0: E305 DOCUMENTATION.description: required key not provided @ data['description']. Got None
lib/ansible/modules/clustering/ambari_facts.py:0:0: E305 DOCUMENTATION.options.ambari_host.type: not a valid value for dictionary value @ data['options']['ambari_host']['type']. Got 'str'
lib/ansible/modules/clustering/ambari_facts.py:0:0: E305 DOCUMENTATION.options.ambari_password.type: not a valid value for dictionary value @ data['options']['ambari_password']['type']. Got 'str'
lib/ansible/modules/clustering/ambari_facts.py:0:0: E305 DOCUMENTATION.options.ambari_port.type: not a valid value for dictionary value @ data['options']['ambari_port']['type']. Got 'str'
lib/ansible/modules/clustering/ambari_facts.py:0:0: E305 DOCUMENTATION.options.ambari_protocol.type: not a valid value for dictionary value @ data['options']['ambari_protocol']['type']. Got 'str'
lib/ansible/modules/clustering/ambari_facts.py:0:0: E305 DOCUMENTATION.options.ambari_user.type: not a valid value for dictionary value @ data['options']['ambari_user']['type']. Got 'str'
lib/ansible/modules/clustering/ambari_facts.py:0:0: E305 DOCUMENTATION.options.cluster_name.type: not a valid value for dictionary value @ data['options']['cluster_name']['type']. Got 'str'
lib/ansible/modules/clustering/ambari_facts.py:0:0: E319 RETURN.ambari_cluster_component_versions.contains: required key not provided @ data['contains']. Got None
lib/ansible/modules/clustering/ambari_facts.py:22:0: E106 Import found before documentation variables. All imports must appear below DOCUMENTATION/EXAMPLES/RETURN/ANSIBLE_METADATA.
lib/ansible/modules/clustering/ambari_facts.py:22:0: E107 Imports should be directly below DOCUMENTATION/EXAMPLES/RETURN/ANSIBLE_METADATA.

click here for bot help

@thmshmm thmshmm force-pushed the thmshmm:devel branch to 67aaafb Jun 18, 2017

@ansibot

This comment has been minimized.

Contributor

ansibot commented Jun 27, 2017

@sgargan @supertom @treyperry

As a maintainer of a module in the same namespace this new module has been submitted to, your vote counts for shipits. Please review this module and add shipit if you would like to see it merged.

click here for bot help

@mattclay

This comment has been minimized.

Member

mattclay commented Sep 19, 2018

bot_status

@ansibot

This comment has been minimized.

Contributor

ansibot commented Sep 19, 2018

The test ansible-test sanity --test boilerplate [explain] failed with 2 errors:

lib/ansible/modules/clustering/ambari_facts.py:0:0: missing: __metaclass__ = type
lib/ansible/modules/clustering/ambari_facts.py:0:0: missing: from __future__ import (absolute_import, division, print_function)

The test ansible-test sanity --test validate-modules [explain] failed with 9 errors:

lib/ansible/modules/clustering/ambari_facts.py:0:0: E307 version_added should be 2.8. Currently 2.4
lib/ansible/modules/clustering/ambari_facts.py:0:0: E316 ANSIBLE_METADATA.metadata_version: not a valid value for dictionary value @ data['metadata_version']. Got '1.0'
lib/ansible/modules/clustering/ambari_facts.py:0:0: E322 "cluster" is listed in the argument_spec, but not documented in the module
lib/ansible/modules/clustering/ambari_facts.py:0:0: E322 "host" is listed in the argument_spec, but not documented in the module
lib/ansible/modules/clustering/ambari_facts.py:0:0: E322 "password" is listed in the argument_spec, but not documented in the module
lib/ansible/modules/clustering/ambari_facts.py:0:0: E322 "port" is listed in the argument_spec, but not documented in the module
lib/ansible/modules/clustering/ambari_facts.py:0:0: E322 "protocol" is listed in the argument_spec, but not documented in the module
lib/ansible/modules/clustering/ambari_facts.py:0:0: E322 "user" is listed in the argument_spec, but not documented in the module
lib/ansible/modules/clustering/ambari_facts.py:0:0: E326 Value for "choices" from the argument_spec (['http', 'https']) for "ambari_protocol" does not match the documentation (['http -- Enable unsecured connection', 'https -- Enable secured connection'])

click here for bot help

@ansibot

This comment has been minimized.

Contributor

ansibot commented Sep 19, 2018

Components

lib/ansible/modules/clustering/ambari_facts.py
support: community
maintainers:

Metadata

waiting_on: thmshmm
changes_requested_by: null
needs_info: False
needs_revision: True
needs_rebase: False
merge_commits: []
too many files or commits: False
mergeable_state: unstable
shippable_status: failure
maintainer_shipits (module maintainers): False
community_shipits (namespace maintainers): False
ansible_shipits (core team members): False
shipit_actors (maintainer or core team member): None
shipit_actors_other:
automerge: automerge shipit test failed

click here for bot help

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment