New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set attributes if different #25260

Open
wants to merge 1 commit into
base: devel
from

Conversation

Projects
None yet
5 participants
@wzyboy
Contributor

wzyboy commented Jun 1, 2017

SUMMARY

chattr command line tool supports symbolic operators +, -, and =. However, attributes in file module supports only =. This is inconvenient if you do not know what the original attributes are.

This patch adds support for + and - operator. If you use old syntax (without any operator), the behavior is backwards-compatible.

ISSUE TYPE
  • Feature Pull Request
  • Docs Pull Request
COMPONENT NAME

file

ANSIBLE VERSION
ansible 2.3.0.0
  config file = /home/wzyboy/.ansible.cfg
  configured module search path = Default w/o overrides
  python version = 2.7.13 (default, Feb 11 2017, 12:22:40) [GCC 6.3.1 20170109]
@wzyboy

This comment has been minimized.

Contributor

wzyboy commented Jun 1, 2017

I took a look at the CI details, there are two failures:

  • FreeBSD CI environment failed to setup because the FreeBSD software repo timed out;
  • Ubuntu CI environment failed to sestup because something is wrong with Docker.

This is scary. It is the CI itself to blame, but it still shows red, bold "All checks have failed" with a big error mark. Could I somehow trigger the CI system to try again?

@gundalow

This comment has been minimized.

Contributor

gundalow commented Jun 2, 2017

@wzyboy You can retrigger CI by closing and reopening the PR.
However as a member of the Ansible Group I've got the power to click "rebuild", which I've done for you. Occasionally we do hit timeouts, we are working on reducing them, thanks for understanding.

Looks like there is a merge conflict in lib/ansible/module_utils/basic.py which needs resolving

@ansibot ansibot added the needs_rebase label Jun 2, 2017

@wzyboy wzyboy force-pushed the wzyboy:set_attributes_if_different branch to b21238e Jun 2, 2017

@wzyboy

This comment has been minimized.

Contributor

wzyboy commented Jun 2, 2017

@gundalow Thanks for rebuilding.

Looks like the conflicts came from this one super PR that deals with PEP-8. It was merged 4 hours ago.

I have resolved the conflicts and rebased my commits.

@ansibot ansibot removed the needs_rebase label Jun 2, 2017

@wzyboy wzyboy closed this Jun 2, 2017

@wzyboy wzyboy reopened this Jun 2, 2017

@wzyboy wzyboy closed this Jun 3, 2017

@wzyboy wzyboy reopened this Jun 3, 2017

@ansibot ansibot removed the needs_revision label Jun 3, 2017

@wzyboy

This comment has been minimized.

Contributor

wzyboy commented Jun 12, 2017

It has been 12 days since this PR was opened. Is there anything I need to do to get this merged, before the branch is stale / needs rebasing?

@nitzmahone

This comment has been minimized.

Member

nitzmahone commented Nov 30, 2018

This looks like a good candidate, but needs tests and evaluation against current behavior to make sure it doesn't cause any regressions.

@wzyboy

This comment has been minimized.

Contributor

wzyboy commented Dec 1, 2018

I almost forgot this PR since I had opened it 1.5 years ago...

Let me see if I can still pick this up.

@wzyboy wzyboy force-pushed the wzyboy:set_attributes_if_different branch from b21238e to 95614a7 Dec 1, 2018

@wzyboy wzyboy closed this Dec 3, 2018

@wzyboy wzyboy reopened this Dec 3, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment