New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New module: ETCD, Fixes #25542 #25546

Open
wants to merge 1 commit into
base: devel
from

Conversation

Projects
None yet
8 participants
@jparrill
Contributor

jparrill commented Jun 9, 2017

SUMMARY

Fixes #25542

This Module will allow you to upload key-value to a ETCD server

Actions:

  • Add Key
  • Remove Key
  • Overwrite Key

Support:

  • ETCD V2 for now
  • SSL
  • RBAC
ISSUE TYPE
  • New Module Pull Request
COMPONENT NAME

ETCD New Module

ANSIBLE VERSION
ansible 2.3.0.0
  config file = /etc/ansible/ansible.cfg
  configured module search path = Default w/o overrides
  python version = 2.7.13 (default, May 10 2017, 20:04:36) [GCC 6.3.1 20161221 (Red Hat 6.3.1-1)]
ADDITIONAL INFORMATION

You could find more info in here: https://github.com/padajuan/ansible-module-etcd

@jparrill jparrill force-pushed the jparrill:feature/25542_etcd_module branch Jun 9, 2017

@s-hertel s-hertel removed the needs_triage label Jun 9, 2017

@s-hertel s-hertel changed the title from Fixes #25542, Added ETCD module to New module: ETCD, Fixes #25542 Jun 9, 2017

@ansibot

This comment has been minimized.

Contributor

ansibot commented Jun 9, 2017

The test ansible-test sanity --test ansible-doc --python 2.6 failed with the following error:

Output on stderr from ansible-doc is considered an error.

Command "ansible-doc etcd" returned exit status 0.
>>> Standard Error
[WARNING]: While constructing a mapping from
/root/src/github.com/ansible/ansible/lib/ansible/modules/database/misc/etcd.py,
line 3, column 1, found a duplicate dict key (notes). Using last defined value
only.

The test ansible-test sanity --test ansible-doc --python 2.7 failed with the following error:

Output on stderr from ansible-doc is considered an error.

Command "ansible-doc etcd" returned exit status 0.
>>> Standard Error
[WARNING]: While constructing a mapping from
/root/src/github.com/ansible/ansible/lib/ansible/modules/database/misc/etcd.py,
line 3, column 1, found a duplicate dict key (notes). Using last defined value
only.

The test ansible-test sanity --test ansible-doc --python 3.5 failed with the following error:

Output on stderr from ansible-doc is considered an error.

Command "ansible-doc etcd" returned exit status 0.
>>> Standard Error
[WARNING]: While constructing a mapping from
/root/src/github.com/ansible/ansible/lib/ansible/modules/database/misc/etcd.py,
line 3, column 1, found a duplicate dict key (notes). Using last defined value
only.

The test ansible-test sanity --test ansible-doc --python 3.6 failed with the following error:

Output on stderr from ansible-doc is considered an error.

Command "ansible-doc etcd" returned exit status 0.
>>> Standard Error
[WARNING]: While constructing a mapping from
/root/src/github.com/ansible/ansible/lib/ansible/modules/database/misc/etcd.py,
line 3, column 1, found a duplicate dict key (notes). Using last defined value
only.

The test ansible-test sanity --test validate-modules failed with the following errors:

lib/ansible/modules/database/misc/etcd.py:0:0: E203 requests import found, should use ansible.module_utils.urls instead
lib/ansible/modules/database/misc/etcd.py:0:0: E305 DOCUMENTATION.options.read_timeout.type: not a valid value for dictionary value @ data['options']['read_timeout']['type']. Got 'int'
lib/ansible/modules/database/misc/etcd.py:0:0: E307 version_added should be 2.4. Currently 0.1
lib/ansible/modules/database/misc/etcd.py:0:0: E312 No RETURN provided
lib/ansible/modules/database/misc/etcd.py:176:9: E311 EXAMPLES is not valid YAML

click here for bot help

lib/ansible/modules/database/misc/etcd.py Outdated
description:
- Sets or deletes values in etcd.
- Parent directories of the key will be created if they do not already exist.
version_added: "0.1"

This comment has been minimized.

@Akasurde

Akasurde Jun 11, 2017

Member

s/0.1/2.4/

lib/ansible/modules/database/misc/etcd.py Outdated
state=dict(required=True, choices=['present', 'absent']),
protocol=dict(required=False, default='http', choices=['http', 'https']),
host=dict(required=False, default='127.0.0.1'),
port=dict(required=False, default=4001),

This comment has been minimized.

@Akasurde

Akasurde Jun 11, 2017

Member

Add type='int',

lib/ansible/modules/database/misc/etcd.py Outdated
value=dict(required=False, default=None),
override=dict(required=False, default=False),
allow_redirect=dict(required=False, default=True),
read_timeout=dict(required=False, default=60),

This comment has been minimized.

@Akasurde

Akasurde Jun 11, 2017

Member

Add type='int',

@jparrill jparrill force-pushed the jparrill:feature/25542_etcd_module branch 2 times, most recently Jun 12, 2017

@ansibot

This comment has been minimized.

Contributor

ansibot commented Jun 12, 2017

The test ansible-test sanity --test validate-modules failed with the following error:

lib/ansible/modules/database/misc/etcd.py:0:0: E312 No RETURN provided

click here for bot help

@jparrill jparrill force-pushed the jparrill:feature/25542_etcd_module branch Jun 12, 2017

@ansibot ansibot removed the ci_verified label Jun 12, 2017

@krzysztof-magosa

This comment has been minimized.

Contributor

krzysztof-magosa commented Jun 18, 2017

shipit

@garbled1

This comment has been minimized.

Contributor

garbled1 commented Aug 13, 2017

What revision does this submission require? I'd very much like to have etcd functionality in-tree.

@Akasurde

This comment has been minimized.

Member

Akasurde commented Jan 6, 2018

@jparrill Are you still working on this ?

needs_info

@ansibot ansibot added the needs_info label Jan 6, 2018

@Akasurde Akasurde referenced this pull request Jan 19, 2018

Merged

New module etcd3 #35053

@ansibot

This comment has been minimized.

Contributor

ansibot commented Feb 6, 2018

@jparrill This pullrequest is waiting for your response. Please respond or the pullrequest will be closed.

click here for bot help

@jparrill

This comment has been minimized.

Contributor

jparrill commented Feb 9, 2018

Hi there @Akasurde some time that I didn't work on this, but you need any changes on it?

@ansibot ansibot removed the needs_info label Feb 9, 2018

@jparrill jparrill force-pushed the jparrill:feature/25542_etcd_module branch to 9cbfe24 Feb 20, 2018

@jparrill

This comment has been minimized.

Contributor

jparrill commented Feb 20, 2018

Added changes requested by @Akasurde

@ansibot

This comment has been minimized.

Contributor

ansibot commented Feb 20, 2018

The test ansible-test sanity --test boilerplate [explain] failed with the error:

Command "test/sanity/code-smell/boilerplate.sh" returned exit status 2.
>>> Standard Output
== Missing __metaclass__ = type ==
./lib/ansible/modules/database/misc/etcd.py

== Missing from __future__ import (absolute_import, division, print_function) ==
./lib/ansible/modules/database/misc/etcd.py

The test ansible-test sanity --test validate-modules [explain] failed with 7 errors:

lib/ansible/modules/database/misc/etcd.py:0:0: E307 version_added should be 2.6. Currently 2.4
lib/ansible/modules/database/misc/etcd.py:0:0: E316 ANSIBLE_METADATA.metadata_version: not a valid value for dictionary value @ data['metadata_version']. Got '1.0'
lib/ansible/modules/database/misc/etcd.py:0:0: E322 "ca_cert" is listed in the argument_spec, but not documented in the module
lib/ansible/modules/database/misc/etcd.py:0:0: E323 "cert_ca" is listed in DOCUMENTATION.options, but not accepted by the module
lib/ansible/modules/database/misc/etcd.py:0:0: E324 Value for "default" from the argument_spec (None) for "cert" does not match the documentation ('None')
lib/ansible/modules/database/misc/etcd.py:0:0: E324 Value for "default" from the argument_spec (None) for "password" does not match the documentation ('None')
lib/ansible/modules/database/misc/etcd.py:0:0: E324 Value for "default" from the argument_spec (None) for "username" does not match the documentation ('None (by default etcd will use guest)')

click here for bot help

@ansibot ansibot added the stale_ci label Mar 1, 2018

@Akasurde

This comment has been minimized.

Member

Akasurde commented Apr 9, 2018

@jparrill Any news ?

@jparrill

This comment has been minimized.

Contributor

jparrill commented Jul 3, 2018

Hi buddy, I forgot totally about this module, I will try to make it fixed tomorrow to try to finish the PR.

@Akasurde

This comment has been minimized.

Member

Akasurde commented Jul 4, 2018

@jparrill Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment