New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancements to the cobbler inventory script #25926

Open
wants to merge 4 commits into
base: devel
from

Conversation

Projects
None yet
3 participants
@opoplawski
Contributor

opoplawski commented Jun 20, 2017

SUMMARY

This makes a couple minor and one major change to the cobbler inventory script:

  • Drop note about script not logging in as it appears to be able to do so now
  • Make orderby_keyname a config parameter
  • Handle multiple cobbler servers
ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME

cobbler inventory

ADDITIONAL INFORMATION
@ansibot

This comment has been minimized.

Contributor

ansibot commented Jun 20, 2017

The test ansible-test sanity --test pep8 failed with the following errors:

contrib/inventory/cobbler.py:153:43: E231 missing whitespace after ','
contrib/inventory/cobbler.py:216:20: E111 indentation is not a multiple of four
contrib/inventory/cobbler.py:218:20: E111 indentation is not a multiple of four

click here for bot help

@ryansb

This comment has been minimized.

Contributor

ryansb commented Jun 21, 2017

cc/ @alikins

@opoplawski opoplawski force-pushed the opoplawski:cobbler branch to a18ed8d Sep 14, 2017

@opoplawski

This comment has been minimized.

Contributor

opoplawski commented Sep 14, 2017

Any comments here? I've got some further enhancements - handling sub-profiles as sub-groups, which required shifting to the newer json format of output using 'hosts' and 'children'.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment