New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[service] : Added support for perp http://b0llix.net/perp/. #26230

Open
wants to merge 5 commits into
base: devel
from

Conversation

Projects
None yet
6 participants
@hackman

hackman commented Jun 29, 2017

Added support for perp supervision daemon. We try to detect if
the service is managed by perp and if so we are issuing the proper
commands to manage it.

Signed-off-by: Dimitar Ianakiev dimitar.q@siteground.com

SUMMARY
ISSUE TYPE
  • Feature Pull Request
  • New Module Pull Request
  • Bugfix Pull Request
  • Docs Pull Request
COMPONENT NAME
ANSIBLE VERSION

ADDITIONAL INFORMATION

@bcoca

This comment has been minimized.

Member

bcoca commented Jul 3, 2017

we are moving systems out of the service module, see systemd module, push this as a separate module and make sure facts can detect this as a service manager.

@bcoca bcoca added the needs_revision label Jul 3, 2017

@ansibot ansibot removed the core_review label Jul 3, 2017

@ansibot ansibot added the stale_ci label Jul 18, 2017

@ansibot ansibot added needs_rebase and removed new_contributor labels Nov 3, 2017

@ansibot ansibot added feature and removed feature_pull_request labels Mar 2, 2018

@mitaka mitaka force-pushed the Kyup-com:perp_support branch from d78bffb Mar 30, 2018

@ansibot

This comment has been minimized.

Contributor

ansibot commented Mar 30, 2018

The test ansible-test sanity --test pylint [explain] failed with 104 errors:

lib/ansible/modules/system/perp.py:74:0: unused-wildcard-import Unused import AVAILABLE_HASH_ALGORITHMS from wildcard import
lib/ansible/modules/system/perp.py:74:0: unused-wildcard-import Unused import AnsibleFallbackNotFound from wildcard import
lib/ansible/modules/system/perp.py:74:0: unused-wildcard-import Unused import BOOLEANS_FALSE from wildcard import
lib/ansible/modules/system/perp.py:74:0: unused-wildcard-import Unused import BOOLEANS_TRUE from wildcard import
lib/ansible/modules/system/perp.py:74:0: unused-wildcard-import Unused import DEFAULT_PERM from wildcard import
lib/ansible/modules/system/perp.py:74:0: unused-wildcard-import Unused import EXEC_PERM_BITS from wildcard import
lib/ansible/modules/system/perp.py:74:0: unused-wildcard-import Unused import FILE_ATTRIBUTES from wildcard import
lib/ansible/modules/system/perp.py:74:0: unused-wildcard-import Unused import FILE_COMMON_ARGUMENTS from wildcard import
lib/ansible/modules/system/perp.py:74:0: unused-wildcard-import Unused import HAS_SYSLOG from wildcard import
lib/ansible/modules/system/perp.py:74:0: unused-wildcard-import Unused import HAVE_SELINUX from wildcard import
lib/ansible/modules/system/perp.py:74:0: unused-wildcard-import Unused import KeysView from wildcard import
lib/ansible/modules/system/perp.py:74:0: unused-wildcard-import Unused import MODE_OPERATOR_RE from wildcard import
lib/ansible/modules/system/perp.py:74:0: unused-wildcard-import Unused import Mapping from wildcard import
lib/ansible/modules/system/perp.py:74:0: unused-wildcard-import Unused import MutableMapping from wildcard import
lib/ansible/modules/system/perp.py:74:0: unused-wildcard-import Unused import MutableSequence from wildcard import
lib/ansible/modules/system/perp.py:74:0: unused-wildcard-import Unused import MutableSet from wildcard import
lib/ansible/modules/system/perp.py:74:0: unused-wildcard-import Unused import NUMBERTYPES from wildcard import
lib/ansible/modules/system/perp.py:74:0: unused-wildcard-import Unused import NoneType from wildcard import
lib/ansible/modules/system/perp.py:74:0: unused-wildcard-import Unused import PASSWD_ARG_RE from wildcard import
lib/ansible/modules/system/perp.py:74:0: unused-wildcard-import Unused import PASSWORD_MATCH from wildcard import
lib/ansible/modules/system/perp.py:74:0: unused-wildcard-import Unused import PASS_BOOLS from wildcard import
lib/ansible/modules/system/perp.py:74:0: unused-wildcard-import Unused import PASS_VARS from wildcard import
lib/ansible/modules/system/perp.py:74:0: unused-wildcard-import Unused import PERMS_RE from wildcard import
lib/ansible/modules/system/perp.py:74:0: unused-wildcard-import Unused import PERM_BITS from wildcard import
lib/ansible/modules/system/perp.py:74:0: unused-wildcard-import Unused import PY2 from wildcard import
lib/ansible/modules/system/perp.py:74:0: unused-wildcard-import Unused import PY3 from wildcard import
lib/ansible/modules/system/perp.py:74:0: unused-wildcard-import Unused import SEQUENCETYPE from wildcard import
lib/ansible/modules/system/perp.py:74:0: unused-wildcard-import Unused import SIZE_RANGES from wildcard import
lib/ansible/modules/system/perp.py:74:0: unused-wildcard-import Unused import Sequence from wildcard import
lib/ansible/modules/system/perp.py:74:0: unused-wildcard-import Unused import Set from wildcard import
lib/ansible/modules/system/perp.py:74:0: unused-wildcard-import Unused import USERS_RE from wildcard import
lib/ansible/modules/system/perp.py:74:0: unused-wildcard-import Unused import algorithm from wildcard import
lib/ansible/modules/system/perp.py:74:0: unused-wildcard-import Unused import algorithms from wildcard import
lib/ansible/modules/system/perp.py:74:0: unused-wildcard-import Unused import attribute from wildcard import
lib/ansible/modules/system/perp.py:74:0: unused-wildcard-import Unused import b from wildcard import
lib/ansible/modules/system/perp.py:74:0: unused-wildcard-import Unused import basestring from wildcard import
lib/ansible/modules/system/perp.py:74:0: unused-wildcard-import Unused import binary_type from wildcard import
lib/ansible/modules/system/perp.py:74:0: unused-wildcard-import Unused import boolean from wildcard import
lib/ansible/modules/system/perp.py:74:0: unused-wildcard-import Unused import bytes from wildcard import
lib/ansible/modules/system/perp.py:74:0: unused-wildcard-import Unused import bytes_to_human from wildcard import
lib/ansible/modules/system/perp.py:74:0: unused-wildcard-import Unused import chain from wildcard import
lib/ansible/modules/system/perp.py:74:0: unused-wildcard-import Unused import datetime from wildcard import
lib/ansible/modules/system/perp.py:74:0: unused-wildcard-import Unused import deque from wildcard import
lib/ansible/modules/system/perp.py:74:0: unused-wildcard-import Unused import env_fallback from wildcard import
lib/ansible/modules/system/perp.py:74:0: unused-wildcard-import Unused import errno from wildcard import
lib/ansible/modules/system/perp.py:74:0: unused-wildcard-import Unused import format_attributes from wildcard import
lib/ansible/modules/system/perp.py:74:0: unused-wildcard-import Unused import get_all_subclasses from wildcard import
lib/ansible/modules/system/perp.py:74:0: unused-wildcard-import Unused import get_distribution from wildcard import
lib/ansible/modules/system/perp.py:74:0: unused-wildcard-import Unused import get_distribution_version from wildcard import
lib/ansible/modules/system/perp.py:74:0: unused-wildcard-import Unused import get_flags_from_attributes from wildcard import
lib/ansible/modules/system/perp.py:74:0: unused-wildcard-import Unused import get_module_path from wildcard import
lib/ansible/modules/system/perp.py:74:0: unused-wildcard-import Unused import get_platform from wildcard import
lib/ansible/modules/system/perp.py:74:0: unused-wildcard-import Unused import grp from wildcard import
lib/ansible/modules/system/perp.py:74:0: unused-wildcard-import Unused import has_journal from wildcard import
lib/ansible/modules/system/perp.py:74:0: unused-wildcard-import Unused import hashlib from wildcard import
lib/ansible/modules/system/perp.py:74:0: unused-wildcard-import Unused import heuristic_log_sanitize from wildcard import
lib/ansible/modules/system/perp.py:74:0: unused-wildcard-import Unused import human_to_bytes from wildcard import
lib/ansible/modules/system/perp.py:74:0: unused-wildcard-import Unused import imap from wildcard import
lib/ansible/modules/system/perp.py:74:0: unused-wildcard-import Unused import integer_types from wildcard import
lib/ansible/modules/system/perp.py:74:0: unused-wildcard-import Unused import is_executable from wildcard import
lib/ansible/modules/system/perp.py:74:0: unused-wildcard-import Unused import iteritems from wildcard import
lib/ansible/modules/system/perp.py:74:0: unused-wildcard-import Unused import journal from wildcard import
lib/ansible/modules/system/perp.py:74:0: unused-wildcard-import Unused import json from wildcard import
lib/ansible/modules/system/perp.py:74:0: unused-wildcard-import Unused import json_dict_bytes_to_unicode from wildcard import
lib/ansible/modules/system/perp.py:74:0: unused-wildcard-import Unused import json_dict_unicode_to_bytes from wildcard import
lib/ansible/modules/system/perp.py:74:0: unused-wildcard-import Unused import jsonify from wildcard import
lib/ansible/modules/system/perp.py:74:0: unused-wildcard-import Unused import literal_eval from wildcard import
lib/ansible/modules/system/perp.py:74:0: unused-wildcard-import Unused import load_platform_subclass from wildcard import
lib/ansible/modules/system/perp.py:74:0: unused-wildcard-import Unused import locale from wildcard import
lib/ansible/modules/system/perp.py:74:0: unused-wildcard-import Unused import map from wildcard import
lib/ansible/modules/system/perp.py:74:0: unused-wildcard-import Unused import md5 from wildcard import
lib/ansible/modules/system/perp.py:74:0: unused-wildcard-import Unused import os from wildcard import
lib/ansible/modules/system/perp.py:74:0: unused-wildcard-import Unused import platform from wildcard import
lib/ansible/modules/system/perp.py:74:0: unused-wildcard-import Unused import pwd from wildcard import
lib/ansible/modules/system/perp.py:74:0: unused-wildcard-import Unused import reduce from wildcard import
lib/ansible/modules/system/perp.py:74:0: unused-wildcard-import Unused import remove_values from wildcard import
lib/ansible/modules/system/perp.py:74:0: unused-wildcard-import Unused import repeat from wildcard import
lib/ansible/modules/system/perp.py:74:0: unused-wildcard-import Unused import return_values from wildcard import
lib/ansible/modules/system/perp.py:74:0: unused-wildcard-import Unused import select from wildcard import
lib/ansible/modules/system/perp.py:74:0: unused-wildcard-import Unused import selinux from wildcard import
lib/ansible/modules/system/perp.py:74:0: unused-wildcard-import Unused import sha from wildcard import
lib/ansible/modules/system/perp.py:74:0: unused-wildcard-import Unused import shlex from wildcard import
lib/ansible/modules/system/perp.py:74:0: unused-wildcard-import Unused import shlex_quote from wildcard import
lib/ansible/modules/system/perp.py:74:0: unused-wildcard-import Unused import shutil from wildcard import
lib/ansible/modules/system/perp.py:74:0: unused-wildcard-import Unused import sj_version from wildcard import
lib/ansible/modules/system/perp.py:74:0: unused-wildcard-import Unused import stat from wildcard import
lib/ansible/modules/system/perp.py:74:0: unused-wildcard-import Unused import string_types from wildcard import
lib/ansible/modules/system/perp.py:74:0: unused-wildcard-import Unused import subprocess from wildcard import
lib/ansible/modules/system/perp.py:74:0: unused-wildcard-import Unused import sys from wildcard import
lib/ansible/modules/system/perp.py:74:0: unused-wildcard-import Unused import syslog from wildcard import
lib/ansible/modules/system/perp.py:74:0: unused-wildcard-import Unused import tempfile from wildcard import
lib/ansible/modules/system/perp.py:74:0: unused-wildcard-import Unused import text_type from wildcard import
lib/ansible/modules/system/perp.py:74:0: unused-wildcard-import Unused import time from wildcard import
lib/ansible/modules/system/perp.py:74:0: unused-wildcard-import Unused import to_bytes from wildcard import
lib/ansible/modules/system/perp.py:74:0: unused-wildcard-import Unused import to_native from wildcard import
lib/ansible/modules/system/perp.py:74:0: unused-wildcard-import Unused import to_text from wildcard import
lib/ansible/modules/system/perp.py:74:0: unused-wildcard-import Unused import traceback from wildcard import
lib/ansible/modules/system/perp.py:74:0: unused-wildcard-import Unused import types from wildcard import
lib/ansible/modules/system/perp.py:74:0: unused-wildcard-import Unused import unicode from wildcard import
lib/ansible/modules/system/perp.py:74:0: wildcard-import Wildcard import ansible.module_utils.basic
lib/ansible/modules/system/perp.py:106:0: anomalous-backslash-in-string Anomalous backslash in string: '\('. String constant might be missing an r prefix.
lib/ansible/modules/system/perp.py:106:0: anomalous-backslash-in-string Anomalous backslash in string: '\)'. String constant might be missing an r prefix.
lib/ansible/modules/system/perp.py:106:0: anomalous-backslash-in-string Anomalous backslash in string: '\d'. String constant might be missing an r prefix.
lib/ansible/modules/system/perp.py:110:0: anomalous-backslash-in-string Anomalous backslash in string: '\d'. String constant might be missing an r prefix.

The test ansible-test sanity --test boilerplate [explain] failed with 2 errors:

lib/ansible/modules/system/perp.py:0:0: missing: __metaclass__ = type
lib/ansible/modules/system/perp.py:0:0: missing: from __future__ import (absolute_import, division, print_function)

The test ansible-test sanity --test no-get-exception [explain] failed with 2 errors:

lib/ansible/modules/system/perp.py:73:45: do not use `get_exception`
lib/ansible/modules/system/perp.py:150:17: do not use `get_exception`

The test ansible-test sanity --test pep8 [explain] failed with 12 errors:

lib/ansible/modules/system/perp.py:83:29: E201 whitespace after '['
lib/ansible/modules/system/perp.py:167:22: E251 unexpected spaces around keyword / parameter equals
lib/ansible/modules/system/perp.py:167:24: E251 unexpected spaces around keyword / parameter equals
lib/ansible/modules/system/perp.py:168:17: E251 unexpected spaces around keyword / parameter equals
lib/ansible/modules/system/perp.py:168:19: E251 unexpected spaces around keyword / parameter equals
lib/ansible/modules/system/perp.py:169:18: E251 unexpected spaces around keyword / parameter equals
lib/ansible/modules/system/perp.py:169:20: E251 unexpected spaces around keyword / parameter equals
lib/ansible/modules/system/perp.py:170:20: E251 unexpected spaces around keyword / parameter equals
lib/ansible/modules/system/perp.py:170:22: E251 unexpected spaces around keyword / parameter equals
lib/ansible/modules/system/perp.py:171:17: E251 unexpected spaces around keyword / parameter equals
lib/ansible/modules/system/perp.py:171:19: E251 unexpected spaces around keyword / parameter equals
lib/ansible/modules/system/perp.py:186:25: E231 missing whitespace after ','

The test ansible-test sanity --test validate-modules [explain] failed with 8 errors:

lib/ansible/modules/system/perp.py:0:0: E307 version_added should be 2.6. Currently 2.4
lib/ansible/modules/system/perp.py:0:0: E312 No RETURN provided
lib/ansible/modules/system/perp.py:0:0: E316 ANSIBLE_METADATA.metadata_version: not a valid value for dictionary value @ data['metadata_version']. Got '1.0'
lib/ansible/modules/system/perp.py:0:0: E322 "dist" is listed in the argument_spec, but not documented in the module
lib/ansible/modules/system/perp.py:0:0: E322 "enabled" is listed in the argument_spec, but not documented in the module
lib/ansible/modules/system/perp.py:0:0: E324 Value for "default" from the argument_spec ('perp') for "dist" does not match the documentation (None)
lib/ansible/modules/system/perp.py:0:0: E325 argument_spec for "enabled" defines type="bool" but documentation does not
lib/ansible/modules/system/perp.py:74:0: E208 module_utils imports should import specific components, not "*"

click here for bot help

@mitaka mitaka force-pushed the Kyup-com:perp_support branch Mar 30, 2018

@ansibot ansibot removed the ci_verified label Mar 30, 2018

@ansibot

This comment has been minimized.

Contributor

ansibot commented Mar 30, 2018

The test ansible-test sanity --test boilerplate [explain] failed with 2 errors:

lib/ansible/modules/system/perp.py:0:0: missing: __metaclass__ = type
lib/ansible/modules/system/perp.py:0:0: missing: from __future__ import (absolute_import, division, print_function)

The test ansible-test sanity --test no-get-exception [explain] failed with 2 errors:

lib/ansible/modules/system/perp.py:75:45: do not use `get_exception`
lib/ansible/modules/system/perp.py:152:17: do not use `get_exception`

The test ansible-test sanity --test validate-modules [explain] failed with 3 errors:

lib/ansible/modules/system/perp.py:0:0: E312 No RETURN provided
lib/ansible/modules/system/perp.py:0:0: E322 "dist" is listed in the argument_spec, but not documented in the module
lib/ansible/modules/system/perp.py:0:0: E324 Value for "default" from the argument_spec ('perp') for "dist" does not match the documentation (None)

click here for bot help

@ansibot ansibot added the ci_verified label Mar 30, 2018

module: perp
 Added support for perp(http://b0llix.net/perp/) supervisor daemon.

Signed-off-by: Dimitar Ianakiev <dimitar.q@siteground.com>

@mitaka mitaka force-pushed the Kyup-com:perp_support branch Mar 30, 2018

@ansibot ansibot removed the ci_verified label Mar 30, 2018

dimitarq added some commits Mar 30, 2018

module: perp
 Added RETURN documentation.

Signed-off-by: Dimitar Ianakiev <dimitar.q@siteground.com>
module: perp
 Added boilerplate for "__metaclass__" and "from __future__ import".

Signed-off-by: Dimitar Ianakiev <dimitar.q@siteground.com>
@ansibot

This comment has been minimized.

Contributor

ansibot commented Mar 30, 2018

The test ansible-test sanity --test boilerplate [explain] failed with 2 errors:

lib/ansible/modules/system/perp.py:0:0: missing: __metaclass__ = type
lib/ansible/modules/system/perp.py:0:0: missing: from __future__ import (absolute_import, division, print_function)

The test ansible-test sanity --test no-get-exception [explain] failed with 2 errors:

lib/ansible/modules/system/perp.py:98:45: do not use `get_exception`
lib/ansible/modules/system/perp.py:175:17: do not use `get_exception`

The test ansible-test sanity --test validate-modules [explain] failed with 2 errors:

lib/ansible/modules/system/perp.py:0:0: E319 RETURN.pid.type: not a valid value for dictionary value @ data['type']. Got 'integer'
lib/ansible/modules/system/perp.py:96:0: E107 Imports should be directly below DOCUMENTATION/EXAMPLES/RETURN/ANSIBLE_METADATA.

click here for bot help

@ansibot ansibot added the ci_verified label Mar 30, 2018

module: perp
 Deprecated get_exception.

Signed-off-by: Dimitar Ianakiev <dimitar.q@siteground.com>

@mitaka mitaka force-pushed the Kyup-com:perp_support branch to d12cfc3 Mar 30, 2018

@ansibot

This comment has been minimized.

Contributor

ansibot commented Mar 30, 2018

The test ansible-test sanity --test validate-modules [explain] failed with 1 error:

lib/ansible/modules/system/perp.py:99:0: E107 Imports should be directly below DOCUMENTATION/EXAMPLES/RETURN/ANSIBLE_METADATA.

click here for bot help

@ansibot

This comment has been minimized.

Contributor

ansibot commented Mar 30, 2018

The test ansible-test sanity --test validate-modules [explain] failed with 2 errors:

lib/ansible/modules/system/perp.py:99:0: E107 Imports should be directly below DOCUMENTATION/EXAMPLES/RETURN/ANSIBLE_METADATA.
lib/ansible/modules/system/perp.py:100:0: E107 Imports should be directly below DOCUMENTATION/EXAMPLES/RETURN/ANSIBLE_METADATA.

click here for bot help

@ansibot ansibot added the stale_ci label Apr 7, 2018

module: perp
 Fixing CI error "E107 Imports should be directly below
DOCUMENTATION/EXAMPLES/RETURN/ANSIBLE_METADATA".

Signed-off-by: Dimitar Ianakiev <dimitar.q@siteground.com>

@mitaka mitaka force-pushed the Kyup-com:perp_support branch to 9449f98 May 11, 2018

@ansibot

This comment has been minimized.

Contributor

ansibot commented May 11, 2018

The test ansible-test sanity --test validate-modules [explain] failed with 2 errors:

lib/ansible/modules/system/perp.py:96:0: E107 Imports should be directly below DOCUMENTATION/EXAMPLES/RETURN/ANSIBLE_METADATA.
lib/ansible/modules/system/perp.py:97:0: E107 Imports should be directly below DOCUMENTATION/EXAMPLES/RETURN/ANSIBLE_METADATA.

click here for bot help

@ansibot ansibot added the ci_verified label May 11, 2018

@mitaka

This comment has been minimized.

mitaka commented May 11, 2018

Guys I need help on the failing ci tests. I have checked multiple times and I do believe that my imports are placed directly below DOCUMENTATION/EXAMPLES/RETURN/ANSIBLE_METADATA section. Please advise how to proceed from here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment