Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apt-key absent requires ID, does not use URL #26572

Closed
wants to merge 1 commit into from

Conversation

hvnsweeting
Copy link

@hvnsweeting hvnsweeting commented Jul 10, 2017

SUMMARY

Absent apt-key with URL failed, code requires ID.
By reading code https://github.com/ansible/ansible/blob/devel/lib/ansible/modules/packaging/os/apt_key.py#L360 , I see there is no code to handle URL when run absent apt-key (and it also wasted effort when trying to get a key from URL to know its ID then remove it). So I think using id is better behavior, remove the wrong document.

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

apt_key_module

ANSIBLE VERSION
ansible --version
ansible 2.2.1.0
  config file =
  configured module search path = Default w/o overrides
ADDITIONAL INFORMATION
  tasks:
    - name: Remove apt key
      apt_key:
        url: 'https://pkg.jenkins.io/debian/jenkins.io.key'
        state: absent

@ansibot
Copy link
Contributor

ansibot commented Jul 10, 2017

@hvnsweeting Greetings! Thanks for taking the time to open this pullrequest. In order for the community to handle your pullrequest effectively, we need a bit more information.

Here are the items we could not find in your description:

  • issue type

Please set the description of this pullrequest with this template:
https://raw.githubusercontent.com/ansible/ansible/devel/.github/PULL_REQUEST_TEMPLATE.md

click here for bot help

@ansibot ansibot added affects_2.4 This issue/PR affects Ansible v2.4 needs_info This issue requires further information. Please answer any outstanding questions. needs_template This issue/PR has an incomplete description. Please fill in the proposed template correctly. needs_triage Needs a first human triage before being processed. support:core This issue/PR relates to code supported by the Ansible Engineering Team. bugfix_pull_request and removed needs_info This issue requires further information. Please answer any outstanding questions. needs_template This issue/PR has an incomplete description. Please fill in the proposed template correctly. labels Jul 10, 2017
@alikins alikins removed the needs_triage Needs a first human triage before being processed. label Jul 10, 2017
@ansibot
Copy link
Contributor

ansibot commented Jul 12, 2017

@ansibot ansibot added core_review In order to be merged, this PR must follow the core review workflow. module This issue/PR relates to a module. labels Jul 12, 2017
@ansibot ansibot added the stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. label Jul 20, 2017
@ansibot ansibot added needs_rebase https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. and removed core_review In order to be merged, this PR must follow the core review workflow. labels Sep 1, 2017
@ansibot ansibot added the new_contributor This PR is the first contribution by a new community member. label Oct 18, 2017
@ansibot ansibot removed the new_contributor This PR is the first contribution by a new community member. label Nov 3, 2017
@ansibot ansibot added the new_contributor This PR is the first contribution by a new community member. label Feb 6, 2018
@ansibot ansibot added bug This issue/PR relates to a bug. and removed bugfix_pull_request labels Mar 2, 2018
@Akasurde
Copy link
Member

Already fixed via f2c0969.
Thanks for the contribution.

@Akasurde Akasurde closed this Nov 24, 2018
@dagwieers dagwieers added the packaging Packaging category label Mar 3, 2019
@ansible ansible locked and limited conversation to collaborators Jul 22, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
affects_2.4 This issue/PR affects Ansible v2.4 bug This issue/PR relates to a bug. module This issue/PR relates to a module. needs_rebase https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. new_contributor This PR is the first contribution by a new community member. packaging Packaging category small_patch stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. support:core This issue/PR relates to code supported by the Ansible Engineering Team.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants